From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 02CBCC433E7 for ; Mon, 19 Oct 2020 19:07:37 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4D2F2221FC for ; Mon, 19 Oct 2020 19:07:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4D2F2221FC Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ilande.co.uk Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:40018 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kUaVL-0004Xd-7z for qemu-devel@archiver.kernel.org; Mon, 19 Oct 2020 15:07:35 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42260) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kUaU0-0003Hj-0V for qemu-devel@nongnu.org; Mon, 19 Oct 2020 15:06:12 -0400 Received: from mail.ilande.co.uk ([2001:41c9:1:41f::167]:34666 helo=mail.default.ilande.uk0.bigv.io) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kUaTy-0001Pv-7o for qemu-devel@nongnu.org; Mon, 19 Oct 2020 15:06:11 -0400 Received: from host86-148-246-80.range86-148.btcentralplus.com ([86.148.246.80] helo=[192.168.1.65]) by mail.default.ilande.uk0.bigv.io with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1kUaTy-0001Uk-IP; Mon, 19 Oct 2020 20:06:15 +0100 To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , qemu-devel@nongnu.org References: <20201012170950.3491912-1-f4bug@amsat.org> <20201012170950.3491912-4-f4bug@amsat.org> From: Mark Cave-Ayland Message-ID: <7439e76f-8789-5e93-ce14-f85ae660cd2a@ilande.co.uk> Date: Mon, 19 Oct 2020 20:06:03 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.3.1 MIME-Version: 1.0 In-Reply-To: <20201012170950.3491912-4-f4bug@amsat.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: 86.148.246.80 X-SA-Exim-Mail-From: mark.cave-ayland@ilande.co.uk Subject: Re: [PATCH 3/6] hw/pci-host/sabre: Simplify code initializing variable once X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on mail.default.ilande.uk0.bigv.io) Received-SPF: pass client-ip=2001:41c9:1:41f::167; envelope-from=mark.cave-ayland@ilande.co.uk; helo=mail.default.ilande.uk0.bigv.io X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, NICE_REPLY_A=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 12/10/2020 18:09, Philippe Mathieu-Daudé wrote: > We only need to zero-initialize 'val' once. > > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/pci-host/sabre.c | 12 +----------- > 1 file changed, 1 insertion(+), 11 deletions(-) > > diff --git a/hw/pci-host/sabre.c b/hw/pci-host/sabre.c > index 0889c9369f6..3645bc962cb 100644 > --- a/hw/pci-host/sabre.c > +++ b/hw/pci-host/sabre.c > @@ -195,32 +195,25 @@ static uint64_t sabre_config_read(void *opaque, > hwaddr addr, unsigned size) > { > SabreState *s = opaque; > - uint32_t val; > + uint32_t val = 0; > > switch (addr) { > case 0x30 ... 0x4f: /* DMA error registers */ > - val = 0; > /* XXX: not implemented yet */ > break; > case 0xc00 ... 0xc3f: /* PCI interrupt control */ > if (addr & 4) { > val = s->pci_irq_map[(addr & 0x3f) >> 3]; > - } else { > - val = 0; > } > break; > case 0x1000 ... 0x107f: /* OBIO interrupt control */ > if (addr & 4) { > val = s->obio_irq_map[(addr & 0xff) >> 3]; > - } else { > - val = 0; > } > break; > case 0x1080 ... 0x108f: /* PCI bus error */ > if (addr & 4) { > val = s->pci_err_irq_map[(addr & 0xf) >> 3]; > - } else { > - val = 0; > } > break; > case 0x2000 ... 0x202f: /* PCI control */ > @@ -229,8 +222,6 @@ static uint64_t sabre_config_read(void *opaque, > case 0xf020 ... 0xf027: /* Reset control */ > if (addr & 4) { > val = s->reset_control; > - } else { > - val = 0; > } > break; > case 0x5000 ... 0x51cf: /* PIO/DMA diagnostics */ > @@ -239,7 +230,6 @@ static uint64_t sabre_config_read(void *opaque, > case 0xf000 ... 0xf01f: /* FFB config, memory control */ > /* we don't care */ > default: > - val = 0; > break; > } > trace_sabre_config_read(addr, val); Reviewed-by: Mark Cave-Ayland ATB, Mark.