From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: "Volker Rümelin" <vr_qemu@t-online.de>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [PATCH v2 09/11] pckbd: add function kbd_pending()
Date: Fri, 7 May 2021 23:37:38 +0200 [thread overview]
Message-ID: <74960b21-5ce6-cf5d-1ebf-b8cd94ee7ce4@redhat.com> (raw)
In-Reply-To: <20210507180953.8530-9-vr_qemu@t-online.de>
On 5/7/21 8:09 PM, Volker Rümelin wrote:
> Replace reads of the variable s->pending with a call to a new
> function kbd_pending() to ease the review of the next patch.
> There is no functional change.
>
> Signed-off-by: Volker Rümelin <vr_qemu@t-online.de>
> ---
> hw/input/pckbd.c | 21 ++++++++++++++-------
> 1 file changed, 14 insertions(+), 7 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
next prev parent reply other threads:[~2021-05-07 21:38 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-07 18:08 [PATCH v2 00/11] PS/2 controller related fixes Volker Rümelin
2021-05-07 18:09 ` [PATCH v2 01/11] ps2: fix mouse stream corruption Volker Rümelin
2021-05-07 18:09 ` [PATCH v2 02/11] ps2: don't raise an interrupt if queue is full Volker Rümelin
2021-05-07 18:09 ` [PATCH v2 03/11] ps2: don't deassert irq twice if queue is empty Volker Rümelin
2021-05-07 18:09 ` [PATCH v2 04/11] pckbd: split out interrupt line changing code Volker Rümelin
2021-05-07 18:09 ` [PATCH v2 05/11] pckbd: don't update OBF flags if KBD_STAT_OBF is set Volker Rümelin
2021-05-07 18:09 ` [PATCH v2 06/11] pckbd: PS/2 keyboard throttle Volker Rümelin
2021-05-07 18:09 ` [PATCH v2 07/11] pckbd: add state variable for interrupt source Volker Rümelin
2021-05-07 18:09 ` [PATCH v2 08/11] pckbd: add controller response queue Volker Rümelin
2021-05-07 18:09 ` [PATCH v2 09/11] pckbd: add function kbd_pending() Volker Rümelin
2021-05-07 21:37 ` Philippe Mathieu-Daudé [this message]
2021-05-07 18:09 ` [PATCH v2 10/11] pckbd: correctly disable PS/2 communication Volker Rümelin
2021-05-07 18:09 ` [PATCH v2 11/11] pckbd: remove duplicated keyboard and mouse defines Volker Rümelin
2021-05-09 16:03 ` [PATCH v2 00/11] PS/2 controller related fixes Volker Rümelin
2021-05-10 20:41 ` Volker Rümelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=74960b21-5ce6-cf5d-1ebf-b8cd94ee7ce4@redhat.com \
--to=philmd@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=vr_qemu@t-online.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).