qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: BALATON Zoltan <balaton@eik.bme.hu>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
Cc: Peter Maydell <peter.maydell@linaro.org>,
	David Gibson <david@gibson.dropbear.id.au>,
	qemu-ppc@nongnu.org, qemu-devel@nongnu.org,
	Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH v6 4/8] vt82c686: Introduce abstract TYPE_VIA_ISA and base vt82c686b_isa on it
Date: Wed, 10 Mar 2021 03:36:29 +0100 (CET)	[thread overview]
Message-ID: <74b2b68c-dd5e-914a-597c-4121c91cdeda@eik.bme.hu> (raw)
In-Reply-To: <18602f6c-a1d1-bf02-26cf-c3f1cba52294@amsat.org>

[-- Attachment #1: Type: text/plain, Size: 1087 bytes --]

On Wed, 10 Mar 2021, Philippe Mathieu-Daudé wrote:
> On 3/9/21 9:28 PM, BALATON Zoltan wrote:
>> To allow reusing ISA bridge emulation for vt8231_isa move the device
>> state of vt82c686b_isa emulation in an abstract via_isa class. This
>> change breaks migration back compatibility but this is not an issue
>> for Fuloong2E machine which is not versioned or migration supported.
>>
>> Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
>> ---
>>  hw/isa/vt82c686.c        | 70 ++++++++++++++++++++++------------------
>>  include/hw/pci/pci_ids.h |  2 +-
>>  2 files changed, 40 insertions(+), 32 deletions(-)
>
> This should be OK if this other series is accepted:
> "hw/usb: Extract Extract VT82C686 UHCI PCI function into new unit"
> https://lists.gnu.org/archive/html/qemu-devel/2021-03/msg03083.html

How is this patch related to that series? This one changes the isa bridge 
part and that makes the usb part compiled only if configured. These seem 
unrelated and independent to me.

Regards,
BALATON Zoltan

> I'll come back to this patch after the former series is reviewed.
>
>

  reply	other threads:[~2021-03-10  2:37 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-09 20:28 [PATCH v6 0/8] Pegasos2 emulation BALATON Zoltan
2021-03-02  8:05 ` [PATCH v6 6/8] hw/isa/Kconfig: Add missing dependency VIA VT82C686 -> APM BALATON Zoltan
2021-04-12 18:31   ` Richard Henderson
2021-03-09 20:28 ` [PATCH v6 1/8] vt82c686: Implement control of serial port io ranges via config regs BALATON Zoltan
2021-03-09 20:28 ` [PATCH v6 5/8] vt82c686: Add emulation of VT8231 south bridge BALATON Zoltan
2021-03-09 20:28 ` [PATCH v6 3/8] vt82c686: Add VT8231_SUPERIO based on VIA_SUPERIO BALATON Zoltan
2021-03-09 20:28 ` [PATCH v6 4/8] vt82c686: Introduce abstract TYPE_VIA_ISA and base vt82c686b_isa on it BALATON Zoltan
2021-03-10  0:02   ` Philippe Mathieu-Daudé
2021-03-10  2:36     ` BALATON Zoltan [this message]
2021-03-09 20:28 ` [PATCH v6 2/8] vt82c686: QOM-ify superio related functionality BALATON Zoltan
2021-03-09 23:58   ` Philippe Mathieu-Daudé
2021-03-09 20:28 ` [PATCH v6 7/8] hw/pci-host: Add emulation of Marvell MV64361 PPC system controller BALATON Zoltan
2021-03-09 20:28 ` [PATCH v6 8/8] hw/ppc: Add emulation of Genesi/bPlan Pegasos II BALATON Zoltan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=74b2b68c-dd5e-914a-597c-4121c91cdeda@eik.bme.hu \
    --to=balaton@eik.bme.hu \
    --cc=david@gibson.dropbear.id.au \
    --cc=f4bug@amsat.org \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    --subject='Re: [PATCH v6 4/8] vt82c686: Introduce abstract TYPE_VIA_ISA and base vt82c686b_isa on it' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).