qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Richard Henderson <richard.henderson@linaro.org>
To: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>,
	qemu-devel@nongnu.org, rth@twiddle.net, jsnow@redhat.com
Subject: Re: [PATCH 1/2] dp264: use pci_create() to initialise the cmd646 device
Date: Sun, 16 Feb 2020 01:31:27 -0800	[thread overview]
Message-ID: <7594fea4-9447-50f0-85df-bd172cae7e9d@linaro.org> (raw)
In-Reply-To: <20200214084607.20471-2-mark.cave-ayland@ilande.co.uk>

On 2/14/20 12:46 AM, Mark Cave-Ayland wrote:
> Remove the call to pci_cmd646_ide_init() since global device init functions
> are deprecated in preference of using qdev directly.
> 
> Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
> ---
>  hw/alpha/dp264.c | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~


  parent reply	other threads:[~2020-02-16  9:32 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-14  8:46 [PATCH 0/2] cmd646: remove pci_cmd646_ide_init() function Mark Cave-Ayland
2020-02-14  8:46 ` [PATCH 1/2] dp264: use pci_create() to initialise the cmd646 device Mark Cave-Ayland
2020-02-14 11:47   ` Philippe Mathieu-Daudé
2020-02-14 19:16     ` Mark Cave-Ayland
2020-02-16  9:31   ` Richard Henderson [this message]
2020-02-14  8:46 ` [PATCH 2/2] cmd646: remove unused pci_cmd646_ide_init() function Mark Cave-Ayland
2020-02-16  9:31   ` Richard Henderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7594fea4-9447-50f0-85df-bd172cae7e9d@linaro.org \
    --to=richard.henderson@linaro.org \
    --cc=jsnow@redhat.com \
    --cc=mark.cave-ayland@ilande.co.uk \
    --cc=qemu-devel@nongnu.org \
    --cc=rth@twiddle.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).