From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96260C433B4 for ; Sun, 18 Apr 2021 20:35:13 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 29F1F60E0B for ; Sun, 18 Apr 2021 20:35:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 29F1F60E0B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:42234 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lYE8O-0000GC-8O for qemu-devel@archiver.kernel.org; Sun, 18 Apr 2021 16:35:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51858) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lYE7a-0008GR-IL for qemu-devel@nongnu.org; Sun, 18 Apr 2021 16:34:22 -0400 Received: from mail-qv1-xf2e.google.com ([2607:f8b0:4864:20::f2e]:46065) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lYE7Y-00019e-TE for qemu-devel@nongnu.org; Sun, 18 Apr 2021 16:34:22 -0400 Received: by mail-qv1-xf2e.google.com with SMTP id bs7so15476678qvb.12 for ; Sun, 18 Apr 2021 13:34:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=CXZR9VffY0Dio9xqXmZTOAS64VMxQWkgtZ1xpZEVU3M=; b=h0hIXedONJuQslUnSMTVp10C/C+vadpHpvGIcB+UiCQLI1U8xjKNWhZOqefVVbrSQv k2Lg8qb7mNQ3kM07Kr3bkpaEOkvVGxv1Aj7leOq77udumdI4wYzlh7wq1X/XFPOFEQ68 /v4OD87+lC3FdxQXuHbeh2lMrZp6Dee4Y+CkLxRF7/bZtMbXJDSwwf7PWF2yLGEF8WB0 D43pefFWCWFvOKZwj+zcFmqAabyF7a276B6hGvk9kWpf/ZOE3YN3FVYTPP9FsoN2x6ef dTnZT+eDBvtVPma/dOE0BEIlpkLB+FD+L4hfdnXVzGynVDbs+jeoria5jXYyajsgwj3V Rifg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=CXZR9VffY0Dio9xqXmZTOAS64VMxQWkgtZ1xpZEVU3M=; b=h0XLzNptUmfkqis8Ig1Yn+v1ml5UJyaTNZld2I41Frxg155+E7PzrPEbTMwIsrfYvt i/fZr8gwcmKotW2DWjslDe8gmw7QsHkQAEd3qAqcRODumSQ9oKWGe/cgMlcwMUZ19N26 XiSBzfMEdU8ivmFcBm1ey5smFx/woIuV24eIZ782lzXvOmhz8kwIEf4mk7ix3msM7s/g Be95r1eWFn0fAXfrbkSqx7s99d+k8tYL3yMK1zt8gJ3Dhu4Kh7nUGLz6pxAmMACN7eXY KIfwcYD7cQOPBAZNshtOU0abKIWTxQxZbnIhq6BXVwxMZEfdvMp9L2sX3hqo+CnkBtjc bFsg== X-Gm-Message-State: AOAM530DZ8AAuw4QQ9P4O1ND2nU56yQT5bUuQKJblckmkXveS5a8o8Bt IA0okl9FbkkdOHxN+C4FZYjgPg== X-Google-Smtp-Source: ABdhPJxAKsdJ/1MaF39u7cZe5zrZ4peE99aXxWSZmDL3Se+yjgsTgbZ4QMs97HSoEYpnHtftii0wXA== X-Received: by 2002:a0c:f802:: with SMTP id r2mr18592143qvn.50.1618778060061; Sun, 18 Apr 2021 13:34:20 -0700 (PDT) Received: from ?IPv6:2607:fb90:80c6:1fb0:d9de:a301:99b4:6cf3? ([2607:fb90:80c6:1fb0:d9de:a301:99b4:6cf3]) by smtp.gmail.com with ESMTPSA id q125sm8633377qke.11.2021.04.18.13.34.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 18 Apr 2021 13:34:19 -0700 (PDT) Subject: Re: [PATCH 23/26] target/mips: Move helper.h -> tcg/helper.h.inc To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , qemu-devel@nongnu.org References: <20210418163134.1133100-1-f4bug@amsat.org> <20210418163134.1133100-24-f4bug@amsat.org> From: Richard Henderson Message-ID: <760f0c29-e334-3cf8-2389-09b1aea3bb37@linaro.org> Date: Sun, 18 Apr 2021 13:34:14 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210418163134.1133100-24-f4bug@amsat.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2607:f8b0:4864:20::f2e; envelope-from=richard.henderson@linaro.org; helo=mail-qv1-xf2e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Aleksandar Rikalo , Huacai Chen , Aurelien Jarno Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 4/18/21 9:31 AM, Philippe Mathieu-Daudé wrote: > TCG frontend "exec/helper-head.h" expects each target to declare > its helpers in 'target/$TARGET/helper.h'. To ease maintenance we > rather to have all TCG specific files under our tcg/ sub directory. > > Move the current 'helper.h' there, and add a one-line 'helper.h' > which re-include it. > > Signed-off-by: Philippe Mathieu-Daudé > --- > target/mips/helper.h | 614 +---------------------------------- > target/mips/tcg/helper.h.inc | 613 ++++++++++++++++++++++++++++++++++ > 2 files changed, 614 insertions(+), 613 deletions(-) > create mode 100644 target/mips/tcg/helper.h.inc Eh. Ok, I guess. If we renamed the file tcg-helper.h{,.inc?} globally, would you still want it moved into your tcg/ subdirectory? r~