From: Jason Wang <jasowang@redhat.com>
To: Cindy Lu <lulu@redhat.com>, mst@redhat.com, qemu-devel@nongnu.org
Subject: Re: [PATCH v6 9/9] virtio-net: add peer_deleted check in virtio_net_handle_rx
Date: Tue, 27 Apr 2021 15:15:58 +0800 [thread overview]
Message-ID: <76309507-1092-d92f-17b2-a06d6c90ac7d@redhat.com> (raw)
In-Reply-To: <20210427033951.29805-10-lulu@redhat.com>
在 2021/4/27 上午11:39, Cindy Lu 写道:
> During the test, We found this fuction will continue running
> while the peer is deleted, this will case the crash. so add
> check for this.
Please describe how the issue is reproduced and why
qemu_flush_queued_packets() is not a better place to fix that.
Thanks
>
> Signed-off-by: Cindy Lu <lulu@redhat.com>
> ---
> hw/net/virtio-net.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c
> index 43b912453a..1be3f8e76f 100644
> --- a/hw/net/virtio-net.c
> +++ b/hw/net/virtio-net.c
> @@ -1403,7 +1403,9 @@ static void virtio_net_handle_rx(VirtIODevice *vdev, VirtQueue *vq)
> {
> VirtIONet *n = VIRTIO_NET(vdev);
> int queue_index = vq2q(virtio_get_queue_index(vq));
> -
> + if (n->nic->peer_deleted) {
> + return;
> + }
> qemu_flush_queued_packets(qemu_get_subqueue(n->nic, queue_index));
> }
>
next prev parent reply other threads:[~2021-04-27 7:18 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-27 3:39 [PATCH v6 0/9] vhost-vdpa: add support for configure interrupt Cindy Lu
2021-04-27 3:39 ` [PATCH v6 1/9] hw: Add check for queue number Cindy Lu
2021-04-27 5:39 ` Jason Wang
2021-04-29 3:08 ` Cindy Lu
2021-04-27 3:39 ` [PATCH v6 2/9] virtio-pci:decouple virtqueue from interrupt setting process Cindy Lu
2021-04-27 6:40 ` Jason Wang
2021-04-27 7:17 ` Jason Wang
2021-04-27 3:39 ` [PATCH v6 3/9] vhost: add new call back function for config interrupt Cindy Lu
2021-04-27 3:39 ` [PATCH v6 4/9] vhost-vdpa: add support for config interrupt call back Cindy Lu
2021-04-27 3:39 ` [PATCH v6 5/9] vhost:add support for configure interrupt Cindy Lu
2021-04-27 7:04 ` Jason Wang
2021-04-27 3:39 ` [PATCH v6 6/9] virtio-mmio: add " Cindy Lu
2021-04-27 3:39 ` [PATCH v6 7/9] virtio-pci: " Cindy Lu
2021-04-27 7:12 ` Jason Wang
2021-04-29 3:07 ` Cindy Lu
2021-04-27 3:39 ` [PATCH v6 8/9] virtio: decouple virtqueue from set notifier fd handler Cindy Lu
2021-04-27 7:14 ` Jason Wang
2021-04-27 3:39 ` [PATCH v6 9/9] virtio-net: add peer_deleted check in virtio_net_handle_rx Cindy Lu
2021-04-27 7:15 ` Jason Wang [this message]
2021-04-27 3:57 ` [PATCH v6 0/9] vhost-vdpa: add support for configure interrupt no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=76309507-1092-d92f-17b2-a06d6c90ac7d@redhat.com \
--to=jasowang@redhat.com \
--cc=lulu@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).