From: Max Reitz <mreitz@redhat.com>
To: Stefan Hajnoczi <stefanha@redhat.com>, qemu-devel@nongnu.org
Cc: "Kevin Wolf" <kwolf@redhat.com>,
"Daniel P. Berrangé" <berrange@redhat.com>,
qemu-block@nongnu.org
Subject: Re: [PATCH v3 3/4] qemu-img: allow qemu-img measure --object without a filename
Date: Wed, 19 Feb 2020 16:48:48 +0100 [thread overview]
Message-ID: <76fb1b01-50b3-3ff3-c0e0-f96d742bad1c@redhat.com> (raw)
In-Reply-To: <20200211160318.453650-4-stefanha@redhat.com>
[-- Attachment #1.1: Type: text/plain, Size: 681 bytes --]
On 11.02.20 17:03, Stefan Hajnoczi wrote:
> In most qemu-img sub-commands the --object option only makes sense when
> there is a filename. qemu-img measure is an exception because objects
> may be referenced from the image creation options instead of an existing
> image file. Allow --object without a filename.
>
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> ---
> qemu-img.c | 6 ++----
> tests/qemu-iotests/178 | 2 +-
> tests/qemu-iotests/178.out.qcow2 | 8 ++++----
> tests/qemu-iotests/178.out.raw | 8 ++++----
> 4 files changed, 11 insertions(+), 13 deletions(-)
Reviewed-by: Max Reitz <mreitz@redhat.com>
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-02-19 15:49 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-11 16:03 [PATCH v3 0/4] luks: add qemu-img measure support Stefan Hajnoczi
2020-02-11 16:03 ` [PATCH v3 1/4] luks: extract qcrypto_block_calculate_payload_offset() Stefan Hajnoczi
2020-02-19 13:03 ` Max Reitz
2020-02-21 11:17 ` Stefan Hajnoczi
2020-02-11 16:03 ` [PATCH v3 2/4] luks: implement .bdrv_measure() Stefan Hajnoczi
2020-02-19 15:46 ` Max Reitz
2020-02-21 11:18 ` Stefan Hajnoczi
2020-02-11 16:03 ` [PATCH v3 3/4] qemu-img: allow qemu-img measure --object without a filename Stefan Hajnoczi
2020-02-19 15:48 ` Max Reitz [this message]
2020-02-11 16:03 ` [PATCH v3 4/4] iotests: add 282 luks qemu-img measure test Stefan Hajnoczi
2020-02-19 15:52 ` Max Reitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=76fb1b01-50b3-3ff3-c0e0-f96d742bad1c@redhat.com \
--to=mreitz@redhat.com \
--cc=berrange@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).