From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 98CC3C433FF for ; Thu, 15 Aug 2019 01:57:48 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 675D4208C2 for ; Thu, 15 Aug 2019 01:57:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 675D4208C2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:37262 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1hy51P-0003mP-42 for qemu-devel@archiver.kernel.org; Wed, 14 Aug 2019 21:57:47 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44896) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1hy50j-0003MC-8L for qemu-devel@nongnu.org; Wed, 14 Aug 2019 21:57:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hy50h-0006Mn-Ii for qemu-devel@nongnu.org; Wed, 14 Aug 2019 21:57:04 -0400 Received: from mga14.intel.com ([192.55.52.115]:17601) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hy50h-0006Kn-AX for qemu-devel@nongnu.org; Wed, 14 Aug 2019 21:57:03 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 Aug 2019 18:56:59 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,387,1559545200"; d="scan'208";a="184491246" Received: from txu2-mobl.ccr.corp.intel.com (HELO [10.239.196.241]) ([10.239.196.241]) by FMSMGA003.fm.intel.com with ESMTP; 14 Aug 2019 18:56:58 -0700 To: Dan Williams References: <20190809065731.9097-1-tao3.xu@intel.com> <20190809065731.9097-6-tao3.xu@intel.com> <20190813170027.0617b129@redhat.com> From: Tao Xu Message-ID: <789df028-9dd9-884a-2493-aecc9a646e63@intel.com> Date: Thu, 15 Aug 2019 09:56:57 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 192.55.52.115 Subject: Re: [Qemu-devel] [PATCH v9 05/11] numa: Extend CLI to provide initiator information for numa nodes X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Eduardo Habkost , "Liu, Jingqi" , "Du, Fan" , Qemu Developers , "daniel@linux.ibm.com" , Jonathan Cameron , Igor Mammedov Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 8/15/2019 5:29 AM, Dan Williams wrote: > On Tue, Aug 13, 2019 at 10:14 PM Tao Xu wrote: >> >> On 8/14/2019 10:39 AM, Dan Williams wrote: >>> On Tue, Aug 13, 2019 at 8:00 AM Igor Mammedov wrote: >>>> >>>> On Fri, 9 Aug 2019 14:57:25 +0800 >>>> Tao wrote: >>>> >>>>> From: Tao Xu >>>>> [...] >>>>> + for (i = 0; i < machine->numa_state->num_nodes; i++) { >>>>> + if (numa_info[i].initiator_valid && >>>>> + !numa_info[numa_info[i].initiator].has_cpu) { >>>> ^^^^^^^^^^^^^^^^^^^^^^ possible out of bounds read, see bellow >>>> >>>>> + error_report("The initiator-id %"PRIu16 " of NUMA node %d" >>>>> + " does not exist.", numa_info[i].initiator, i); >>>>> + error_printf("\n"); >>>>> + >>>>> + exit(1); >>>>> + } >>>> it takes care only about nodes that have cpus or memory-only ones that have >>>> initiator explicitly provided on CLI. And leaves possibility to have >>>> memory-only nodes without initiator mixed with nodes that have initiator. >>>> Is it valid to have mixed configuration? >>>> Should we forbid it? >>> >>> The spec talks about the "Proximity Domain for the Attached Initiator" >>> field only being valid if the memory controller for the memory can be >>> identified by an initiator id in the SRAT. So I expect the only way to >>> define a memory proximity domain without this local initiator is to >>> allow specifying a node-id that does not have an entry in the SRAT. >>> >> Hi Dan, >> >> So there may be a situation for the Attached Initiator field is not >> valid? If true, I would allow user to input Initiator invalid. > > Yes it's something the OS needs to consider because the platform may > not be able to meet the constraint that a single initiator is > associated with the memory controller for a given memory target. In > retrospect it would have been nice if the spec reserved 0xffffffff for > this purpose, but it seems "not in SRAT" is the only way to identify > memory that is not attached to any single initiator. > But As far as I konw, QEMU can't emulate a NUMA node "not in SRAT". I am wondering if it is effective only set Initiator invalid?