From: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
To: Richard Henderson <richard.henderson@linaro.org>, qemu-devel@nongnu.org
Cc: edgar.iglesias@xilinx.com
Subject: Re: [PATCH v3 12/19] target/microblaze: Split out MicroBlazeCPUConfig
Date: Sat, 5 Sep 2020 23:35:28 +0200 [thread overview]
Message-ID: <78a05885-0456-76d4-18e7-397675f641f8@amsat.org> (raw)
In-Reply-To: <20200904190842.2282109-13-richard.henderson@linaro.org>
On 9/4/20 9:08 PM, Richard Henderson wrote:
> This struct was previously unnamed, and defined in MicroBlazeCPU.
> Pull it out to its own typedef so that we can reuse it.
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> target/microblaze/cpu.h | 55 ++++++++++++++++++++++-------------------
> 1 file changed, 29 insertions(+), 26 deletions(-)
>
> diff --git a/target/microblaze/cpu.h b/target/microblaze/cpu.h
> index 20c2979396..59d2a079c4 100644
> --- a/target/microblaze/cpu.h
> +++ b/target/microblaze/cpu.h
> @@ -291,6 +291,34 @@ struct CPUMBState {
> } pvr;
> };
>
> +/*
> + * Microblaze Configuration Settings
> + */
> +typedef struct {
> + bool stackprot;
> + uint32_t base_vectors;
> + uint8_t addr_size;
> + uint8_t use_fpu;
> + uint8_t use_hw_mul;
> + bool use_barrel;
> + bool use_div;
> + bool use_msr_instr;
> + bool use_pcmp_instr;
> + bool use_mmu;
> + bool dcache_writeback;
> + bool endi;
> + bool dopb_bus_exception;
> + bool iopb_bus_exception;
> + bool illegal_opcode_exception;
> + bool opcode_0_illegal;
> + bool div_zero_exception;
> + bool unaligned_exceptions;
> + uint8_t pvr_user1;
> + uint32_t pvr_user2;
> + char *version;
> + uint8_t pvr;
> +} MicroBlazeCPUConfig;
> +
> /**
> * MicroBlazeCPU:
> * @env: #CPUMBState
> @@ -305,32 +333,7 @@ struct MicroBlazeCPU {
>
> CPUNegativeOffsetState neg;
> CPUMBState env;
> -
> - /* Microblaze Configuration Settings */
> - struct {
> - bool stackprot;
> - uint32_t base_vectors;
> - uint8_t addr_size;
> - uint8_t use_fpu;
> - uint8_t use_hw_mul;
> - bool use_barrel;
> - bool use_div;
> - bool use_msr_instr;
> - bool use_pcmp_instr;
> - bool use_mmu;
> - bool dcache_writeback;
> - bool endi;
> - bool dopb_bus_exception;
> - bool iopb_bus_exception;
> - bool illegal_opcode_exception;
> - bool opcode_0_illegal;
> - bool div_zero_exception;
> - bool unaligned_exceptions;
> - uint8_t pvr_user1;
> - uint32_t pvr_user2;
> - char *version;
> - uint8_t pvr;
> - } cfg;
> + MicroBlazeCPUConfig cfg;
> };
>
>
>
next prev parent reply other threads:[~2020-09-05 21:36 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-04 19:08 [PATCH v3 00/19] target/microblaze improvements Richard Henderson
2020-09-04 19:08 ` [PATCH v3 01/19] target/microblaze: Collected fixes for env->iflags Richard Henderson
2020-09-04 19:08 ` [PATCH v3 02/19] target/microblaze: Renumber D_FLAG Richard Henderson
2020-09-04 19:08 ` [PATCH v3 03/19] target/microblaze: Cleanup mb_cpu_do_interrupt Richard Henderson
2020-09-04 19:08 ` [PATCH v3 04/19] target/microblaze: Rename mmu structs Richard Henderson
2020-09-04 19:08 ` [PATCH v3 05/19] target/microblaze: Rename DISAS_UPDATE to DISAS_EXIT Richard Henderson
2020-09-04 19:08 ` [PATCH v3 06/19] target/microblaze: Introduce DISAS_EXIT_NEXT, DISAS_EXIT_JUMP Richard Henderson
2020-09-04 19:08 ` [PATCH v3 07/19] target/microblaze: Replace cpustate_changed with DISAS_EXIT_NEXT Richard Henderson
2020-09-04 19:08 ` [PATCH v3 08/19] target/microblaze: Handle DISAS_EXIT_NEXT in delay slot Richard Henderson
2020-09-04 19:08 ` [PATCH v3 09/19] target/microblaze: Force rtid, rted, rtbd to exit Richard Henderson
2020-09-04 19:08 ` [PATCH v3 10/19] target/microblaze: Use tcg_gen_lookup_and_goto_ptr Richard Henderson
2020-09-04 19:08 ` [PATCH v3 11/19] target/microblaze: Diagnose invalid insns in delay slots Richard Henderson
2020-09-04 19:08 ` [PATCH v3 12/19] target/microblaze: Split out MicroBlazeCPUConfig Richard Henderson
2020-09-05 21:35 ` Philippe Mathieu-Daudé [this message]
2020-09-04 19:08 ` [PATCH v3 13/19] target/microblaze: Reorg MicroBlazeCPUConfig to minimize holes Richard Henderson
2020-09-05 21:36 ` Philippe Mathieu-Daudé
2020-09-04 19:08 ` [PATCH v3 14/19] target/microblaze: Move pvr regs to MicroBlazeCPUConfig Richard Henderson
2020-09-05 21:39 ` Philippe Mathieu-Daudé
2020-09-04 19:08 ` [PATCH v3 15/19] target/microblaze: Treat pvr_regs as constant Richard Henderson
2020-09-04 19:08 ` [PATCH v3 16/19] target/microblaze: Move mmu parameters to MicroBlazeCPUConfig Richard Henderson
2020-09-05 21:41 ` Philippe Mathieu-Daudé
2020-09-04 19:08 ` [PATCH v3 17/19] target/microblaze: Fill in VMStateDescription for cpu Richard Henderson
2020-09-04 19:08 ` [PATCH v3 18/19] target/microblaze: Put MicroBlazeCPUConfig into DisasContext Richard Henderson
2020-09-05 21:42 ` Philippe Mathieu-Daudé
2020-09-04 19:08 ` [PATCH v3 19/19] configure: Do not set TARGET_ABI32 for microblaze Richard Henderson
2020-09-07 9:20 ` [PATCH v3 00/19] target/microblaze improvements Edgar E. Iglesias
2020-09-07 17:43 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=78a05885-0456-76d4-18e7-397675f641f8@amsat.org \
--to=f4bug@amsat.org \
--cc=edgar.iglesias@xilinx.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).