From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41713CA9EB5 for ; Mon, 4 Nov 2019 12:58:41 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1049C20B7C for ; Mon, 4 Nov 2019 12:58:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="PwcuMuQ3" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1049C20B7C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:60370 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iRbwO-0001gF-4p for qemu-devel@archiver.kernel.org; Mon, 04 Nov 2019 07:58:40 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:46258) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iRbvg-00018S-KU for qemu-devel@nongnu.org; Mon, 04 Nov 2019 07:57:57 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iRbvd-00039n-Mw for qemu-devel@nongnu.org; Mon, 04 Nov 2019 07:57:54 -0500 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:34445 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iRbvd-00039Z-Dd for qemu-devel@nongnu.org; Mon, 04 Nov 2019 07:57:53 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1572872273; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=ljw9TmoLooLFp7Gn3uc2bcGHtQ85/XmqP4bLHEZJukI=; b=PwcuMuQ37u/StoLsY4FE1muQhHOJLkXDCnsF0UXjEPGCTVYn20WmLnWMFSpsc95G7bEVP1 TnxxJdNf4p1LHBD+xp3RoDl0EcWg/YwD+Rx4f5bqGS1qk7//T4cl15C36Q+3Qh1+kXEoGj KrHP/m34GNhIfTNSWc+GIM2vVoR2+EY= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-248-jHqrdDNyM4-wZ2hZHLzJeQ-1; Mon, 04 Nov 2019 07:57:48 -0500 X-MC-Unique: jHqrdDNyM4-wZ2hZHLzJeQ-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C3504107ACC2; Mon, 4 Nov 2019 12:57:45 +0000 (UTC) Received: from dresden.str.redhat.com (unknown [10.36.118.44]) by smtp.corp.redhat.com (Postfix) with ESMTPS id EE42F60F8A; Mon, 4 Nov 2019 12:57:43 +0000 (UTC) Subject: Re: [RFC PATCH v2 12/26] qcow2: Handle QCOW2_CLUSTER_UNALLOCATED_SUBCLUSTER To: Alberto Garcia , qemu-devel@nongnu.org References: <2a6b34635cac78e76150a72c69669b3d9ec0fb8c.1572125022.git.berto@igalia.com> From: Max Reitz Autocrypt: addr=mreitz@redhat.com; prefer-encrypt=mutual; keydata= mQENBFXOJlcBCADEyyhOTsoa/2ujoTRAJj4MKA21dkxxELVj3cuILpLTmtachWj7QW+TVG8U /PsMCFbpwsQR7oEy8eHHZwuGQsNpEtNC2G/L8Yka0BIBzv7dEgrPzIu+W3anZXQW4702+uES U29G8TP/NGfXRRHGlbBIH9KNUnOSUD2vRtpOLXkWsV5CN6vQFYgQfFvmp5ZpPeUe6xNplu8V mcTw8OSEDW/ZnxJc8TekCKZSpdzYoxfzjm7xGmZqB18VFwgJZlIibt1HE0EB4w5GsD7x5ekh awIe3RwoZgZDLQMdOitJ1tUc8aqaxvgA4tz6J6st8D8pS//m1gAoYJWGwwIVj1DjTYLtABEB AAG0HU1heCBSZWl0eiA8bXJlaXR6QHJlZGhhdC5jb20+iQFTBBMBCAA9AhsDBQkSzAMABQsJ CAcCBhUICQoLAgQWAgMBAh4BAheABQJVzie5FRhoa3A6Ly9rZXlzLmdudXBnLm5ldAAKCRD0 B9sAYdXPQDcIB/9uNkbYEex1rHKz3mr12uxYMwLOOFY9fstP5aoVJQ1nWQVB6m2cfKGdcRe1 2/nFaHSNAzT0NnKz2MjhZVmcrpyd2Gp2QyISCfb1FbT82GMtXFj1wiHmPb3CixYmWGQUUh+I AvUqsevLA+WihgBUyaJq/vuDVM1/K9Un+w+Tz5vpeMidlIsTYhcsMhn0L9wlCjoucljvbDy/ 8C9L2DUdgi3XTa0ORKeflUhdL4gucWoAMrKX2nmPjBMKLgU7WLBc8AtV+84b9OWFML6NEyo4 4cP7cM/07VlJK53pqNg5cHtnWwjHcbpGkQvx6RUx6F1My3y52vM24rNUA3+ligVEgPYBuQEN BFXOJlcBCADAmcVUNTWT6yLWQHvxZ0o47KCP8OcLqD+67T0RCe6d0LP8GsWtrJdeDIQk+T+F xO7DolQPS6iQ6Ak2/lJaPX8L0BkEAiMuLCKFU6Bn3lFOkrQeKp3u05wCSV1iKnhg0UPji9V2 W5eNfy8F4ZQHpeGUGy+liGXlxqkeRVhLyevUqfU0WgNqAJpfhHSGpBgihUupmyUg7lfUPeRM DzAN1pIqoFuxnN+BRHdAecpsLcbR8sQddXmDg9BpSKozO/JyBmaS1RlquI8HERQoe6EynJhd 64aICHDfj61rp+/0jTIcevxIIAzW70IadoS/y3DVIkuhncgDBvGbF3aBtjrJVP+5ABEBAAGJ ASUEGAEIAA8FAlXOJlcCGwwFCRLMAwAACgkQ9AfbAGHVz0CbFwf9F/PXxQR9i4N0iipISYjU sxVdjJOM2TMut+ZZcQ6NSMvhZ0ogQxJ+iEQ5OjnIputKvPVd5U7WRh+4lF1lB/NQGrGZQ1ic alkj6ocscQyFwfib+xIe9w8TG1CVGkII7+TbS5pXHRxZH1niaRpoi/hYtgzkuOPp35jJyqT/ /ELbqQTDAWcqtJhzxKLE/ugcOMK520dJDeb6x2xVES+S5LXby0D4juZlvUj+1fwZu+7Io5+B bkhSVPb/QdOVTpnz7zWNyNw+OONo1aBUKkhq2UIByYXgORPFnbfMY7QWHcjpBVw9MgC4tGeF R4bv+1nAMMxKmb5VvQCExr0eFhJUAHAhVg== Message-ID: <78cc16f3-f8aa-9dcb-2389-4f6ed86080fd@redhat.com> Date: Mon, 4 Nov 2019 13:57:42 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1 MIME-Version: 1.0 In-Reply-To: <2a6b34635cac78e76150a72c69669b3d9ec0fb8c.1572125022.git.berto@igalia.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Mimecast-Spam-Score: 0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Zv9q3uo0GclW18wp4FQk5RSEMRFjHP1uJ" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 205.139.110.120 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Anton Nefedov , qemu-block@nongnu.org, Vladimir Sementsov-Ogievskiy , "Denis V . Lunev" Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --Zv9q3uo0GclW18wp4FQk5RSEMRFjHP1uJ Content-Type: multipart/mixed; boundary="UYFvPwCpwdoPOQQd8BQkmw946cjMAwdJ5" --UYFvPwCpwdoPOQQd8BQkmw946cjMAwdJ5 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 26.10.19 23:25, Alberto Garcia wrote: > In the previous patch we added a new QCow2ClusterType named > QCOW2_CLUSTER_UNALLOCATED_SUBCLUSTER. There is a couple of places > where this new value needs to be handled, and that is what this patch > does. >=20 > Signed-off-by: Alberto Garcia > --- > block/qcow2.c | 13 +++++++++---- > 1 file changed, 9 insertions(+), 4 deletions(-) This patch deals with everything in qcow2.c. There are more places that reference QCOW2_CLUSTER_* constants elsewhere, and I suppose most of them are handled by the following patches. But I wonder what the criterion is on where it needs to be handled and where it=E2=80=99s OK not to. Right now it looks to me like it=E2=80=99s a= bit arbitrary maybe? But I suppose I=E2=80=99ll just have to wait until after = the next patches. Max --UYFvPwCpwdoPOQQd8BQkmw946cjMAwdJ5-- --Zv9q3uo0GclW18wp4FQk5RSEMRFjHP1uJ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEkb62CjDbPohX0Rgp9AfbAGHVz0AFAl3AIEYACgkQ9AfbAGHV z0DjDQf7BTtKrArJ7NLrcE5Rwe5eOBOb+i1ohWuxdD1bYLe7QvU0YVdvDYywnxkp 9zR2mZ/34szVkFFi6Vf78PrW9eFN97VPF/DxiwaK0dgygmQYn2W5g+vOvqwIBXCz p68uZJGnbrEMFSieORfF7tgPOPRggBm1c6964ZQ77CwrWLJDJ0q7I7puttX2z8VY aKOUDj4VoqBR6F2LW8jdlRP6VlbvxmNCil4vsXWZgNrQifOG4LFD5v1RCPBfyVS/ PokbM9sqlwmQcQwwZkEvzoVYd9FLacfyYGYgmx8gFsvTnqGRccXMI3xEu7oRS0sW F+FBV0cjNqF0ikq2ay/3HNX3pB9B4w== =qRk0 -----END PGP SIGNATURE----- --Zv9q3uo0GclW18wp4FQk5RSEMRFjHP1uJ--