From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.9 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B4E75C433EF for ; Wed, 15 Sep 2021 08:17:17 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 53E4A61166 for ; Wed, 15 Sep 2021 08:17:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 53E4A61166 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ilande.co.uk Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:54908 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mQQ6W-0002w0-6U for qemu-devel@archiver.kernel.org; Wed, 15 Sep 2021 04:17:16 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38730) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mQQ5S-0000Il-Az for qemu-devel@nongnu.org; Wed, 15 Sep 2021 04:16:10 -0400 Received: from mail.ilande.co.uk ([2001:41c9:1:41f::167]:38854 helo=mail.default.ilande.bv.iomart.io) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mQQ5Q-00069X-6w for qemu-devel@nongnu.org; Wed, 15 Sep 2021 04:16:09 -0400 Received: from host109-153-76-56.range109-153.btcentralplus.com ([109.153.76.56] helo=[192.168.50.176]) by mail.default.ilande.bv.iomart.io with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1mQQ5G-0004Id-4F; Wed, 15 Sep 2021 09:16:02 +0100 From: Mark Cave-Ayland To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , qemu-devel@nongnu.org, laurent@vivier.eu References: <20210912074914.22048-1-mark.cave-ayland@ilande.co.uk> <20210912074914.22048-12-mark.cave-ayland@ilande.co.uk> <72dd46cf-2d9c-228c-05c7-e4f5d03df191@ilande.co.uk> Message-ID: <7965292b-75d9-35b1-2518-04a3b10b0412@ilande.co.uk> Date: Wed, 15 Sep 2021 09:16:00 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: <72dd46cf-2d9c-228c-05c7-e4f5d03df191@ilande.co.uk> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: 109.153.76.56 X-SA-Exim-Mail-From: mark.cave-ayland@ilande.co.uk Subject: Re: [PATCH 11/20] nubus-device: add romfile property for loading declaration ROMs X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on mail.default.ilande.bv.iomart.io) Received-SPF: pass client-ip=2001:41c9:1:41f::167; envelope-from=mark.cave-ayland@ilande.co.uk; helo=mail.default.ilande.bv.iomart.io X-Spam_score_int: -38 X-Spam_score: -3.9 X-Spam_bar: --- X-Spam_report: (-3.9 / 5.0 requ) BAYES_00=-1.9, NICE_REPLY_A=-1.969, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 14/09/2021 21:23, Mark Cave-Ayland wrote: > On 12/09/2021 18:39, Philippe Mathieu-Daudé wrote: > >> On 9/12/21 9:49 AM, Mark Cave-Ayland wrote: >>> The declaration ROM is located at the top-most address of the standard slot >>> space. >>> >>> Signed-off-by: Mark Cave-Ayland >>> --- >>>   hw/nubus/nubus-device.c  | 43 +++++++++++++++++++++++++++++++++++++++- >>>   include/hw/nubus/nubus.h |  5 +++++ >>>   2 files changed, 47 insertions(+), 1 deletion(-) >> >>> +    /* Declaration ROM */ >> >>> +        } else if (size > NUBUS_DECL_ROM_MAX_SIZE) { >> >> I'd check for >= and define as (64 * KiB). > > That's a good idea - I'll update this for the v2. And in fact it looks like it is possible to embed multi-function MacOS drivers in the declaration ROM so I'll keep the > and increase the maximum size to 128K which should give plenty of breathing space for binary drivers. >>> +            error_setg(errp, "romfile \"%s\" too large (maximum size 64K)", >>> +                       nd->romfile); >>> +            g_free(path); >>> +            return; >>> +        } >> >>> diff --git a/include/hw/nubus/nubus.h b/include/hw/nubus/nubus.h >>> index 87a97516c7..42f4c9dbb8 100644 >>> --- a/include/hw/nubus/nubus.h >>> +++ b/include/hw/nubus/nubus.h >>> @@ -39,12 +39,17 @@ struct NubusBus { >>>       uint32_t slot_available_mask; >>>   }; >>> +#define NUBUS_DECL_ROM_MAX_SIZE    0xffff ATB, Mark.