From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE4ACC2D0A3 for ; Mon, 9 Nov 2020 10:17:48 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4358C20684 for ; Mon, 9 Nov 2020 10:17:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="FpN2CfgT" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4358C20684 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:42450 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kc4F7-0002zM-0K for qemu-devel@archiver.kernel.org; Mon, 09 Nov 2020 05:17:45 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:38866) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kc4E8-0002JA-9H for qemu-devel@nongnu.org; Mon, 09 Nov 2020 05:16:44 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:43292) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kc4E6-0005UT-In for qemu-devel@nongnu.org; Mon, 09 Nov 2020 05:16:43 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1604917001; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rYn1j7IAbTHYnx+J3mdvUo2hqlsEqhVRsJxMOrrUJOw=; b=FpN2CfgTIy1fIJExoe/w6OfFKYVCgVpsaEO8jl16lJq1LOdvB+8A0lJY1UeeHbRWHji7T5 V4o74wHIHjtA4zgGQlcfpBZlbsQmhJ7aQyEbDquLXFSz5JyoDS3HQiqCwODWS98Ur6kFdJ grpLOo5ja2QSIFjwZExfCi1XfmkGfig= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-448-Fg9_Qx6pPZqIJjNyZqELOA-1; Mon, 09 Nov 2020 05:16:37 -0500 X-MC-Unique: Fg9_Qx6pPZqIJjNyZqELOA-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 7D615185A0F0; Mon, 9 Nov 2020 10:16:36 +0000 (UTC) Received: from thuth.remote.csb (ovpn-112-53.ams2.redhat.com [10.36.112.53]) by smtp.corp.redhat.com (Postfix) with ESMTP id 640995C22B; Mon, 9 Nov 2020 10:16:24 +0000 (UTC) Subject: Re: [PATCH-for-6.0 v4 06/17] gitlab-ci: Update 'build-disabled' to cover all configurable options To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , qemu-devel@nongnu.org References: <20201108204535.2319870-1-philmd@redhat.com> <20201108204535.2319870-7-philmd@redhat.com> From: Thomas Huth Message-ID: <79eedc40-e921-e806-f63a-60e4874797bf@redhat.com> Date: Mon, 9 Nov 2020 11:16:23 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: <20201108204535.2319870-7-philmd@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=thuth@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=63.128.21.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/11/09 01:25:23 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=-1, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fam Zheng , Aleksandar Rikalo , "Daniel P . Berrange" , Eduardo Habkost , "Michael S. Tsirkin" , Wainer dos Santos Moschetta , Igor Mammedov , Paolo Bonzini , =?UTF-8?Q?Alex_Benn=c3=a9e?= , Aurelien Jarno , Richard Henderson Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 08/11/2020 21.45, Philippe Mathieu-Daudé wrote: > Add these missing options to the 'build-disabled' job: > --disable-auth-pam (commit 8953caf3cd38) > --disable-gcrypt (commit 91bfcdb01d48) > --disable-keyring (commit 54e7aac05624) > --disable-libudev (commit 5c53015a480b) > --disable-opengl (commit da076ffed6b9) > --disable-sparse (commit 03b4fe7de226) > > Signed-off-by: Philippe Mathieu-Daudé > --- > .gitlab-ci.yml | 7 +++++++ > 1 file changed, 7 insertions(+) [...] > @@ -258,6 +264,7 @@ build-disabled: > --disable-vhost-net > --disable-vhost-scsi > --disable-vhost-user > + --disable-vhost-user-blk-server > --disable-vhost-vdpa > --disable-vhost-vsock > --disable-virglrenderer vhost-user-blk-server should get automatically disabled by --disable-vhost-user ... so maybe drop this hunk, so that we're able to detect problems with this logic in the future, too? (as we've just seen with the current build failures in the CI) ... if you insist on keeping this hunk, I think you should at least mention it in the patch description (since you've mentioned all the other options there) Thomas