From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD698C433B4 for ; Sat, 3 Apr 2021 14:39:33 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 34E5261263 for ; Sat, 3 Apr 2021 14:39:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 34E5261263 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ilande.co.uk Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:59670 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lShQy-00035w-0A for qemu-devel@archiver.kernel.org; Sat, 03 Apr 2021 10:39:32 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53288) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lShQP-0002hD-IH for qemu-devel@nongnu.org; Sat, 03 Apr 2021 10:38:57 -0400 Received: from mail.ilande.co.uk ([2001:41c9:1:41f::167]:60210 helo=mail.default.ilande.uk0.bigv.io) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lShQN-0000S0-QE for qemu-devel@nongnu.org; Sat, 03 Apr 2021 10:38:57 -0400 Received: from host86-148-103-9.range86-148.btcentralplus.com ([86.148.103.9] helo=[192.168.1.65]) by mail.default.ilande.uk0.bigv.io with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1lShQK-0001nk-6P; Sat, 03 Apr 2021 15:38:57 +0100 To: Alexander Bulekov , qemu-devel@nongnu.org References: <20210402162052.264952-1-alxndr@bu.edu> From: Mark Cave-Ayland Message-ID: <7bb5adaa-a7aa-8418-7819-e5421bfbae32@ilande.co.uk> Date: Sat, 3 Apr 2021 15:38:36 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: <20210402162052.264952-1-alxndr@bu.edu> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: 86.148.103.9 X-SA-Exim-Mail-From: mark.cave-ayland@ilande.co.uk Subject: Re: [PATCH] tests/qtest: add one more test for the am53c974 X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on mail.default.ilande.uk0.bigv.io) Received-SPF: pass client-ip=2001:41c9:1:41f::167; envelope-from=mark.cave-ayland@ilande.co.uk; helo=mail.default.ilande.uk0.bigv.io X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, NICE_REPLY_A=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fam Zheng , Laurent Vivier , Thomas Huth , Paolo Bonzini Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 02/04/2021 17:20, Alexander Bulekov wrote: > Original crash: > qemu-fuzz-i386: ../hw/scsi/esp.c:791: void esp_transfer_data(SCSIRequest *, uint32_t): Assertion `!s->do_cmd' failed. > ==257532== ERROR: libFuzzer: deadly signal > __assert_fail assert/assert.c:101:3 > esp_transfer_data hw/scsi/esp.c:791:5 > scsi_req_data hw/scsi/scsi-bus.c:1412:9 > scsi_disk_emulate_read_data hw/scsi/scsi-disk.c:1407:9 > scsi_req_continue hw/scsi/scsi-bus.c:1394:9 > do_busid_cmd hw/scsi/esp.c:317:9 > handle_s_without_atn hw/scsi/esp.c:393:9 > esp_reg_write hw/scsi/esp.c:1029:13 > esp_pci_io_write hw/scsi/esp-pci.c:215:9 > memory_region_write_accessor softmmu/memory.c:491:5 > access_with_adjusted_size softmmu/memory.c:552:18 > memory_region_dispatch_write softmmu/memory.c:1502:16 > flatview_write_continue softmmu/physmem.c:2746:23 > flatview_write softmmu/physmem.c:2786:14 > address_space_write softmmu/physmem.c:2878:18 > cpu_outl softmmu/ioport.c:80:5 > > Based-on: <20210401074933.9923-1-mark.cave-ayland@ilande.co.uk> > Signed-off-by: Alexander Bulekov > --- > tests/qtest/am53c974-test.c | 18 ++++++++++++++++++ > 1 file changed, 18 insertions(+) > > The patch took care of the handle_satn_stop assert. Here's a test case > for the other assert. Great! I've squashed the get_cmd() changes into a v4 version of the patchset. > Pasteable: > > cat << EOF | ./qemu-system-i386 -display none -machine accel=qtest, -m \ > 512M -device am53c974,id=scsi -device scsi-hd,drive=disk0 -drive \ > id=disk0,if=none,file=null-co://,format=raw -nodefaults -qtest stdio > outl 0xcf8 0x80001010 > outl 0xcfc 0xc000 > outl 0xcf8 0x80001004 > outw 0xcfc 0x01 > outl 0xc00b 0x4100 > outb 0xc008 0x42 > outw 0xc03f 0x0300 > outl 0xc00b 0xc100 > EOF > > > diff --git a/tests/qtest/am53c974-test.c b/tests/qtest/am53c974-test.c > index 9c4285d0c0..506276677a 100644 > --- a/tests/qtest/am53c974-test.c > +++ b/tests/qtest/am53c974-test.c > @@ -9,6 +9,22 @@ > > #include "libqos/libqtest.h" > > +static void test_do_cmd_assert(void) > +{ > + QTestState *s = qtest_init( > + "-device am53c974,id=scsi " > + "-device scsi-hd,drive=disk0 -drive " > + "id=disk0,if=none,file=null-co://,format=raw -nodefaults"); > + qtest_outl(s, 0xcf8, 0x80001010); > + qtest_outl(s, 0xcfc, 0xc000); > + qtest_outl(s, 0xcf8, 0x80001004); > + qtest_outw(s, 0xcfc, 0x01); > + qtest_outl(s, 0xc00b, 0x4100); > + qtest_outb(s, 0xc008, 0x42); > + qtest_outw(s, 0xc03f, 0x0300); > + qtest_outl(s, 0xc00b, 0xc100); > + qtest_quit(s); > +} > > static void test_cmdfifo_underflow_ok(void) > { > @@ -194,6 +210,8 @@ int main(int argc, char **argv) > g_test_init(&argc, &argv, NULL); > > if (strcmp(arch, "i386") == 0) { > + qtest_add_func("am53c974/test_do_cmd_asser", > + test_do_cmd_assert); > qtest_add_func("am53c974/test_cmdfifo_underflow_ok", > test_cmdfifo_underflow_ok); > qtest_add_func("am53c974/test_cmdfifo_underflow2_ok", When I try this patch on top of the v4 patchset I don't get an assert() in esp_transfer_data here? ATB, Mark.