From: Eric Blake <eblake@redhat.com>
To: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>,
qemu-block@nongnu.org
Cc: kwolf@redhat.com, fam@euphon.net, ehabkost@redhat.com,
qemu-devel@nongnu.org, mreitz@redhat.com, stefanha@redhat.com,
crosa@redhat.com, den@openvz.org
Subject: Re: [PATCH v3 2/3] block: declare some coroutine functions in block/coroutines.h
Date: Fri, 22 May 2020 16:35:28 -0500 [thread overview]
Message-ID: <7ca2350f-b773-2d39-ffbe-88d84212fc91@redhat.com> (raw)
In-Reply-To: <20200522161950.2839-3-vsementsov@virtuozzo.com>
On 5/22/20 11:19 AM, Vladimir Sementsov-Ogievskiy wrote:
> We are going to keep coroutine-wrappers code (structure-packing
> parameters, BDRV_POLL wrapper functions) in a separate auto-generated
> files. So, we'll need a header with declaration of original _co_
> functions, for those which are static now. As well, we'll need
> declarations for wrapper functions. Do these declarations now, as a
> preparation step.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
> ---
> block/coroutines.h | 43 +++++++++++++++++++++++++++++++++++++++++++
> block.c | 8 ++++----
> block/io.c | 34 +++++++++++++++++-----------------
> 3 files changed, 64 insertions(+), 21 deletions(-)
> create mode 100644 block/coroutines.h
>
> diff --git a/block/coroutines.h b/block/coroutines.h
> new file mode 100644
> index 0000000000..23ea6fd5b3
> --- /dev/null
> +++ b/block/coroutines.h
> @@ -0,0 +1,43 @@
> +#ifndef BLOCK_COROUTINES_INT_H
> +#define BLOCK_COROUTINES_INT_H
Should have a copyright header.
Otherwise makes sense.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
next prev parent reply other threads:[~2020-05-22 21:36 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-22 16:19 [PATCH v3 0/3] coroutines: generate wrapper code Vladimir Sementsov-Ogievskiy
2020-05-22 16:19 ` [PATCH v3 1/3] block/io: refactor coroutine wrappers Vladimir Sementsov-Ogievskiy
2020-05-22 21:33 ` Eric Blake
2020-05-22 22:48 ` Vladimir Sementsov-Ogievskiy
2020-05-22 16:19 ` [PATCH v3 2/3] block: declare some coroutine functions in block/coroutines.h Vladimir Sementsov-Ogievskiy
2020-05-22 21:35 ` Eric Blake [this message]
2020-05-22 16:19 ` [PATCH v3 3/3] block: generate coroutine-wrapper code Vladimir Sementsov-Ogievskiy
2020-05-22 21:18 ` [PATCH v3 0/3] coroutines: generate wrapper code no-reply
2020-05-22 21:23 ` no-reply
2020-05-22 21:29 ` no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7ca2350f-b773-2d39-ffbe-88d84212fc91@redhat.com \
--to=eblake@redhat.com \
--cc=crosa@redhat.com \
--cc=den@openvz.org \
--cc=ehabkost@redhat.com \
--cc=fam@euphon.net \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).