From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08BBEC432BE for ; Tue, 31 Aug 2021 02:31:37 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5512A60FD8 for ; Tue, 31 Aug 2021 02:31:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 5512A60FD8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:35768 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mKtYl-0008FL-3w for qemu-devel@archiver.kernel.org; Mon, 30 Aug 2021 22:31:35 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46360) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mKtXh-0007Mw-IT for qemu-devel@nongnu.org; Mon, 30 Aug 2021 22:30:31 -0400 Received: from mail-pj1-x102d.google.com ([2607:f8b0:4864:20::102d]:52877) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mKtXc-00029o-6F for qemu-devel@nongnu.org; Mon, 30 Aug 2021 22:30:25 -0400 Received: by mail-pj1-x102d.google.com with SMTP id d5so4999091pjx.2 for ; Mon, 30 Aug 2021 19:30:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=+a7/rxWEoFpRCgIH6mG5XywX4d6JvReTMXdaGMtp4Sg=; b=YyByOtG4p3cauVErNTMYDljlD2e5TPi/7Cj8JU0KBdmsVyzUE5wSUwodNr9JUj5WD0 VOkozjkVFeCio08hgL2Avg7s2ytzSt+CuDgF54Qxrm0RL5YAlW8Os7ViO/zjRln4AgXN fVKua2rhYxuhtv1BUXTOHKxNSetJ6v20b3JGo+uBFOnqxHtXeJLaZjBUeSBP1n1m38qy OPhNfi3dmnsQ4DUYQwxJb1zJidHrx+ZXUZPNjAw6i2+MUf5quyEYtVAv7L57LsarsvNB 5mw/wHwX4CBPrEctgsN93GqZ/AmPCO3+zsckJQpGkzHknCf3HY3SrzX0AbPgrcMfFWPt 94aw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=+a7/rxWEoFpRCgIH6mG5XywX4d6JvReTMXdaGMtp4Sg=; b=LRqAhDYLozqQz9IqP1Hw6QFU7m46wR/IcJFjT8IHdahZE5RQzeUsPVk986RVeM5pmA S2p/z4eCBt6UZVj3LbmmRD/0gvX/xM/K4yaAVbqp5hBsgyDqhT/G4eohfK7R4mUBcDna MxPzMpm8kW1+P3sPGv+HeKBUBSVfKrWVuyiWieERbvLc205vAFV/0PT8d5eWumODeeSv Uprcr4scNZFbwe8h67cb9CKiV56VQyteMmxjvpRpam5IFKZvhsgOsrnChZIUINT5N8EI TWThgIUa3U123khpvIvBehYyrt0/3zTcRxODFIuIIOpdCTMAr9iCBFKW6i7v9S33+14C WLsg== X-Gm-Message-State: AOAM531UmSPBK6pTnra0TtgcvI0xDOITBQ8hzDYI6oT5pzs87P/FHjeY ccd5+pmm5pbL9iL6gFrTrzjBLg== X-Google-Smtp-Source: ABdhPJwPRJUgHBmURo4GlS47nGBaj2lb0vVEI5t5woZvW62ijVErNiv+HSKTNEMVAblbSsyBcMUn4Q== X-Received: by 2002:a17:90a:8b95:: with SMTP id z21mr2351935pjn.131.1630377022070; Mon, 30 Aug 2021 19:30:22 -0700 (PDT) Received: from [192.168.1.11] (174-21-72-39.tukw.qwest.net. [174.21.72.39]) by smtp.gmail.com with ESMTPSA id o10sm15423089pfk.212.2021.08.30.19.30.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 30 Aug 2021 19:30:21 -0700 (PDT) Subject: Re: [PATCH 3/8] target/riscv: Addition of 128-bit ldu, lq and sq instructions To: =?UTF-8?B?RnLDqWTDqXJpYyBQw6l0cm90?= , qemu-devel@nongnu.org, qemu-riscv@nongnu.org References: <20210830171638.126325-1-frederic.petrot@univ-grenoble-alpes.fr> <20210830171638.126325-3-frederic.petrot@univ-grenoble-alpes.fr> From: Richard Henderson Message-ID: <7d2b1d73-184c-8ad6-80be-20ed14cd7d5e@linaro.org> Date: Mon, 30 Aug 2021 19:30:20 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210830171638.126325-3-frederic.petrot@univ-grenoble-alpes.fr> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2607:f8b0:4864:20::102d; envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x102d.google.com X-Spam_score_int: -29 X-Spam_score: -3.0 X-Spam_bar: --- X-Spam_report: (-3.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.932, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alistair Francis , Bin Meng , Palmer Dabbelt , Fabien Portas Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 8/30/21 10:16 AM, Frédéric Pétrot wrote: > +void tcg_gen_ext_i64_i128(TCGv_i64 lo, TCGv_i64 hi, TCGv_i64 arg) > +{ > + tcg_gen_mov_i64(lo, arg); > + tcg_gen_sari_i64(hi, arg, 63); > +} No, don't add this until we add TCGv_i128. Just use sari as needed in target/riscv when dealing with TCGv_i64. r~