* [PATCH] migration: Remove time_t cast for OpenBSD @ 2021-02-22 7:28 Brad Smith 2021-03-08 11:46 ` Thomas Huth 0 siblings, 1 reply; 10+ messages in thread From: Brad Smith @ 2021-02-22 7:28 UTC (permalink / raw) To: qemu-devel OpenBSD has supported 64-bit time_t across all archs since 5.5 released in 2014. Remove a time_t cast that is no longer necessary. Signed-off-by: Brad Smith <brad@comstyle.com> diff --git a/migration/savevm.c b/migration/savevm.c index 52e2d72e4b..9557f85ba9 100644 --- a/migration/savevm.c +++ b/migration/savevm.c @@ -2849,8 +2849,7 @@ bool save_snapshot(const char *name, bool overwrite, const char *vmstate, if (name) { pstrcpy(sn->name, sizeof(sn->name), name); } else { - /* cast below needed for OpenBSD where tv_sec is still 'long' */ - localtime_r((const time_t *)&tv.tv_sec, &tm); + localtime_r(&tv.tv_sec, &tm); strftime(sn->name, sizeof(sn->name), "vm-%Y%m%d%H%M%S", &tm); } ^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH] migration: Remove time_t cast for OpenBSD 2021-02-22 7:28 [PATCH] migration: Remove time_t cast for OpenBSD Brad Smith @ 2021-03-08 11:46 ` Thomas Huth 2021-03-09 21:08 ` Laurent Vivier 2021-03-09 21:38 ` Brad Smith 0 siblings, 2 replies; 10+ messages in thread From: Thomas Huth @ 2021-03-08 11:46 UTC (permalink / raw) To: Brad Smith, qemu-devel Cc: QEMU Trivial, Dr. David Alan Gilbert, Juan Quintela On 22/02/2021 08.28, Brad Smith wrote: > OpenBSD has supported 64-bit time_t across all archs since 5.5 released in 2014. > > Remove a time_t cast that is no longer necessary. > > > Signed-off-by: Brad Smith <brad@comstyle.com> > > diff --git a/migration/savevm.c b/migration/savevm.c > index 52e2d72e4b..9557f85ba9 100644 > --- a/migration/savevm.c > +++ b/migration/savevm.c > @@ -2849,8 +2849,7 @@ bool save_snapshot(const char *name, bool overwrite, const char *vmstate, > if (name) { > pstrcpy(sn->name, sizeof(sn->name), name); > } else { > - /* cast below needed for OpenBSD where tv_sec is still 'long' */ > - localtime_r((const time_t *)&tv.tv_sec, &tm); > + localtime_r(&tv.tv_sec, &tm); > strftime(sn->name, sizeof(sn->name), "vm-%Y%m%d%H%M%S", &tm); > } Please make sure to CC: the maintainers (see MAINTAINERS file). Done now. Reviewed-by: Thomas Huth <thuth@redhat.com> ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] migration: Remove time_t cast for OpenBSD 2021-03-08 11:46 ` Thomas Huth @ 2021-03-09 21:08 ` Laurent Vivier 2021-03-11 18:28 ` Dr. David Alan Gilbert 2021-03-09 21:38 ` Brad Smith 1 sibling, 1 reply; 10+ messages in thread From: Laurent Vivier @ 2021-03-09 21:08 UTC (permalink / raw) To: Thomas Huth, Brad Smith, qemu-devel Cc: QEMU Trivial, Dr. David Alan Gilbert, Juan Quintela Le 08/03/2021 à 12:46, Thomas Huth a écrit : > On 22/02/2021 08.28, Brad Smith wrote: >> OpenBSD has supported 64-bit time_t across all archs since 5.5 released in 2014. >> >> Remove a time_t cast that is no longer necessary. >> >> >> Signed-off-by: Brad Smith <brad@comstyle.com> >> >> diff --git a/migration/savevm.c b/migration/savevm.c >> index 52e2d72e4b..9557f85ba9 100644 >> --- a/migration/savevm.c >> +++ b/migration/savevm.c >> @@ -2849,8 +2849,7 @@ bool save_snapshot(const char *name, bool overwrite, const char *vmstate, >> if (name) { >> pstrcpy(sn->name, sizeof(sn->name), name); >> } else { >> - /* cast below needed for OpenBSD where tv_sec is still 'long' */ >> - localtime_r((const time_t *)&tv.tv_sec, &tm); >> + localtime_r(&tv.tv_sec, &tm); >> strftime(sn->name, sizeof(sn->name), "vm-%Y%m%d%H%M%S", &tm); >> } > but the qemu_timeval from "include/sysemu/os-win32.h" still uses a long: is this file compiled for win32? Thanks, Laurent ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] migration: Remove time_t cast for OpenBSD 2021-03-09 21:08 ` Laurent Vivier @ 2021-03-11 18:28 ` Dr. David Alan Gilbert 2021-03-11 18:39 ` Daniel P. Berrangé 0 siblings, 1 reply; 10+ messages in thread From: Dr. David Alan Gilbert @ 2021-03-11 18:28 UTC (permalink / raw) To: Laurent Vivier Cc: QEMU Trivial, Thomas Huth, Juan Quintela, qemu-devel, Brad Smith * Laurent Vivier (laurent@vivier.eu) wrote: > Le 08/03/2021 à 12:46, Thomas Huth a écrit : > > On 22/02/2021 08.28, Brad Smith wrote: > >> OpenBSD has supported 64-bit time_t across all archs since 5.5 released in 2014. > >> > >> Remove a time_t cast that is no longer necessary. > >> > >> > >> Signed-off-by: Brad Smith <brad@comstyle.com> > >> > >> diff --git a/migration/savevm.c b/migration/savevm.c > >> index 52e2d72e4b..9557f85ba9 100644 > >> --- a/migration/savevm.c > >> +++ b/migration/savevm.c > >> @@ -2849,8 +2849,7 @@ bool save_snapshot(const char *name, bool overwrite, const char *vmstate, > >> if (name) { > >> pstrcpy(sn->name, sizeof(sn->name), name); > >> } else { > >> - /* cast below needed for OpenBSD where tv_sec is still 'long' */ > >> - localtime_r((const time_t *)&tv.tv_sec, &tm); > >> + localtime_r(&tv.tv_sec, &tm); > >> strftime(sn->name, sizeof(sn->name), "vm-%Y%m%d%H%M%S", &tm); > >> } > > > > but the qemu_timeval from "include/sysemu/os-win32.h" still uses a long: is this file compiled for > win32? Yep this fails for me when built with x86_64-w64-mingw32- (it's fine with i686-w64-mingw32- ) Dave > Thanks, > Laurent > -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] migration: Remove time_t cast for OpenBSD 2021-03-11 18:28 ` Dr. David Alan Gilbert @ 2021-03-11 18:39 ` Daniel P. Berrangé 2021-03-13 23:33 ` Brad Smith 0 siblings, 1 reply; 10+ messages in thread From: Daniel P. Berrangé @ 2021-03-11 18:39 UTC (permalink / raw) To: Dr. David Alan Gilbert Cc: Thomas Huth, Juan Quintela, QEMU Trivial, qemu-devel, Laurent Vivier, Brad Smith On Thu, Mar 11, 2021 at 06:28:57PM +0000, Dr. David Alan Gilbert wrote: > * Laurent Vivier (laurent@vivier.eu) wrote: > > Le 08/03/2021 à 12:46, Thomas Huth a écrit : > > > On 22/02/2021 08.28, Brad Smith wrote: > > >> OpenBSD has supported 64-bit time_t across all archs since 5.5 released in 2014. > > >> > > >> Remove a time_t cast that is no longer necessary. > > >> > > >> > > >> Signed-off-by: Brad Smith <brad@comstyle.com> > > >> > > >> diff --git a/migration/savevm.c b/migration/savevm.c > > >> index 52e2d72e4b..9557f85ba9 100644 > > >> --- a/migration/savevm.c > > >> +++ b/migration/savevm.c > > >> @@ -2849,8 +2849,7 @@ bool save_snapshot(const char *name, bool overwrite, const char *vmstate, > > >> if (name) { > > >> pstrcpy(sn->name, sizeof(sn->name), name); > > >> } else { > > >> - /* cast below needed for OpenBSD where tv_sec is still 'long' */ > > >> - localtime_r((const time_t *)&tv.tv_sec, &tm); > > >> + localtime_r(&tv.tv_sec, &tm); > > >> strftime(sn->name, sizeof(sn->name), "vm-%Y%m%d%H%M%S", &tm); > > >> } > > > > > > > but the qemu_timeval from "include/sysemu/os-win32.h" still uses a long: is this file compiled for > > win32? > > Yep this fails for me when built with x86_64-w64-mingw32- (it's fine > with i686-w64-mingw32- ) We could just switch the code to use GDateTime from GLib and thus avoid portability issues. I think this should be equivalent: g_autoptr(GDateTime) now = g_date_time_new_now_local(); g_autofree char *nowstr = g_date_time_format(now, "vm-%Y%m%d%H%M%s"); strncpy(sn->name, sizeof(sn->name), nowstr); Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :| ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] migration: Remove time_t cast for OpenBSD 2021-03-11 18:39 ` Daniel P. Berrangé @ 2021-03-13 23:33 ` Brad Smith 2021-03-31 19:26 ` Brad Smith 0 siblings, 1 reply; 10+ messages in thread From: Brad Smith @ 2021-03-13 23:33 UTC (permalink / raw) To: Daniel P. Berrangé, Dr. David Alan Gilbert Cc: Laurent Vivier, QEMU Trivial, Thomas Huth, Juan Quintela, qemu-devel On 3/11/2021 1:39 PM, Daniel P. Berrangé wrote: > On Thu, Mar 11, 2021 at 06:28:57PM +0000, Dr. David Alan Gilbert wrote: >> * Laurent Vivier (laurent@vivier.eu) wrote: >>> Le 08/03/2021 à 12:46, Thomas Huth a écrit : >>>> On 22/02/2021 08.28, Brad Smith wrote: >>>>> OpenBSD has supported 64-bit time_t across all archs since 5.5 released in 2014. >>>>> >>>>> Remove a time_t cast that is no longer necessary. >>>>> >>>>> >>>>> Signed-off-by: Brad Smith <brad@comstyle.com> >>>>> >>>>> diff --git a/migration/savevm.c b/migration/savevm.c >>>>> index 52e2d72e4b..9557f85ba9 100644 >>>>> --- a/migration/savevm.c >>>>> +++ b/migration/savevm.c >>>>> @@ -2849,8 +2849,7 @@ bool save_snapshot(const char *name, bool overwrite, const char *vmstate, >>>>> if (name) { >>>>> pstrcpy(sn->name, sizeof(sn->name), name); >>>>> } else { >>>>> - /* cast below needed for OpenBSD where tv_sec is still 'long' */ >>>>> - localtime_r((const time_t *)&tv.tv_sec, &tm); >>>>> + localtime_r(&tv.tv_sec, &tm); >>>>> strftime(sn->name, sizeof(sn->name), "vm-%Y%m%d%H%M%S", &tm); >>>>> } >>> but the qemu_timeval from "include/sysemu/os-win32.h" still uses a long: is this file compiled for >>> win32? >> Yep this fails for me when built with x86_64-w64-mingw32- (it's fine >> with i686-w64-mingw32- ) > We could just switch the code to use GDateTime from GLib and thus > avoid portability issues. I think this should be equivalent: > > g_autoptr(GDateTime) now = g_date_time_new_now_local(); > g_autofree char *nowstr = g_date_time_format(now, "vm-%Y%m%d%H%M%s"); > strncpy(sn->name, sizeof(sn->name), nowstr); Which way do you guys want to go? Something like above, remove the comment or some variation on the comment but not mentioning OpenBSD since it is no longer relevant? ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] migration: Remove time_t cast for OpenBSD 2021-03-13 23:33 ` Brad Smith @ 2021-03-31 19:26 ` Brad Smith 2021-04-01 8:14 ` Daniel P. Berrangé 0 siblings, 1 reply; 10+ messages in thread From: Brad Smith @ 2021-03-31 19:26 UTC (permalink / raw) To: Daniel P. Berrangé, Dr. David Alan Gilbert Cc: Laurent Vivier, QEMU Trivial, Thomas Huth, Juan Quintela, qemu-devel On 3/13/2021 6:33 PM, Brad Smith wrote: > On 3/11/2021 1:39 PM, Daniel P. Berrangé wrote: >> On Thu, Mar 11, 2021 at 06:28:57PM +0000, Dr. David Alan Gilbert wrote: >>> * Laurent Vivier (laurent@vivier.eu) wrote: >>>> Le 08/03/2021 à 12:46, Thomas Huth a écrit : >>>>> On 22/02/2021 08.28, Brad Smith wrote: >>>>>> OpenBSD has supported 64-bit time_t across all archs since 5.5 >>>>>> released in 2014. >>>>>> >>>>>> Remove a time_t cast that is no longer necessary. >>>>>> >>>>>> >>>>>> Signed-off-by: Brad Smith <brad@comstyle.com> >>>>>> >>>>>> diff --git a/migration/savevm.c b/migration/savevm.c >>>>>> index 52e2d72e4b..9557f85ba9 100644 >>>>>> --- a/migration/savevm.c >>>>>> +++ b/migration/savevm.c >>>>>> @@ -2849,8 +2849,7 @@ bool save_snapshot(const char *name, bool >>>>>> overwrite, const char *vmstate, >>>>>> if (name) { >>>>>> pstrcpy(sn->name, sizeof(sn->name), name); >>>>>> } else { >>>>>> - /* cast below needed for OpenBSD where tv_sec is >>>>>> still 'long' */ >>>>>> - localtime_r((const time_t *)&tv.tv_sec, &tm); >>>>>> + localtime_r(&tv.tv_sec, &tm); >>>>>> strftime(sn->name, sizeof(sn->name), >>>>>> "vm-%Y%m%d%H%M%S", &tm); >>>>>> } >>>> but the qemu_timeval from "include/sysemu/os-win32.h" still uses a >>>> long: is this file compiled for >>>> win32? >>> Yep this fails for me when built with x86_64-w64-mingw32- (it's fine >>> with i686-w64-mingw32- ) >> We could just switch the code to use GDateTime from GLib and thus >> avoid portability issues. I think this should be equivalent: >> >> g_autoptr(GDateTime) now = g_date_time_new_now_local(); >> g_autofree char *nowstr = g_date_time_format(now, >> "vm-%Y%m%d%H%M%s"); >> strncpy(sn->name, sizeof(sn->name), nowstr); > > Which way do you guys want to go? Something like above, remove the > comment > or some variation on the comment but not mentioning OpenBSD since it > is no > longer relevant? Anyone? ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] migration: Remove time_t cast for OpenBSD 2021-03-31 19:26 ` Brad Smith @ 2021-04-01 8:14 ` Daniel P. Berrangé 2021-04-01 17:14 ` Brad Smith 0 siblings, 1 reply; 10+ messages in thread From: Daniel P. Berrangé @ 2021-04-01 8:14 UTC (permalink / raw) To: Brad Smith Cc: Thomas Huth, Juan Quintela, QEMU Trivial, qemu-devel, Dr. David Alan Gilbert, Laurent Vivier On Wed, Mar 31, 2021 at 03:26:16PM -0400, Brad Smith wrote: > On 3/13/2021 6:33 PM, Brad Smith wrote: > > On 3/11/2021 1:39 PM, Daniel P. Berrangé wrote: > > > On Thu, Mar 11, 2021 at 06:28:57PM +0000, Dr. David Alan Gilbert wrote: > > > > * Laurent Vivier (laurent@vivier.eu) wrote: > > > > > Le 08/03/2021 à 12:46, Thomas Huth a écrit : > > > > > > On 22/02/2021 08.28, Brad Smith wrote: > > > > > > > OpenBSD has supported 64-bit time_t across all archs > > > > > > > since 5.5 released in 2014. > > > > > > > > > > > > > > Remove a time_t cast that is no longer necessary. > > > > > > > > > > > > > > > > > > > > > Signed-off-by: Brad Smith <brad@comstyle.com> > > > > > > > > > > > > > > diff --git a/migration/savevm.c b/migration/savevm.c > > > > > > > index 52e2d72e4b..9557f85ba9 100644 > > > > > > > --- a/migration/savevm.c > > > > > > > +++ b/migration/savevm.c > > > > > > > @@ -2849,8 +2849,7 @@ bool save_snapshot(const char > > > > > > > *name, bool overwrite, const char *vmstate, > > > > > > > if (name) { > > > > > > > pstrcpy(sn->name, sizeof(sn->name), name); > > > > > > > } else { > > > > > > > - /* cast below needed for OpenBSD where > > > > > > > tv_sec is still 'long' */ > > > > > > > - localtime_r((const time_t *)&tv.tv_sec, &tm); > > > > > > > + localtime_r(&tv.tv_sec, &tm); > > > > > > > strftime(sn->name, sizeof(sn->name), > > > > > > > "vm-%Y%m%d%H%M%S", &tm); > > > > > > > } > > > > > but the qemu_timeval from "include/sysemu/os-win32.h" still > > > > > uses a long: is this file compiled for > > > > > win32? > > > > Yep this fails for me when built with x86_64-w64-mingw32- (it's fine > > > > with i686-w64-mingw32- ) > > > We could just switch the code to use GDateTime from GLib and thus > > > avoid portability issues. I think this should be equivalent: > > > > > > g_autoptr(GDateTime) now = g_date_time_new_now_local(); > > > g_autofree char *nowstr = g_date_time_format(now, > > > "vm-%Y%m%d%H%M%s"); > > > strncpy(sn->name, sizeof(sn->name), nowstr); > > > > Which way do you guys want to go? Something like above, remove the > > comment > > or some variation on the comment but not mentioning OpenBSD since it is > > no > > longer relevant? > > Anyone? Personally I always favour using GLib APIs if there's an applicable one, since it eliminates portability problems - or rather offloads them to the GLib maintainers, who have already solved them generally. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :| ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] migration: Remove time_t cast for OpenBSD 2021-04-01 8:14 ` Daniel P. Berrangé @ 2021-04-01 17:14 ` Brad Smith 0 siblings, 0 replies; 10+ messages in thread From: Brad Smith @ 2021-04-01 17:14 UTC (permalink / raw) To: Daniel P. Berrangé Cc: Dr. David Alan Gilbert, Laurent Vivier, QEMU Trivial, Thomas Huth, Juan Quintela, qemu-devel On 4/1/2021 4:14 AM, Daniel P. Berrangé wrote: > On Wed, Mar 31, 2021 at 03:26:16PM -0400, Brad Smith wrote: >> On 3/13/2021 6:33 PM, Brad Smith wrote: >>> On 3/11/2021 1:39 PM, Daniel P. Berrangé wrote: >>>> On Thu, Mar 11, 2021 at 06:28:57PM +0000, Dr. David Alan Gilbert wrote: >>>>> * Laurent Vivier (laurent@vivier.eu) wrote: >>>>>> Le 08/03/2021 à 12:46, Thomas Huth a écrit : >>>>>>> On 22/02/2021 08.28, Brad Smith wrote: >>>>>>>> OpenBSD has supported 64-bit time_t across all archs >>>>>>>> since 5.5 released in 2014. >>>>>>>> >>>>>>>> Remove a time_t cast that is no longer necessary. >>>>>>>> >>>>>>>> >>>>>>>> Signed-off-by: Brad Smith <brad@comstyle.com> >>>>>>>> >>>>>>>> diff --git a/migration/savevm.c b/migration/savevm.c >>>>>>>> index 52e2d72e4b..9557f85ba9 100644 >>>>>>>> --- a/migration/savevm.c >>>>>>>> +++ b/migration/savevm.c >>>>>>>> @@ -2849,8 +2849,7 @@ bool save_snapshot(const char >>>>>>>> *name, bool overwrite, const char *vmstate, >>>>>>>> if (name) { >>>>>>>> pstrcpy(sn->name, sizeof(sn->name), name); >>>>>>>> } else { >>>>>>>> - /* cast below needed for OpenBSD where >>>>>>>> tv_sec is still 'long' */ >>>>>>>> - localtime_r((const time_t *)&tv.tv_sec, &tm); >>>>>>>> + localtime_r(&tv.tv_sec, &tm); >>>>>>>> strftime(sn->name, sizeof(sn->name), >>>>>>>> "vm-%Y%m%d%H%M%S", &tm); >>>>>>>> } >>>>>> but the qemu_timeval from "include/sysemu/os-win32.h" still >>>>>> uses a long: is this file compiled for >>>>>> win32? >>>>> Yep this fails for me when built with x86_64-w64-mingw32- (it's fine >>>>> with i686-w64-mingw32- ) >>>> We could just switch the code to use GDateTime from GLib and thus >>>> avoid portability issues. I think this should be equivalent: >>>> >>>> g_autoptr(GDateTime) now = g_date_time_new_now_local(); >>>> g_autofree char *nowstr = g_date_time_format(now, >>>> "vm-%Y%m%d%H%M%s"); >>>> strncpy(sn->name, sizeof(sn->name), nowstr); >>> Which way do you guys want to go? Something like above, remove the >>> comment >>> or some variation on the comment but not mentioning OpenBSD since it is >>> no >>> longer relevant? >> Anyone? > Personally I always favour using GLib APIs if there's an applicable one, > since it eliminates portability problems - or rather offloads them to > the GLib maintainers, who have already solved them generally. Can you please submit a proper diff and I'll drop this? ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] migration: Remove time_t cast for OpenBSD 2021-03-08 11:46 ` Thomas Huth 2021-03-09 21:08 ` Laurent Vivier @ 2021-03-09 21:38 ` Brad Smith 1 sibling, 0 replies; 10+ messages in thread From: Brad Smith @ 2021-03-09 21:38 UTC (permalink / raw) To: Thomas Huth, qemu-devel Cc: QEMU Trivial, Juan Quintela, Dr. David Alan Gilbert On 3/8/2021 6:46 AM, Thomas Huth wrote: > On 22/02/2021 08.28, Brad Smith wrote: >> OpenBSD has supported 64-bit time_t across all archs since 5.5 >> released in 2014. >> >> Remove a time_t cast that is no longer necessary. >> >> >> Signed-off-by: Brad Smith <brad@comstyle.com> >> >> diff --git a/migration/savevm.c b/migration/savevm.c >> index 52e2d72e4b..9557f85ba9 100644 >> --- a/migration/savevm.c >> +++ b/migration/savevm.c >> @@ -2849,8 +2849,7 @@ bool save_snapshot(const char *name, bool >> overwrite, const char *vmstate, >> if (name) { >> pstrcpy(sn->name, sizeof(sn->name), name); >> } else { >> - /* cast below needed for OpenBSD where tv_sec is >> still 'long' */ >> - localtime_r((const time_t *)&tv.tv_sec, &tm); >> + localtime_r(&tv.tv_sec, &tm); >> strftime(sn->name, sizeof(sn->name), >> "vm-%Y%m%d%H%M%S", &tm); >> } > > Please make sure to CC: the maintainers (see MAINTAINERS file). Done now. > > Reviewed-by: Thomas Huth <thuth@redhat.com> My bad. That was an oversight on my part. I was quick to send it to the list without thinking about something like that. ^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2021-04-01 17:18 UTC | newest] Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2021-02-22 7:28 [PATCH] migration: Remove time_t cast for OpenBSD Brad Smith 2021-03-08 11:46 ` Thomas Huth 2021-03-09 21:08 ` Laurent Vivier 2021-03-11 18:28 ` Dr. David Alan Gilbert 2021-03-11 18:39 ` Daniel P. Berrangé 2021-03-13 23:33 ` Brad Smith 2021-03-31 19:26 ` Brad Smith 2021-04-01 8:14 ` Daniel P. Berrangé 2021-04-01 17:14 ` Brad Smith 2021-03-09 21:38 ` Brad Smith
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).