From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-21.0 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6439DC432BE for ; Tue, 31 Aug 2021 16:06:17 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 01B4B60FED for ; Tue, 31 Aug 2021 16:06:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 01B4B60FED Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=amsat.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:45076 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mL6H9-00055m-Qf for qemu-devel@archiver.kernel.org; Tue, 31 Aug 2021 12:06:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35570) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mL6Bh-0006Bd-6O; Tue, 31 Aug 2021 12:00:39 -0400 Received: from mail-wr1-x434.google.com ([2a00:1450:4864:20::434]:40625) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mL6Bd-00024f-Ok; Tue, 31 Aug 2021 12:00:36 -0400 Received: by mail-wr1-x434.google.com with SMTP id t15so22347082wrg.7; Tue, 31 Aug 2021 09:00:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=GjDWc7161JU0M8MQqKFpVI4yTllMsLQ9FyNi4oBBezY=; b=ok+1R7hPtyOFpl7a72lMwMqhulbA/a2c2Wc1NImQ0+gDAxfvK00TKoiQHyh7WdIesM JEJ+rZ7T7oklq3hwdXpAiZ/bWJWjMs+elzTCuIyzr8GaxsD9bSpj3tKSlMGo2Gxm31y/ y/soI0eIICwh7F+jpb3zIQgRECnOdmZ8zYkJ4RqTEMV19qjo6r7+xlo2hWar+rFMD3kq 1cNksfTVmqMXHBkUsv9EvweiyrXW34+Vl5iQBtZp6l8+kDPJoHd7v/4o+uCZRHDW7Zdg qoARD13OLTVjYC2kzn4lyBnfCzOMap9Gh+Pu1JX4qj0rZz0v6kH1EAsz96KLp0SzIPvL RoxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=GjDWc7161JU0M8MQqKFpVI4yTllMsLQ9FyNi4oBBezY=; b=A4ObEvo9zs3Ig3cyarGuZ4YqskKoBenqqM9iFC+81xScdgngAXLvO8ONOLaONwG0rZ QhSy/q3oT/Aik/ko9Yh/zT1AvtkAYwRavrEjnIi1l0Ej+E+PWewxDdRH/uM+UN848Rc1 x87rpq9zcznRvuiauHaWBjVY6bvXO4PUdKu371XXt4WABMYYxnSihoyTlZYbTW7IDTSl xZ/XYOucWbGo7rdc0y9cWXFgI0xBVs+tSYJEr3d/D0HIk0XCuhB/T/KJy/jlONqqnraX BRLyS+UgWkjGAdD62+sACQNLz4i9MXcMOpfZBwkDtrMP9TSzLqQOhdagIvMsQdgcmPYY 4LeA== X-Gm-Message-State: AOAM530xFXMcZIQl3TfDj9sAqCkjLDpVyMgWsSplaIUyiXqpqbJb1F2l m7lPqmvBW8De4mog15uEIvbYV2Vuc2Y= X-Google-Smtp-Source: ABdhPJyHXay54fzHYg+fJSFgczmRxY0GuRAH8TwKYlQuxj7Xmk0ujirWAFqce6h2nV2uEOWCOjfn7Q== X-Received: by 2002:adf:cd0f:: with SMTP id w15mr32688559wrm.346.1630425630160; Tue, 31 Aug 2021 09:00:30 -0700 (PDT) Received: from [192.168.1.36] (163.red-83-52-55.dynamicip.rima-tde.net. [83.52.55.163]) by smtp.gmail.com with ESMTPSA id o8sm2618404wmp.42.2021.08.31.09.00.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 31 Aug 2021 09:00:29 -0700 (PDT) Subject: Re: [PATCH 3/5] hw/arm/aspeed: Add fuji machine type To: Peter Delevoryas , =?UTF-8?Q?C=c3=a9dric_Le_Goater?= References: <20210827210417.4022054-1-pdel@fb.com> <20210827210417.4022054-4-pdel@fb.com> <5278af17-e56a-772a-21fe-8594790427d3@kaod.org> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Message-ID: <7ebbc78c-2deb-de51-5c7e-301633cead6e@amsat.org> Date: Tue, 31 Aug 2021 18:00:28 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::434; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-x434.google.com X-Spam_score_int: -4 X-Spam_score: -0.5 X-Spam_bar: / X-Spam_report: (-0.5 / 5.0 requ) DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, NICE_REPLY_A=-0.932, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "qemu-arm@nongnu.org" , "joel@jms.id.au" , "qemu-devel@nongnu.org" Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 8/28/21 6:00 PM, Peter Delevoryas wrote: > Actually yes! I should have included a link to it: > https://github.com/facebook/openbmc-uboot/blob/openbmc/helium/v2019.04/arch/arm/dts/aspeed-bmc-facebook-fuji.dts (On technical lists, it's best to avoid top-posting, and to instead reply inline to make the conversation easier to follow). Can you add a test for your board please? See examples in tests/acceptance/boot_linux_console.py: - test_arm_ast2500_romulus_openbmc_v2_9_0 - test_arm_ast2600_debian > *From: *Cédric Le Goater > *Date: *Saturday, August 28, 2021 at 1:28 AM > *To: *Peter Delevoryas > *Cc: *joel@jms.id.au , qemu-devel@nongnu.org > , qemu-arm@nongnu.org > *Subject: *Re: [PATCH 3/5] hw/arm/aspeed: Add fuji machine type > > On 8/27/21 11:04 PM, pdel@fb.com wrote: >> From: Peter Delevoryas >> >> Fuji uses the AST2600, so it's very similar to `ast2600-evb`, but it has >> a few slight differences, such as using UART1 for the serial console. > > Do we have a public DTS for this board ? > > Thanks, > > C. > >> >> Signed-off-by: Peter Delevoryas >> --- >>  hw/arm/aspeed.c | 13 +++++++++++++ >>  1 file changed, 13 insertions(+) >> >> diff --git a/hw/arm/aspeed.c b/hw/arm/aspeed.c >> index ff53d12395..d2eb516a1d 100644 >> --- a/hw/arm/aspeed.c >> +++ b/hw/arm/aspeed.c >> @@ -1029,6 +1029,15 @@ static void > aspeed_machine_rainier_class_init(ObjectClass *oc, void *data) >>          aspeed_soc_num_cpus(amc->soc_name); >>  }; >>  >> +static void aspeed_machine_fuji_class_init(ObjectClass *oc, void *data) >> +{ >> +    MachineClass *mc = MACHINE_CLASS(oc); >> +    AspeedMachineClass *amc = ASPEED_MACHINE_CLASS(oc); >> + >> +    mc->desc = "Facebook Fuji BMC (Aspeed AST2600, Cortex-A7)"; >> +    amc->serial_dev = ASPEED_DEV_UART1; >> +} >> + >>  static const TypeInfo aspeed_machine_types[] = { >>      { >>          .name          = MACHINE_TYPE_NAME("palmetto-bmc"), >> @@ -1078,6 +1087,10 @@ static const TypeInfo aspeed_machine_types[] = { >>          .name          = MACHINE_TYPE_NAME("rainier-bmc"), >>          .parent        = TYPE_ASPEED_MACHINE, >>          .class_init    = aspeed_machine_rainier_class_init, >> +    }, { >> +        .name          = MACHINE_TYPE_NAME("fuji"), >> +        .parent        = MACHINE_TYPE_NAME("ast2600-evb"), >> +        .class_init    = aspeed_machine_fuji_class_init, >>      }, { >>          .name          = TYPE_ASPEED_MACHINE, >>          .parent        = TYPE_MACHINE, >> >