From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0CC69C433DF for ; Thu, 11 Jun 2020 13:07:31 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CA33120691 for ; Thu, 11 Jun 2020 13:07:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="FnOVGo7o" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CA33120691 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:49560 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jjMva-00086i-4S for qemu-devel@archiver.kernel.org; Thu, 11 Jun 2020 09:07:30 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53130) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jjMu0-00072n-2G for qemu-devel@nongnu.org; Thu, 11 Jun 2020 09:05:52 -0400 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:24689 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jjMtx-0003Hv-O1 for qemu-devel@nongnu.org; Thu, 11 Jun 2020 09:05:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1591880746; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:openpgp:openpgp; bh=YIz1NKbDymD7k2X+bQguLOSW6CHbfeJTx6CAaOQAV8M=; b=FnOVGo7oUqpYPPM5Dv7DPCqqw+N41VRDCrr+SYgprToeS4Fy5WeaxwgtcN/bjFEFgjplPb rjkfTvOFbQ/3ZvlliNZAKiwUK7UGemDIu3+PWRDWw1fnM6HqiRaEEa3YxJOsVHjCjOQzal /gGt0MP/1Wfn3GczI769HBdWlN/bacM= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-47-7YogGtn6PmWLBmZKzId7AQ-1; Thu, 11 Jun 2020 09:05:42 -0400 X-MC-Unique: 7YogGtn6PmWLBmZKzId7AQ-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id DA54C8015CB; Thu, 11 Jun 2020 13:05:39 +0000 (UTC) Received: from thuth.remote.csb (ovpn-114-175.ams2.redhat.com [10.36.114.175]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C25785D9EF; Thu, 11 Jun 2020 13:05:28 +0000 (UTC) Subject: Re: [PATCH v2 4/8] s390/sclp: read sccb from mem based on sccb length To: Collin Walling , qemu-devel@nongnu.org, qemu-s390x@nongnu.org References: <20200515222032.18838-1-walling@linux.ibm.com> <20200515222032.18838-5-walling@linux.ibm.com> From: Thomas Huth Openpgp: preference=signencrypt Message-ID: <7f43ab88-0f73-6e09-cc94-fae116dd0df9@redhat.com> Date: Thu, 11 Jun 2020 15:05:27 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <20200515222032.18838-5-walling@linux.ibm.com> Content-Language: en-US X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=207.211.31.120; envelope-from=thuth@redhat.com; helo=us-smtp-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/06/11 08:37:10 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: frankja@linux.ibm.com, david@redhat.com, cohuck@redhat.com, pasic@linux.ibm.com, borntraeger@de.ibm.com, mst@redhat.com, svens@linux.ibm.com, pbonzini@redhat.com, mihajlov@linux.ibm.com, rth@twiddle.net Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 16/05/2020 00.20, Collin Walling wrote: > The header contains the actual length of the SCCB. Instead of using a > static 4K size, let's allow for a variable size determined by the value > set in the header. The proper checks are already in place to ensure the > SCCB length is sufficent to store a full response and that the length > does not cross any explicitly-set boundaries. > > Signed-off-by: Collin Walling > --- > hw/s390x/sclp.c | 13 ++++++++----- > 1 file changed, 8 insertions(+), 5 deletions(-) With the proper checks from the previous patch in place: Reviewed-by: Thomas Huth