From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: "Markus Armbruster" <armbru@redhat.com>,
qemu-devel@nongnu.org, "Alex Bennée" <alex.bennee@linaro.org>
Subject: Re: [Qemu-devel] [PATCH v3 20/29] Include qemu/main-loop.h less
Date: Fri, 9 Aug 2019 12:29:54 +0200 [thread overview]
Message-ID: <7f824b69-d506-e6ad-8fa9-3d3c232db02c@redhat.com> (raw)
In-Reply-To: <c76aaebc-d4bf-cb25-fe27-7a9c9ba644c9@redhat.com>
On 8/9/19 11:42 AM, Philippe Mathieu-Daudé wrote:
[...]
> netmap failing again :S
>
> $ make docker-image-debian-amd64 V=1 DEBUG=1
> [...]
> CC net/netmap.o
> net/netmap.c: In function 'netmap_update_fd_handler':
> net/netmap.c:109:5: error: implicit declaration of function
> 'qemu_set_fd_handler' [-Werror=implicit-function-declaration]
> qemu_set_fd_handler(s->nmd->fd,
> ^~~~~~~~~~~~~~~~~~~
> net/netmap.c:109:5: error: nested extern declaration of
> 'qemu_set_fd_handler' [-Werror=nested-externs]
Since it might not be obvious to see how helpful/powerful is Docker, I
gathered few notes (already posted once) about how I use it (often
bisecting).
# Automatically create a base image (the image is then cached)
$ make docker-image-debian-s390x-cross
# Create a out-of-tree build directory
$ mkdir build/docker_s390x
# Run ./configure
#
# --rm : Use a temp copy of the base image (do not modify it)
# -v ...: Mount the current directory within the container
# -w ...: Start the shell in the out-of-tree directory
# -u ...: Use same UID as my user so I can remove the files after
# $QEMU_CONFIGURE_OPTS contains the cross-compile options
#
$ docker run --rm \
-v $PWD:$PWD \
-w $PWD/build/docker_s390x \
-u $UID \
qemu:debian-s390x-cross \
\
sh -c "../../configure \$QEMU_CONFIGURE_OPTS"
I use 'sh -c' to escape $QEMU_CONFIGURE_OPTS, there might be a cleaner
way to do this.
# Stupid step to speed up bisection
# This will:
# - clone submodules if necessary
# - build slirp
# - build fdt
# - build capstone
# - generated bunch of headers
# - generated bunch of trace files
$ docker run --rm \
-v $PWD:$PWD \
-w $PWD/build/docker_s390x \
-u $UID \
qemu:debian-s390x-cross \
\
make stubs/qtest.o
Now the directory is ready for building/bisecting.
I.e. build a single file:
$ docker run --rm \
-v $PWD:$PWD \
-w $PWD/build/docker_s390x \
-u $UID \
qemu:debian-s390x-cross \
\
make -C s390x-softmmu hw/intc/s390_flic_kvm.o
make: Entering directory 'build/docker_s390x/s390x-softmmu'
CC hw/intc/s390_flic_kvm.o
hw/intc/s390_flic_kvm.c: In function 'kvm_flic_save':
hw/intc/s390_flic_kvm.c:395:9: error: implicit declaration of function
'qemu_put_be64' [-Werror=implicit-function-declaration]
qemu_put_be64(f, FLIC_FAILED);
^~~~~~~~~~~~~
hw/intc/s390_flic_kvm.c:395:9: error: nested extern declaration of
'qemu_put_be64' [-Werror=nested-externs]
hw/intc/s390_flic_kvm.c:410:9: error: implicit declaration of function
'qemu_put_buffer' [-Werror=implicit-function-declaration]
qemu_put_buffer(f, (uint8_t *) buf,
^~~~~~~~~~~~~~~
hw/intc/s390_flic_kvm.c:410:9: error: nested extern declaration of
'qemu_put_buffer' [-Werror=nested-externs]
hw/intc/s390_flic_kvm.c: In function 'kvm_flic_load':
hw/intc/s390_flic_kvm.c:438:13: error: implicit declaration of function
'qemu_get_be64' [-Werror=implicit-function-declaration]
count = qemu_get_be64(f);
^~~~~~~~~~~~~
hw/intc/s390_flic_kvm.c:438:5: error: nested extern declaration of
'qemu_get_be64' [-Werror=nested-externs]
count = qemu_get_be64(f);
^~~~~
hw/intc/s390_flic_kvm.c:454:9: error: implicit declaration of function
'qemu_get_buffer' [-Werror=implicit-function-declaration]
if (qemu_get_buffer(f, (uint8_t *) buf, len) != len) {
^~~~~~~~~~~~~~~
hw/intc/s390_flic_kvm.c:454:5: error: nested extern declaration of
'qemu_get_buffer' [-Werror=nested-externs]
if (qemu_get_buffer(f, (uint8_t *) buf, len) != len) {
^~
cc1: all warnings being treated as errors
rules.mak:69: recipe for target 'hw/intc/s390_flic_kvm.o' failed
make: *** [hw/intc/s390_flic_kvm.o] Error 1
make: Leaving directory 'build/docker_s390x/s390x-softmmu'
Hope that help!
Regards,
Phil.
next prev parent reply other threads:[~2019-08-09 10:31 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-09 6:46 [Qemu-devel] [PATCH v3 00/29] Tame a few "touch this, recompile the world" headers Markus Armbruster
2019-08-09 6:46 ` [Qemu-devel] [PATCH v3 01/29] include: Make headers more self-contained Markus Armbruster
2019-08-09 6:46 ` [Qemu-devel] [PATCH v3 02/29] Include generated QAPI headers less Markus Armbruster
2019-08-09 6:46 ` [Qemu-devel] [PATCH v3 03/29] qapi: Split error.json off common.json Markus Armbruster
2019-08-09 6:46 ` [Qemu-devel] [PATCH v3 04/29] memory: Fix type of IOMMUMemoryRegionClass member @parent_class Markus Armbruster
2019-08-09 6:46 ` [Qemu-devel] [PATCH v3 05/29] queue: Drop superfluous #include qemu/atomic.h Markus Armbruster
2019-08-09 6:46 ` [Qemu-devel] [PATCH v3 06/29] trace: Eliminate use of TARGET_FMT_plx Markus Armbruster
2019-08-09 6:46 ` [Qemu-devel] [PATCH v3 07/29] trace: Do not include qom/cpu.h into generated trace.h Markus Armbruster
2019-08-09 6:46 ` [Qemu-devel] [PATCH v3 08/29] Include sysemu/reset.h a lot less Markus Armbruster
2019-08-09 6:46 ` [Qemu-devel] [PATCH v3 09/29] Include migration/qemu-file-types.h " Markus Armbruster
2019-08-09 9:58 ` Philippe Mathieu-Daudé
2019-08-09 11:48 ` Markus Armbruster
2019-08-09 6:46 ` [Qemu-devel] [PATCH v3 10/29] ide: Include hw/ide/internal a bit less outside hw/ide/ Markus Armbruster
2019-08-09 6:46 ` [Qemu-devel] [PATCH v3 11/29] typedefs: Separate incomplete types and function types Markus Armbruster
2019-08-09 6:46 ` [Qemu-devel] [PATCH v3 12/29] Include hw/irq.h a lot less Markus Armbruster
2019-08-09 6:46 ` [Qemu-devel] [PATCH v3 13/29] Clean up inclusion of exec/cpu-common.h Markus Armbruster
2019-08-09 6:46 ` [Qemu-devel] [PATCH v3 14/29] migration: Move the VMStateDescription typedef to typedefs.h Markus Armbruster
2019-08-09 6:46 ` [Qemu-devel] [PATCH v3 15/29] Include migration/vmstate.h less Markus Armbruster
2019-08-09 6:46 ` [Qemu-devel] [PATCH v3 16/29] Include exec/memory.h slightly less Markus Armbruster
2019-08-09 10:03 ` Philippe Mathieu-Daudé
2019-08-09 6:46 ` [Qemu-devel] [PATCH v3 17/29] Include qom/object.h " Markus Armbruster
2019-08-09 6:46 ` [Qemu-devel] [PATCH v3 18/29] Include hw/hw.h exactly where needed Markus Armbruster
2019-08-09 6:46 ` [Qemu-devel] [PATCH v3 19/29] Include qemu/queue.h slightly less Markus Armbruster
2019-08-09 10:05 ` Philippe Mathieu-Daudé
2019-08-09 6:46 ` [Qemu-devel] [PATCH v3 20/29] Include qemu/main-loop.h less Markus Armbruster
2019-08-09 9:42 ` Philippe Mathieu-Daudé
2019-08-09 10:10 ` Philippe Mathieu-Daudé
2019-08-09 10:29 ` Philippe Mathieu-Daudé [this message]
2019-08-09 10:36 ` Philippe Mathieu-Daudé
2019-08-09 11:55 ` Markus Armbruster
2019-08-09 12:29 ` Philippe Mathieu-Daudé
2019-08-09 16:00 ` Alex Bennée
2019-08-10 19:34 ` Markus Armbruster
2019-08-12 12:49 ` Philippe Mathieu-Daudé
2019-08-15 12:55 ` [Qemu-devel] Running docker cross-tests with SELinux (was: Re: [PATCH v3 20/29] Include qemu/main-loop.h less) Philippe Mathieu-Daudé
2019-08-09 6:46 ` [Qemu-devel] [PATCH v3 21/29] Include hw/qdev-properties.h less Markus Armbruster
2019-08-09 6:46 ` [Qemu-devel] [PATCH v3 22/29] Include hw/boards.h a bit less Markus Armbruster
2019-08-09 6:46 ` [Qemu-devel] [PATCH v3 23/29] numa: Don't include hw/boards.h into sysemu/numa.h Markus Armbruster
2019-08-09 6:46 ` [Qemu-devel] [PATCH v3 24/29] Include sysemu/hostmem.h less Markus Armbruster
2019-08-09 10:39 ` Philippe Mathieu-Daudé
2019-08-09 6:46 ` [Qemu-devel] [PATCH v3 25/29] numa: Move remaining NUMA declarations from sysemu.h to numa.h Markus Armbruster
2019-08-09 10:53 ` Philippe Mathieu-Daudé
2019-08-09 6:46 ` [Qemu-devel] [PATCH v3 26/29] Clean up inclusion of sysemu/sysemu.h Markus Armbruster
2019-08-09 6:46 ` [Qemu-devel] [PATCH v3 27/29] Include sysemu/sysemu.h a lot less Markus Armbruster
2019-08-09 6:46 ` [Qemu-devel] [PATCH v3 28/29] sysemu: Move the VMChangeStateEntry typedef to qemu/typedefs.h Markus Armbruster
2019-08-09 6:46 ` [Qemu-devel] [PATCH v3 29/29] sysemu: Split sysemu/runstate.h off sysemu/sysemu.h Markus Armbruster
2019-08-09 10:40 ` [Qemu-devel] [PATCH v3 00/29] Tame a few "touch this, recompile the world" headers no-reply
2019-08-09 16:12 ` Philippe Mathieu-Daudé
2019-08-10 17:01 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7f824b69-d506-e6ad-8fa9-3d3c232db02c@redhat.com \
--to=philmd@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=armbru@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).