From: Daniel Henrique Barboza <danielhb413@gmail.com>
To: qemu-devel@nongnu.org
Cc: "Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"Alistair Francis" <alistair.francis@wdc.com>
Subject: Re: [PATCH v8 00/16] QMP/HMP: introduce 'dumpdtb'
Date: Sat, 8 Oct 2022 07:52:41 -0300 [thread overview]
Message-ID: <7fdbd348-62ff-146a-a0d0-463e7b0c0808@gmail.com> (raw)
In-Reply-To: <20220926173855.1159396-1-danielhb413@gmail.com>
Philippe,
I'm going to push the acked patches to ppc-next. If you send a r-b for patches
2 and 4 I can push them as well.
Alistair, I intend to push the acked RISC-V patches (patches 14 and 15) via the
ppc-next tree as well. Let me know if you'd rather pick them via the RISC-V
tree.
Thanks,
Daniel
On 9/26/22 14:38, Daniel Henrique Barboza wrote:
> Hi,
>
> This new version contains all changes proposed during the review process,
> all of them done in the patch that introduces dumpdtb.
>
> Other changes made:
>
> - Patch 14/14, the one that introduces the command, is now patch 1. This
> change is to make the other machine patches referencing 'dumpdtb QMP/HMP'
> to reference an existing command.
>
> - added two new patches based on Philippe's feedback: patch 2 and patch 4.
>
> Mandatory patch pending review: patch 2
> Optional machine patches pending review: 3, 4, 5, 7, 16
>
> Changes from v7:
> - patch 14: switched to start of the series, now patch 1
> - patch 1:
> - changed hmp-commands.hx help to:
> "dump the FDT in dtb format to 'filename'"
>
> - changed 'filename' to *filename*
>
> - changed filename description in machine.json to
> "name of the binary FDT file to be created"
>
> - changed 'size' to uint32_t
> - added a g_assert() for FDT size == zero
> - added a success message in hmp_dumpdtb()
> - patch 2 (new):
> - free ms->fdt in machine_finalize()
> - patch 4 (new):
> - assign ms->fdt in boston_mach_init()
> - v7 link: https://lists.gnu.org/archive/html/qemu-devel/2022-09/msg01350.html
>
> Daniel Henrique Barboza (16):
> qmp/hmp, device_tree.c: introduce dumpdtb
> hw/core: free ms->fdt in machine_finalize()
> hw/arm: do not free machine->fdt in arm_load_dtb()
> hw/mips: set machine->fdt in boston_mach_init()
> hw/microblaze: set machine->fdt in microblaze_load_dtb()
> hw/nios2: set machine->fdt in nios2_load_dtb()
> hw/ppc: set machine->fdt in ppce500_load_device_tree()
> hw/ppc: set machine->fdt in bamboo_load_device_tree()
> hw/ppc: set machine->fdt in sam460ex_load_device_tree()
> hw/ppc: set machine->fdt in xilinx_load_device_tree()
> hw/ppc: set machine->fdt in pegasos2_machine_reset()
> hw/ppc: set machine->fdt in pnv_reset()
> hw/ppc: set machine->fdt in spapr machine
> hw/riscv: set machine->fdt in sifive_u_machine_init()
> hw/riscv: set machine->fdt in spike_board_init()
> hw/xtensa: set machine->fdt in xtfpga_init()
>
> hmp-commands.hx | 15 +++++++++++++++
> hw/arm/boot.c | 3 ++-
> hw/core/machine.c | 1 +
> hw/microblaze/boot.c | 8 +++++++-
> hw/microblaze/meson.build | 2 +-
> hw/mips/boston.c | 5 ++++-
> hw/nios2/boot.c | 8 +++++++-
> hw/nios2/meson.build | 2 +-
> hw/ppc/e500.c | 13 ++++++++++++-
> hw/ppc/pegasos2.c | 4 ++++
> hw/ppc/pnv.c | 8 +++++++-
> hw/ppc/ppc440_bamboo.c | 25 +++++++++++++-----------
> hw/ppc/sam460ex.c | 21 ++++++++++----------
> hw/ppc/spapr.c | 3 +++
> hw/ppc/spapr_hcall.c | 8 ++++++++
> hw/ppc/virtex_ml507.c | 25 +++++++++++++-----------
> hw/riscv/sifive_u.c | 3 +++
> hw/riscv/spike.c | 6 ++++++
> hw/xtensa/meson.build | 2 +-
> hw/xtensa/xtfpga.c | 6 +++++-
> include/sysemu/device_tree.h | 1 +
> monitor/misc.c | 1 +
> qapi/machine.json | 18 ++++++++++++++++++
> softmmu/device_tree.c | 37 ++++++++++++++++++++++++++++++++++++
> 24 files changed, 183 insertions(+), 42 deletions(-)
>
next prev parent reply other threads:[~2022-10-08 10:53 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-26 17:38 [PATCH v8 00/16] QMP/HMP: introduce 'dumpdtb' Daniel Henrique Barboza
2022-09-26 17:38 ` [PATCH v8 01/16] qmp/hmp, device_tree.c: introduce dumpdtb Daniel Henrique Barboza
2022-09-26 17:38 ` [PATCH v8 02/16] hw/core: free ms->fdt in machine_finalize() Daniel Henrique Barboza
2022-09-26 17:38 ` [PATCH v8 03/16] hw/arm: do not free machine->fdt in arm_load_dtb() Daniel Henrique Barboza
2022-09-26 17:38 ` [PATCH v8 04/16] hw/mips: set machine->fdt in boston_mach_init() Daniel Henrique Barboza
2022-09-26 17:38 ` [PATCH v8 05/16] hw/microblaze: set machine->fdt in microblaze_load_dtb() Daniel Henrique Barboza
2022-09-26 17:38 ` [PATCH v8 06/16] hw/nios2: set machine->fdt in nios2_load_dtb() Daniel Henrique Barboza
2022-09-26 17:38 ` [PATCH v8 07/16] hw/ppc: set machine->fdt in ppce500_load_device_tree() Daniel Henrique Barboza
2022-09-26 17:38 ` [PATCH v8 08/16] hw/ppc: set machine->fdt in bamboo_load_device_tree() Daniel Henrique Barboza
2022-09-26 17:38 ` [PATCH v8 09/16] hw/ppc: set machine->fdt in sam460ex_load_device_tree() Daniel Henrique Barboza
2022-09-26 17:38 ` [PATCH v8 10/16] hw/ppc: set machine->fdt in xilinx_load_device_tree() Daniel Henrique Barboza
2022-09-26 17:38 ` [PATCH v8 11/16] hw/ppc: set machine->fdt in pegasos2_machine_reset() Daniel Henrique Barboza
2022-09-26 17:38 ` [PATCH v8 12/16] hw/ppc: set machine->fdt in pnv_reset() Daniel Henrique Barboza
2022-09-26 17:38 ` [PATCH v8 13/16] hw/ppc: set machine->fdt in spapr machine Daniel Henrique Barboza
2022-09-26 17:38 ` [PATCH v8 14/16] hw/riscv: set machine->fdt in sifive_u_machine_init() Daniel Henrique Barboza
2022-09-26 17:38 ` [PATCH v8 15/16] hw/riscv: set machine->fdt in spike_board_init() Daniel Henrique Barboza
2022-09-26 17:38 ` [PATCH v8 16/16] hw/xtensa: set machine->fdt in xtfpga_init() Daniel Henrique Barboza
2022-10-08 10:52 ` Daniel Henrique Barboza [this message]
2022-10-15 12:06 ` [PATCH v8 00/16] QMP/HMP: introduce 'dumpdtb' Daniel Henrique Barboza
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7fdbd348-62ff-146a-a0d0-463e7b0c0808@gmail.com \
--to=danielhb413@gmail.com \
--cc=alistair.francis@wdc.com \
--cc=f4bug@amsat.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).