From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1EC26C433DB for ; Mon, 29 Mar 2021 16:08:07 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 787DE6188B for ; Mon, 29 Mar 2021 16:08:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 787DE6188B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:52692 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lQuQv-0003gA-8S for qemu-devel@archiver.kernel.org; Mon, 29 Mar 2021 12:08:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39848) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lQuO5-0002EH-Ec for qemu-devel@nongnu.org; Mon, 29 Mar 2021 12:05:09 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:54903) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lQuO1-00014R-It for qemu-devel@nongnu.org; Mon, 29 Mar 2021 12:05:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1617033903; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qs8b5Nl6VFJISb4EbKdYCIQgMTLdcW8oflY/N77thQM=; b=Ibgyuy8WvdA7tcUCHgsY5rdomGg84w/t9C41O0CjUio+V38905Kur56A80Ng+2wEDXwGUf kxfWFX2Hq7jR5dDEolrTWlgTrO9J+6bIqYdZLM+NFRgd8rSubCHYepZbA2m0GV87dMviOH pXMXoSB8CM1s3tP9+6PC2qk/1kkFN38= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-146-dKaNSNavMemCIqvMfuoGLw-1; Mon, 29 Mar 2021 12:05:00 -0400 X-MC-Unique: dKaNSNavMemCIqvMfuoGLw-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C10431009E2D; Mon, 29 Mar 2021 16:04:58 +0000 (UTC) Received: from dresden.str.redhat.com (ovpn-113-119.ams2.redhat.com [10.36.113.119]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B43CC10023BE; Mon, 29 Mar 2021 16:04:57 +0000 (UTC) Subject: Re: [PATCH] qcow2: use external virtual timers To: Pavel Dovgalyuk , qemu-devel@nongnu.org References: <161700516327.1141158.8366564693714562536.stgit@pasha-ThinkPad-X280> From: Max Reitz Message-ID: <7fec7e97-9046-e223-8d82-ae1eb926d5c1@redhat.com> Date: Mon, 29 Mar 2021 18:04:56 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <161700516327.1141158.8366564693714562536.stgit@pasha-ThinkPad-X280> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=mreitz@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=170.10.133.124; envelope-from=mreitz@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kwolf@redhat.com, pbonzini@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 29.03.21 10:06, Pavel Dovgalyuk wrote: > Regular virtual timers are used to emulate timings > related to vCPU and peripheral states. QCOW2 uses timers > to clean the cache. These timers should have external > flag. In the opposite case they affect the execution > and it can't be recorded and replayed. > This patch adds external flag to the timer for qcow2 > cache clean. > > Signed-off-by: Pavel Dovgalyuk > Reviewed-by: Paolo Bonzini > --- > block/qcow2.c | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) Thanks, applied to my block branch: https://git.xanclic.moe/XanClic/qemu/commits/branch/block Max