From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v4 20/29] Include qemu/main-loop.h less
Date: Mon, 12 Aug 2019 12:55:28 +0200 [thread overview]
Message-ID: <802f5f60-1be0-5bb6-d224-dc566fa38747@redhat.com> (raw)
In-Reply-To: <20190812052359.30071-21-armbru@redhat.com>
On 8/12/19 7:23 AM, Markus Armbruster wrote:
> In my "build everything" tree, changing qemu/main-loop.h triggers a
> recompile of some 5600 out of 6600 objects (not counting tests and
> objects that don't depend on qemu/osdep.h). It includes block/aio.h,
> which in turn includes qemu/event_notifier.h, qemu/notify.h,
> qemu/processor.h, qemu/qsp.h, qemu/queue.h, qemu/thread-posix.h,
> qemu/thread.h, qemu/timer.h, and a few more.
>
> Include qemu/main-loop.h only where it's needed. Touching it now
> recompiles only some 1700 objects. For block/aio.h and
> qemu/event_notifier.h, these numbers drop from 5600 to 2800. For the
> others, they shrink only slightly.
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
> fsdev/qemu-fsdev-throttle.h | 1 -
> hw/9pfs/coth.h | 1 -
> include/block/block_int.h | 1 -
> include/chardev/char-fe.h | 1 +
> include/chardev/char-io.h | 1 +
> include/chardev/char.h | 2 +-
> include/hw/scsi/scsi.h | 1 +
> include/sysemu/sysemu.h | 1 -
> nbd/nbd-internal.h | 1 -
> ui/vnc-auth-sasl.h | 1 -
> accel/kvm/kvm-all.c | 1 +
> block.c | 1 +
> block/block-backend.c | 1 +
> block/create.c | 1 +
> block/io.c | 1 +
> block/nbd.c | 1 +
> block/nfs.c | 1 +
> block/nvme.c | 1 +
> block/qcow2.c | 1 +
> block/qed.c | 1 +
> block/sheepdog.c | 1 +
> block/throttle-groups.c | 1 +
> blockdev.c | 1 +
> blockjob.c | 1 +
> chardev/baum.c | 1 +
> chardev/char-pipe.c | 1 +
> chardev/char-win-stdio.c | 1 +
> chardev/char-win.c | 1 +
> dump/dump.c | 1 +
> fsdev/qemu-fsdev-throttle.c | 1 +
> hw/9pfs/9p.c | 1 +
> hw/9pfs/codir.c | 1 +
> hw/9pfs/cofile.c | 1 +
> hw/9pfs/cofs.c | 1 +
> hw/9pfs/coth.c | 1 +
> hw/9pfs/coxattr.c | 1 +
> hw/9pfs/xen-9p-backend.c | 1 +
> hw/arm/omap1.c | 1 +
> hw/block/dataplane/virtio-blk.c | 1 +
> hw/block/dataplane/xen-block.c | 1 +
> hw/block/fdc.c | 1 +
> hw/block/xen-block.c | 1 +
> hw/char/virtio-serial-bus.c | 1 +
> hw/core/machine-qmp-cmds.c | 1 +
> hw/display/qxl.c | 1 +
> hw/dma/etraxfs_dma.c | 1 +
> hw/i386/intel_iommu.c | 1 +
> hw/i386/xen/xen-hvm.c | 1 +
> hw/ide/ahci.c | 1 +
> hw/ide/core.c | 1 +
> hw/ide/qdev.c | 1 +
> hw/intc/s390_flic.c | 1 +
> hw/m68k/mcf5206.c | 1 +
> hw/m68k/mcf5208.c | 1 +
> hw/misc/imx6_src.c | 1 +
> hw/net/fsl_etsec/etsec.c | 1 +
> hw/net/lan9118.c | 1 +
> hw/net/vhost_net.c | 2 +-
> hw/net/virtio-net.c | 1 +
> hw/ppc/ppc.c | 1 +
> hw/ppc/ppc440_uc.c | 1 +
> hw/ppc/spapr_hcall.c | 1 +
> hw/ppc/spapr_rng.c | 1 +
> hw/scsi/mptsas.c | 1 +
> hw/scsi/scsi-disk.c | 1 +
> hw/scsi/vmw_pvscsi.c | 1 +
> hw/timer/allwinner-a10-pit.c | 1 +
> hw/timer/altera_timer.c | 1 +
> hw/timer/etraxfs_timer.c | 1 +
> hw/timer/exynos4210_rtc.c | 1 +
> hw/timer/milkymist-sysctl.c | 1 +
> hw/usb/dev-uas.c | 1 +
> hw/usb/hcd-ehci.c | 1 +
> hw/usb/host-libusb.c | 1 +
> hw/usb/xen-usb.c | 1 +
> hw/vfio/ccw.c | 1 +
> hw/vfio/common.c | 1 +
> hw/vfio/pci.c | 1 +
> hw/vfio/platform.c | 1 +
> hw/virtio/vhost-backend.c | 1 +
> hw/virtio/vhost-user.c | 1 +
> hw/virtio/virtio-crypto.c | 1 +
> hw/virtio/virtio-pmem.c | 1 +
> hw/virtio/virtio.c | 1 +
> hw/xen/xen-legacy-backend.c | 1 +
> hw/xen/xen_pvdev.c | 1 +
> memory.c | 1 +
> migration/block.c | 1 +
> migration/colo.c | 1 +
> migration/migration.c | 1 +
> migration/savevm.c | 1 +
> net/can/can_socketcan.c | 1 +
> net/netmap.c | 1 +
> net/tap-win32.c | 1 +
> net/tap.c | 1 +
> qemu-img.c | 1 +
> qom/cpu.c | 1 +
> replay/replay-internal.c | 1 +
> target/arm/helper-a64.c | 1 +
> target/arm/helper.c | 2 ++
> target/arm/kvm.c | 1 +
> target/arm/kvm64.c | 1 +
> target/arm/m_helper.c | 2 ++
> target/arm/psci.c | 2 ++
> target/i386/kvm.c | 1 +
> target/lm32/op_helper.c | 1 +
> target/mips/kvm.c | 1 +
> target/ppc/int_helper.c | 2 ++
> target/ppc/kvm.c | 1 +
> target/ppc/machine.c | 1 +
> target/ppc/mem_helper.c | 2 ++
> target/ppc/misc_helper.c | 2 ++
> target/ppc/mmu_helper.c | 2 ++
> target/ppc/translate.c | 1 +
> target/s390x/kvm.c | 1 +
> tcg/tcg-op-gvec.c | 1 +
> tests/test-bdrv-drain.c | 1 +
> tests/test-bdrv-graph-mod.c | 1 +
> tests/test-block-backend.c | 1 +
> tests/test-block-iothread.c | 1 +
> tests/test-image-locking.c | 1 +
> tests/test-replication.c | 1 +
> tests/test-throttle.c | 1 +
> ui/input-linux.c | 1 +
> ui/spice-core.c | 1 +
> ui/spice-display.c | 1 +
> ui/vnc.c | 1 +
> util/oslib-posix.c | 1 +
> ui/cocoa.m | 1 +
> 129 files changed, 130 insertions(+), 8 deletions(-)
It is interesting to see what access the main-loop.
Few pieces might be worth a refactor.
Certainly not this patch objective.
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>
next prev parent reply other threads:[~2019-08-12 10:56 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-12 5:23 [Qemu-devel] [PATCH v4 00/29] Tame a few "touch this, recompile the world" headers Markus Armbruster
2019-08-12 5:23 ` [Qemu-devel] [PATCH v4 01/29] include: Make headers more self-contained Markus Armbruster
2019-08-12 15:58 ` Philippe Mathieu-Daudé
2019-08-12 5:23 ` [Qemu-devel] [PATCH v4 02/29] Include generated QAPI headers less Markus Armbruster
2019-08-12 5:23 ` [Qemu-devel] [PATCH v4 03/29] qapi: Split error.json off common.json Markus Armbruster
2019-08-12 5:23 ` [Qemu-devel] [PATCH v4 04/29] memory: Fix type of IOMMUMemoryRegionClass member @parent_class Markus Armbruster
2019-08-12 5:23 ` [Qemu-devel] [PATCH v4 05/29] queue: Drop superfluous #include qemu/atomic.h Markus Armbruster
2019-08-12 5:23 ` [Qemu-devel] [PATCH v4 06/29] trace: Eliminate use of TARGET_FMT_plx Markus Armbruster
2019-08-12 5:23 ` [Qemu-devel] [PATCH v4 07/29] trace: Do not include qom/cpu.h into generated trace.h Markus Armbruster
2019-08-12 5:23 ` [Qemu-devel] [PATCH v4 08/29] Include sysemu/reset.h a lot less Markus Armbruster
2019-08-12 5:23 ` [Qemu-devel] [PATCH v4 09/29] Include migration/qemu-file-types.h " Markus Armbruster
2019-08-12 10:48 ` Philippe Mathieu-Daudé
2019-08-12 5:23 ` [Qemu-devel] [PATCH v4 10/29] ide: Include hw/ide/internal a bit less outside hw/ide/ Markus Armbruster
2019-08-12 5:23 ` [Qemu-devel] [PATCH v4 11/29] typedefs: Separate incomplete types and function types Markus Armbruster
2019-08-12 10:55 ` Alex Bennée
2019-08-12 13:37 ` Markus Armbruster
2019-08-13 5:43 ` Markus Armbruster
2019-08-13 10:44 ` Alex Bennée
2019-08-13 11:16 ` Markus Armbruster
2019-08-12 5:23 ` [Qemu-devel] [PATCH v4 12/29] Include hw/irq.h a lot less Markus Armbruster
2019-08-12 5:23 ` [Qemu-devel] [PATCH v4 13/29] Clean up inclusion of exec/cpu-common.h Markus Armbruster
2019-08-12 5:23 ` [Qemu-devel] [PATCH v4 14/29] migration: Move the VMStateDescription typedef to typedefs.h Markus Armbruster
2019-08-12 5:23 ` [Qemu-devel] [PATCH v4 15/29] Include migration/vmstate.h less Markus Armbruster
2019-08-12 15:59 ` Philippe Mathieu-Daudé
2019-08-12 5:23 ` [Qemu-devel] [PATCH v4 16/29] Include exec/memory.h slightly less Markus Armbruster
2019-08-12 5:23 ` [Qemu-devel] [PATCH v4 17/29] Include qom/object.h " Markus Armbruster
2019-08-12 5:23 ` [Qemu-devel] [PATCH v4 18/29] Include hw/hw.h exactly where needed Markus Armbruster
2019-08-12 16:01 ` Philippe Mathieu-Daudé
2019-08-12 5:23 ` [Qemu-devel] [PATCH v4 19/29] Include qemu/queue.h slightly less Markus Armbruster
2019-08-12 5:23 ` [Qemu-devel] [PATCH v4 20/29] Include qemu/main-loop.h less Markus Armbruster
2019-08-12 10:53 ` Alex Bennée
2019-08-12 10:55 ` Philippe Mathieu-Daudé [this message]
2019-08-12 5:23 ` [Qemu-devel] [PATCH v4 21/29] Include hw/qdev-properties.h less Markus Armbruster
2019-08-12 5:23 ` [Qemu-devel] [PATCH v4 22/29] Include hw/boards.h a bit less Markus Armbruster
2019-08-12 16:02 ` Philippe Mathieu-Daudé
2019-08-12 23:35 ` Eduardo Habkost
2019-08-12 5:23 ` [Qemu-devel] [PATCH v4 23/29] numa: Don't include hw/boards.h into sysemu/numa.h Markus Armbruster
2019-08-12 5:23 ` [Qemu-devel] [PATCH v4 24/29] Include sysemu/hostmem.h less Markus Armbruster
2019-08-12 5:23 ` [Qemu-devel] [PATCH v4 25/29] numa: Move remaining NUMA declarations from sysemu.h to numa.h Markus Armbruster
2019-08-12 5:23 ` [Qemu-devel] [PATCH v4 26/29] Clean up inclusion of sysemu/sysemu.h Markus Armbruster
2019-08-12 10:10 ` Alex Bennée
2019-08-12 5:23 ` [Qemu-devel] [PATCH v4 27/29] Include sysemu/sysemu.h a lot less Markus Armbruster
2019-08-12 10:09 ` Alex Bennée
2019-08-12 5:23 ` [Qemu-devel] [PATCH v4 28/29] sysemu: Move the VMChangeStateEntry typedef to qemu/typedefs.h Markus Armbruster
2019-08-12 10:08 ` Alex Bennée
2019-08-12 13:54 ` Markus Armbruster
2019-08-12 15:00 ` Alex Bennée
2019-08-12 16:06 ` Philippe Mathieu-Daudé
2019-08-12 5:23 ` [Qemu-devel] [PATCH v4 29/29] sysemu: Split sysemu/runstate.h off sysemu/sysemu.h Markus Armbruster
2019-08-12 10:04 ` Alex Bennée
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=802f5f60-1be0-5bb6-d224-dc566fa38747@redhat.com \
--to=philmd@redhat.com \
--cc=armbru@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).