From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DBEDBC433E0 for ; Mon, 8 Mar 2021 14:31:13 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5F02E6519C for ; Mon, 8 Mar 2021 14:31:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5F02E6519C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:33904 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lJGue-0002At-6v for qemu-devel@archiver.kernel.org; Mon, 08 Mar 2021 09:31:12 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:53876) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lJGJL-0000ag-DK for qemu-devel@nongnu.org; Mon, 08 Mar 2021 08:52:39 -0500 Received: from mx2.suse.de ([195.135.220.15]:40650) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lJGJJ-0001k1-Gi for qemu-devel@nongnu.org; Mon, 08 Mar 2021 08:52:39 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id E8D43AC54; Mon, 8 Mar 2021 13:52:35 +0000 (UTC) Subject: Re: [PATCH v26 00/20] i386 cleanup PART 2 To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , Paolo Bonzini , Richard Henderson , Eduardo Habkost , Peter Maydell , =?UTF-8?Q?Alex_Benn=c3=a9e?= References: <20210301085450.1732-1-cfontana@suse.de> <6230ef40-c0ec-875e-dbd3-46fb5925322e@amsat.org> From: Claudio Fontana Message-ID: <81208ea0-f389-14d0-c366-0579dee3376d@suse.de> Date: Mon, 8 Mar 2021 14:52:34 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <6230ef40-c0ec-875e-dbd3-46fb5925322e@amsat.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=195.135.220.15; envelope-from=cfontana@suse.de; helo=mx2.suse.de X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Laurent Vivier , Thomas Huth , Roman Bolshakov , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 3/8/21 2:27 PM, Philippe Mathieu-Daudé wrote: > Hi Claudio, > > On 3/8/21 1:57 PM, Claudio Fontana wrote: >> Hi, >> >> anything else for me to do here? >> >> The latest rebased state of this series should be always available here: >> >> https://gitlab.com/hw-claudio/qemu/-/tree/i386_cleanup_8 >> >> When it comes to the ARM cleanup series, >> I would like to have the tests pass for ARM, before doing even more changes, could you help me there Philippe? >> >> Maybe applying some of your changes on top would fix the failures? I tried, for example with the arm-cpu-features ones, but it didn't work for me.. > > TBH I wrote these patches during my personal spare time and this > became a real Pandora box that drained too much energy. I prefer > to step back and focus on finishing smaller tasks before burning > out. That said I appreciate your effort and am interested in > following / reviewing your work. > > Regards, > > Phil. > Thanks Philippe for sharing this, and I agree completely, it is very draining. The effort of making tests happy that run in artificial environments in particular often feels to me as too disconnected from actually ensuring that there is no real run time regression. qtest_enabled() (implicitly, or explicitly via open-ended else statements) is another painful variable to keep in mind in cpu and machine code, so it is not helpful in my view. I'll try to push more to get the tests running again, if you have any comment or idea, feel free to just point me in the right direction, that is very valuable to me, even without working code. Currently I am struggling with arm-cpu-features and other tests (device-introspect-test, qom-test, test-hmp). I'll publish arm_cleanup_v5 soon, Thanks a lot, Claudio