From: Thomas Huth <thuth@redhat.com>
To: Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, pbonzini@redhat.com,
marcandre.lureau@redhat.com, michael.roth@amd.com
Subject: Re: [PATCH] qom: Fix default values in help
Date: Wed, 24 Mar 2021 10:00:56 +0100 [thread overview]
Message-ID: <816e56bb-54d6-bafc-764d-983a1620941f@redhat.com> (raw)
In-Reply-To: <20210324084130.3986072-1-armbru@redhat.com>
On 24/03/2021 09.41, Markus Armbruster wrote:
> Output of default values in device help is broken:
>
> $ ./qemu-system-x86_64 -S -display none -monitor stdio
> QEMU 5.2.50 monitor - type 'help' for more information
> (qemu) device_add pvpanic,help
> pvpanic options:
> events=<uint8> - (default: (null))
> ioport=<uint16> - (default: (null))
> pvpanic[0]=<child<qemu:memory-region>>
>
> The "(null)" is glibc printing a null pointer. Other systems crash
> instead. Having a help request crash a running VM can really spoil
> your day.
>
> Root cause is a botched replacement of qstring_free() by
> g_string_free(): to get the string back, we need to pass true to the
> former, but false to the latter. Fix the argument.
>
> Fixes: eab3a4678b07267c39e7290a6e9e7690b1d2a521
> Reported-by: Thomas Huth <thuth@redhat.com>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
> qom/object_interfaces.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/qom/object_interfaces.c b/qom/object_interfaces.c
> index c3324b0f86..bd8a947a63 100644
> --- a/qom/object_interfaces.c
> +++ b/qom/object_interfaces.c
> @@ -159,7 +159,7 @@ char *object_property_help(const char *name, const char *type,
> }
> if (defval) {
> g_autofree char *def_json = g_string_free(qobject_to_json(defval),
> - true);
> + false);
> g_string_append_printf(str, " (default: %s)", def_json);
> }
>
>
Reviewed-by: Thomas Huth <thuth@redhat.com>
prev parent reply other threads:[~2021-03-24 9:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-24 8:41 [PATCH] qom: Fix default values in help Markus Armbruster
2021-03-24 8:48 ` Marc-André Lureau
2021-03-24 9:00 ` Thomas Huth [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=816e56bb-54d6-bafc-764d-983a1620941f@redhat.com \
--to=thuth@redhat.com \
--cc=armbru@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=michael.roth@amd.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).