From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 64FD4C433EF for ; Fri, 10 Jun 2022 15:44:53 +0000 (UTC) Received: from localhost ([::1]:33174 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nzgoe-0002dI-FU for qemu-devel@archiver.kernel.org; Fri, 10 Jun 2022 11:44:52 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60692) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nzgnV-0001kc-9H; Fri, 10 Jun 2022 11:43:41 -0400 Received: from mail.ilande.co.uk ([2001:41c9:1:41f::167]:50338) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nzgnT-0003VY-BC; Fri, 10 Jun 2022 11:43:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=ilande.co.uk; s=20220518; h=Subject:Content-Transfer-Encoding:Content-Type: In-Reply-To:From:References:To:MIME-Version:Date:Message-ID:Sender:Reply-To: Cc:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=k7WAWElMUSutZpU5tB34oNODW5F74EXaNTjqoxeB6h8=; b=P07XXJ09P6+YJt5gJrYDwzG1PQ +GXQ5LM1WT2r7uy2pyphlrhgQW5zYBDzsMOTbv5/um0RwVLhDrampAKVDAUamD3jn3FoubSjjl6SO R942cZ8fMmpkR3godqzuRqQUMWXaRmSq5P+koyPS2fGHf2+/K+fFj3gURg4ePay69DnuM47ecWU/A ZAm8eGUO7/GfUP/7mBnFXPntt33XE6mIwtspHzp/mAjbIo3nTwNwGr6+xLMO5G3PaY8PR1puJpnTn 1jxXXsyUdVlm4dyytVKso+UElS8+4j6wOKjPq6k22MCl0uSYHOM7MvS6LTog7hjWdr2dsfPD66NdC om/DWkrUFoFps+VVZCncYtNgfS9BcCIcc5DBI0qhRzqEEyD9qR5C0vbv63C+WHyxpQqdwzYVFlEl+ Zd4wLA/Bj5xFaQkGOsLqi13tvptvyi4ZtDiSION7QZJW/xXNIi5ZV3h1jmyi8SeygiWZz0NwkVXse asphrDQqkqUNByUv6GBky+YCQDkU+JwTks+gkU1C3g5FczHACWG4GeX1Zt+ZXmNz8VlUYvXHhZxGK O21b96oeRR3XpJMgUQ8rY+QIwJX9132c2/3Iov4CObDKn+702Eg4nNUWg6ZIG2aBGuUM065GTnte3 OzRDjl/yuh5SLwLNJAxEsfHvofV7ghp6BQ7GQcImE=; Received: from [2a00:23c4:8ba4:e500:b82f:56f9:46d7:80ab] by mail.ilande.co.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1nzgmB-0006gG-7v; Fri, 10 Jun 2022 16:42:23 +0100 Message-ID: <82f46299-34cb-463e-5177-a5c350242421@ilande.co.uk> Date: Fri, 10 Jun 2022 16:43:22 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Content-Language: en-US To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , richard.henderson@linaro.org, deller@gmx.de, mst@redhat.com, pbonzini@redhat.com, peter.maydell@linaro.org, hpoussin@reactos.org, aleksandar.rikalo@syrmia.com, jiaxun.yang@flygoat.com, qemu-arm@nongnu.org, qemu-devel@nongnu.org References: <20220522181836.864-1-mark.cave-ayland@ilande.co.uk> <9608d355-8582-69e0-50ee-de48e0ef561f@ilande.co.uk> From: Mark Cave-Ayland In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: 2a00:23c4:8ba4:e500:b82f:56f9:46d7:80ab X-SA-Exim-Mail-From: mark.cave-ayland@ilande.co.uk Subject: Re: [PATCH 00/50] PS2 device QOMification - part 1 X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on mail.ilande.co.uk) Received-SPF: pass client-ip=2001:41c9:1:41f::167; envelope-from=mark.cave-ayland@ilande.co.uk; helo=mail.ilande.co.uk X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 10/06/2022 16:35, Philippe Mathieu-Daudé wrote: > On 7/6/22 17:54, Mark Cave-Ayland wrote: >> On 22/05/2022 19:17, Mark Cave-Ayland wrote: >> >>> This series came about when looking at improving the LASI PS2 device for >>> the HPPA machine: there were improvements that I was keen to make, but >>> was restricted because the PS2 device(s) weren't QOMified. >>> >>> Trying to do everything in a single patchset would be a very large series >>> indeed, so here is part 1 of the series which does the basic QOMification >>> process and consists of: >>> >>> - QOMifying the basic PS2, PS2 keyboard and PS2 mouse types >>> >>> - Moving any functionality that exists in a global device init function >>>    directly into the relevant device, so that all device behaviour is >>>    configured using qdev properties and QOM >>> >>> - Introducing a new I8042_MMIO type for use by the MIPS magnum machine >>> >>> - Switch all PS2 devices to use qdev gpios for IRQs instead of using the >>>    update_irq() callback function along with the update_arg opaque >>> >>> Once this work has been done, a follow-up part 2 series will finish the >>> remainder of the work which involves i) improving the QOM object model >>> now QOMification is complete and ii) removing the legacy global device >>> init functions for PS2 and related devices. >>> >>> Testing for this series has comprised of booting a machine with each type >>> of PS2 device and confirming that i) the machine responds to keypresses >>> when using a graphical console and ii) completing a successful migration >>> from a machine with this series applies back to a machine running latest >>> git master. The test machines I used were: >>> >>> - qemu-system-x86_64 -M pc for the I8042 device >>> - qemu-system-hppa for the LASIPS2 device >>> - qemu-system-arm -M versatilepb for the PL050 device >>> - qemu-system-mips64el -M magnum for the I8042_MMIO device >>> >>> Finally the QOM tree changes caused by QOMification of the PS2 devices >>> trigger a failure due to a bug in the bios-tables-test qtest for subtest >>> /x86_64/acpi/q35/viot. This can be fixed by applying the series at >>> https://lists.gnu.org/archive/html/qemu-devel/2022-05/msg04266.html >>> "hw/acpi/viot: generate stable VIOT ACPI tables" first. >>> >>> Signed-off-by: Mark Cave-Ayland >>> >>> >>> Mark Cave-Ayland (50): >>>    ps2: checkpatch fixes >>>    ps2: QOMify PS2State >>>    ps2: QOMify PS2KbdState >>>    ps2: QOMify PS2MouseState >>>    ps2: move QOM type definitions from ps2.c to ps2.h >>>    ps2: improve function prototypes in ps2.c and ps2.h >>>    ps2: introduce PS2DeviceClass >>>    ps2: implement ps2_reset() for the PS2_DEVICE QOM type based upon >>>      ps2_common_reset() >>>    ps2: remove duplicate setting of scancode_set in ps2_kbd_init() >>>    ps2: implement ps2_kbd_realize() and use it to register >>>      ps2_keyboard_handler >>>    ps2: implement ps2_mouse_realize() and use it to register >>>      ps2_mouse_handler >>>    ps2: don't use vmstate_register() in ps2_kbd_init() >>>    ps2: don't use vmstate_register() in ps2_mouse_init() >>>    pl050: checkpatch fixes >>>    pl050: split pl050_update_irq() into separate pl050_set_irq() and >>>      pl050_update_irq() functions >>>    lasips2: spacing fixes >>>    lasips2: rename ps2dev_update_irq() to lasips2_port_set_irq() >>>    pckbd: checkpatch fixes >>>    pckbd: move KBDState from pckbd.c to i8042.h >>>    pckbd: move ISAKBDState from pckbd.c to i8042.h > >> Ping? I've had an R-B from Phil for patches 1-20 along with a Tested-by from Helge >> for the entire series, but that still leaves the last 30 patches unreviewed... > > I'm queuing patches 1-20 (fixing the typo in patch 9) via mips-next, > and will review v2. Hi Phil, I've also got a local fix that needs to be squashed into one of these early patches, so could you drop this series for now? As well as this extra fix (thanks Asan!) it will make it easier to rebase and update the series according to Peter's review comments. ATB, Mark.