From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 37B06C43603 for ; Fri, 13 Dec 2019 21:25:53 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AB3ED24671 for ; Fri, 13 Dec 2019 21:25:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="I2iH/ONg" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AB3ED24671 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:50378 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ifmny-0005h6-4C for qemu-devel@archiver.kernel.org; Fri, 13 Dec 2019 10:24:34 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:39446) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ifmnA-00053G-Pp for qemu-devel@nongnu.org; Fri, 13 Dec 2019 10:23:45 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ifmn6-00072n-Vv for qemu-devel@nongnu.org; Fri, 13 Dec 2019 10:23:42 -0500 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:57099 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ifmn6-00071H-SA for qemu-devel@nongnu.org; Fri, 13 Dec 2019 10:23:40 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1576250620; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MeK51fxNFq5+BdirxnvGrOlWweZR5gMFavqnBcWMREA=; b=I2iH/ONgNC+H8G3KTgbIMdo+/S38Hwugs3d562aBL51Yh2Mz78FLdSHLzKMD+2QAngTa1Z hoUbUy9mF4XgL51sKtclMbSQk0L+yQHpU/9pWf6X98iyerh4H2d+PYgoy2MsMCCc+GBdFb jJo1MRLQU/msOzb1ZbymoDwQmIewiAc= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-158-6hpohohwOXOslwRvMcvq3A-1; Fri, 13 Dec 2019 10:23:37 -0500 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 5A20B800D48; Fri, 13 Dec 2019 15:23:36 +0000 (UTC) Received: from [10.3.116.171] (ovpn-116-171.phx2.redhat.com [10.3.116.171]) by smtp.corp.redhat.com (Postfix) with ESMTPS id BDB2960BF3; Fri, 13 Dec 2019 15:23:35 +0000 (UTC) Subject: Re: [PATCH RFC] qapi: Allow getting flat output from 'query-named-block-nodes' To: Peter Krempa , qemu-devel@nongnu.org References: <42dae98e1f6a9f444f48a20192f45195337824f0.1576246045.git.pkrempa@redhat.com> From: Eric Blake Organization: Red Hat, Inc. Message-ID: <836c1a18-b67d-0426-2137-8f464e4e5c9b@redhat.com> Date: Fri, 13 Dec 2019 09:23:35 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: <42dae98e1f6a9f444f48a20192f45195337824f0.1576246045.git.pkrempa@redhat.com> Content-Language: en-US X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-MC-Unique: 6hpohohwOXOslwRvMcvq3A-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 205.139.110.120 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Markus Armbruster , qemu-block@nongnu.org, Max Reitz Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 12/13/19 8:11 AM, Peter Krempa wrote: > When a management application manages node names there's no reason to > recurse into backing images in the output of query-named-block-nodes. > > Add a parameter to the command which will return just the top level > structs. At one point, Kevin was working on a saner command that tried to cut out on more than just the redundant nesting. But this is certainly a quick-and-easy fix to ease libvirt's use of the existing command, while we decide whether to add a saner new command. > > Signed-off-by: Peter Krempa > --- > block.c | 5 +++-- > block/qapi.c | 10 ++++++++-- > blockdev.c | 12 ++++++++++-- > include/block/block.h | 2 +- > include/block/qapi.h | 4 +++- > monitor/hmp-cmds.c | 2 +- > qapi/block-core.json | 6 +++++- > 7 files changed, 31 insertions(+), 10 deletions(-) > > +++ b/blockdev.c > @@ -3707,9 +3707,17 @@ void qmp_drive_backup(DriveBackup *arg, Error **errp) > } > } > > -BlockDeviceInfoList *qmp_query_named_block_nodes(Error **errp) > +BlockDeviceInfoList *qmp_query_named_block_nodes(bool has_flat, > + bool flat, > + Error **errp) > { > - return bdrv_named_nodes_list(errp); > + bool return_flat = false; > + > + if (has_flat) { > + return_flat = flat; > + } This could be shortened as 'bool return_flat = has_flat && flat;', but that's not essential. > + > + return bdrv_named_nodes_list(return_flat, errp); > } > Reviewed-by: Eric Blake -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org