From: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
To: Eric Blake <eblake@redhat.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Cc: "nsoffer@redhat.com" <nsoffer@redhat.com>,
"qemu-block@nongnu.org" <qemu-block@nongnu.org>
Subject: Re: [PATCH 0/2] enhance iotest 223 coverage
Date: Tue, 24 Sep 2019 19:26:33 +0000 [thread overview]
Message-ID: <8463a76e-74d7-7785-79f4-563cd78182a5@virtuozzo.com> (raw)
In-Reply-To: <20190924143522.22902-1-eblake@redhat.com>
24.09.2019 17:35, Eric Blake wrote:
> Commit 506902c6 dropped non-iothread coverage in order to test iothread,
> better is to run things twice. In doing this, I found it easier to
> edit the test when the log shows what commands were triggering various
> responses.
Did you consider adding -iothread to tests/qemu-iotests/check instead, to be
able to run any (or some) tests with or without iothread?
>
> Eric Blake (2):
> tests: Make iotest 223 easier to edit
> tests: More iotest 223 improvements
>
> tests/qemu-iotests/223 | 114 ++++++++++++++++++++++++------
> tests/qemu-iotests/223.out | 138 +++++++++++++++++++++++++++++++++++++
> 2 files changed, 231 insertions(+), 21 deletions(-)
>
--
Best regards,
Vladimir
next prev parent reply other threads:[~2019-09-24 19:28 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-24 14:35 [PATCH 0/2] enhance iotest 223 coverage Eric Blake
2019-09-24 14:35 ` [PATCH 1/2] tests: Make iotest 223 easier to edit Eric Blake
2019-10-07 12:05 ` Max Reitz
2019-10-07 20:06 ` Eric Blake
2019-10-08 9:04 ` Max Reitz
2019-09-24 14:35 ` [PATCH 2/2] tests: More iotest 223 improvements Eric Blake
2019-10-07 12:14 ` Max Reitz
2019-09-24 19:26 ` Vladimir Sementsov-Ogievskiy [this message]
2019-09-24 19:51 ` [PATCH 0/2] enhance iotest 223 coverage Eric Blake
2019-10-07 11:44 ` Max Reitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8463a76e-74d7-7785-79f4-563cd78182a5@virtuozzo.com \
--to=vsementsov@virtuozzo.com \
--cc=eblake@redhat.com \
--cc=nsoffer@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).