From: Laszlo Ersek <lersek@redhat.com>
To: Gerd Hoffmann <kraxel@redhat.com>, seabios@seabios.org
Cc: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Subject: Re: [PATCH] ahci: zero-initialize port struct
Date: Wed, 13 Nov 2019 10:35:03 +0100 [thread overview]
Message-ID: <84d3a1aa-bbb2-d831-0abc-fe1169f8a860@redhat.com> (raw)
In-Reply-To: <20191113091809.31365-1-kraxel@redhat.com>
On 11/13/19 10:18, Gerd Hoffmann wrote:
> Specifically port->driver.lchs needs clearing, otherwise seabios will
s/driver/drive/
> try interpret whatever random crap happens to be there as disk geometry,
> which may or may not break boot depending on how lucky you are.
>
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
> src/hw/ahci.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/src/hw/ahci.c b/src/hw/ahci.c
> index 97a072a1ca81..d45b4307ec68 100644
> --- a/src/hw/ahci.c
> +++ b/src/hw/ahci.c
> @@ -345,6 +345,7 @@ ahci_port_alloc(struct ahci_ctrl_s *ctrl, u32 pnr)
> warn_noalloc();
> return NULL;
> }
> + memset(port, 0, sizeof(*port));
> port->pnr = pnr;
> port->ctrl = ctrl;
> port->list = memalign_tmp(1024, 1024);
>
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
next prev parent reply other threads:[~2019-11-13 9:35 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-13 9:18 [PATCH] ahci: zero-initialize port struct Gerd Hoffmann
2019-11-13 9:35 ` Laszlo Ersek [this message]
2019-11-13 14:00 ` [SeaBIOS] " Gerd Hoffmann
2019-11-13 15:03 ` Sam Eiderman
2019-11-13 15:18 ` Sam Eiderman
2019-11-13 15:46 ` Sam Eiderman
2019-11-13 16:12 ` Philippe Mathieu-Daudé
2019-11-13 16:35 ` Sam Eiderman
2019-11-13 16:46 ` Sam Eiderman
2019-11-14 7:20 ` Gerd Hoffmann
2019-11-14 9:08 ` Sam Eiderman
2019-11-15 6:54 ` Gerd Hoffmann
2019-11-15 11:35 ` Gerd Hoffmann
2019-11-15 11:50 ` Sam Eiderman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=84d3a1aa-bbb2-d831-0abc-fe1169f8a860@redhat.com \
--to=lersek@redhat.com \
--cc=kraxel@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=seabios@seabios.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).