From: "Andrew Jeffery" <andrew@aj.id.au>
To: no-reply@patchew.org, qemu-devel@nongnu.org
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
qemu-arm@nongnu.org, "Joel Stanley" <joel@jms.id.au>,
"Cédric Le Goater" <clg@kaod.org>
Subject: Re: [Qemu-devel] [PATCH] target-arm: Make the counter tick relative to cntfrq
Date: Fri, 09 Aug 2019 14:27:08 +0930 [thread overview]
Message-ID: <84d76bb7-b5b5-488b-ac14-db0e1c009f7d@www.fastmail.com> (raw)
In-Reply-To: <156532351253.12874.1201096794967354035@b08f24806b7e>
On Fri, 9 Aug 2019, at 13:36, no-reply@patchew.org wrote:
> Patchew URL: https://patchew.org/QEMU/20190809031321.14760-1-andrew@aj.id.au/
>
>
>
> Hi,
>
> This series failed build test on s390x host. Please find the details below.
>
> === TEST SCRIPT BEGIN ===
> #!/bin/bash
> # Testing script will be invoked under the git checkout with
> # HEAD pointing to a commit that has the patches applied on top of "base"
> # branch
> set -e
>
> echo
> echo "=== ENV ==="
> env
>
> echo
> echo "=== PACKAGES ==="
> rpm -qa
>
> echo
> echo "=== UNAME ==="
> uname -a
>
> CC=$HOME/bin/cc
> INSTALL=$PWD/install
> BUILD=$PWD/build
> mkdir -p $BUILD $INSTALL
> SRC=$PWD
> cd $BUILD
> $SRC/configure --cc=$CC --prefix=$INSTALL
> make -j4
> # XXX: we need reliable clean up
> # make check -j4 V=1
> make install
> === TEST SCRIPT END ===
>
> CC aarch64_be-linux-user/target/arm/arm-semi.o
> CC aarch64_be-linux-user/target/arm/helper.o
> /var/tmp/patchew-tester-tmp-hkd7ua1n/src/target/arm/helper.c: In
> function ‘gt_virt_cnt_read’:
> /var/tmp/patchew-tester-tmp-hkd7ua1n/src/target/arm/helper.c:2921:12:
> error: implicit declaration of function ‘gt_calc_tick’
> [-Werror=implicit-function-declaration]
> 2921 | return gt_calc_tick(env, cpu_get_clock());
> | ^~~~~~~~~~~~
> /var/tmp/patchew-tester-tmp-hkd7ua1n/src/target/arm/helper.c:2921:12:
> error: nested extern declaration of ‘gt_calc_tick’
> [-Werror=nested-externs]
> cc1: all warnings being treated as errors
> make[1]: *** [/var/tmp/patchew-tester-tmp-hkd7ua1n/src/rules.mak:69:
> target/arm/helper.o] Error 1
> make: *** [Makefile:472: aarch64_be-linux-user/all] Error 2
>
Ah, I missed that I put the implementation inside the
#ifndef CONFIG_USER_ONLY` block. Maybe we can just not do the scaling
for userspace anyway?
Andrew
prev parent reply other threads:[~2019-08-09 4:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-09 3:13 [Qemu-devel] [PATCH] target-arm: Make the counter tick relative to cntfrq Andrew Jeffery
2019-08-09 4:05 ` no-reply
2019-08-09 4:57 ` Andrew Jeffery [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=84d76bb7-b5b5-488b-ac14-db0e1c009f7d@www.fastmail.com \
--to=andrew@aj.id.au \
--cc=clg@kaod.org \
--cc=joel@jms.id.au \
--cc=no-reply@patchew.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).