From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Doug Evans <dje@google.com>, qemu-devel@nongnu.org
Cc: "Samuel Thibault" <samuel.thibault@ens-lyon.org>,
"Daniel P . Berrangé" <berrange@redhat.com>
Subject: Re: [PATCH v5 1/5] slirp: Advance libslirp submodule to add ipv6 host-forward support
Date: Sat, 20 Feb 2021 01:20:36 +0100 [thread overview]
Message-ID: <858a59f8-a97e-3d9b-3e19-16b73f93ca4c@redhat.com> (raw)
In-Reply-To: <20210220001322.1311139-2-dje@google.com>
Hi Doug,
On 2/20/21 1:13 AM, Doug Evans via wrote:
When updating submodules, the commit description is a good
good place to include the output of:
$ git shortlog 8f43a99..26ae658
See for example QEMU commit f350d78f102 ("Update SLOF").
Anyhow up to the maintainer merging your patch.
> Signed-off-by: Doug Evans <dje@google.com>
> ---
>
> Changes from v4:
> NOTE TO REVIEWERS: I need some hand-holding to know what The Right
> way to submit this particular patch is.
>
> - no change
>
> Changes from v3:
> - pick up latest libslirp patch to reject ipv6 addr-any for guest address
> - libslirp currently only provides a stateless DHCPv6 server, which means
> it can't know in advance what the guest's IP address is, and thus
> cannot do the "addr-any -> guest ip address" translation that is done
> for ipv4
>
> Changes from v2:
> - this patch is new in v3, split out from v2
>
> slirp | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/slirp b/slirp
> index 8f43a99191..26ae658a83 160000
> --- a/slirp
> +++ b/slirp
> @@ -1 +1 @@
> -Subproject commit 8f43a99191afb47ca3f3c6972f6306209f367ece
> +Subproject commit 26ae658a83eeca16780cf5615c8247cbb151c3fa
>
next prev parent reply other threads:[~2021-02-20 0:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-20 0:13 [PATCH v5 0/5] Add support for ipv6 host forwarding Doug Evans via
2021-02-20 0:13 ` [PATCH v5 1/5] slirp: Advance libslirp submodule to add ipv6 host-forward support Doug Evans via
2021-02-20 0:20 ` Philippe Mathieu-Daudé [this message]
2021-02-23 20:18 ` Doug Evans
2021-02-26 12:18 ` Marc-André Lureau
2021-02-20 0:13 ` [PATCH v5 2/5] util/qemu-sockets.c: Split host:port parsing out of inet_parse Doug Evans via
2021-02-20 0:13 ` [PATCH v5 3/5] inet_parse_host_and_addr: Recognize []:port (empty ipv6 address) Doug Evans via
2021-02-20 0:13 ` [PATCH v5 4/5] net/slirp.c: Refactor address parsing Doug Evans via
2021-02-20 0:13 ` [PATCH v5 5/5] net: Extend host forwarding to support IPv6 Doug Evans via
2021-02-20 0:27 ` [PATCH v5 0/5] Add support for ipv6 host forwarding no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=858a59f8-a97e-3d9b-3e19-16b73f93ca4c@redhat.com \
--to=philmd@redhat.com \
--cc=berrange@redhat.com \
--cc=dje@google.com \
--cc=qemu-devel@nongnu.org \
--cc=samuel.thibault@ens-lyon.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).