From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 47BA9C4360C for ; Tue, 8 Oct 2019 12:02:20 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1C546206C2 for ; Tue, 8 Oct 2019 12:02:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1C546206C2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:54598 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iHoC3-00012m-6F for qemu-devel@archiver.kernel.org; Tue, 08 Oct 2019 08:02:19 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54762) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iHoAw-0000Ir-Vy for qemu-devel@nongnu.org; Tue, 08 Oct 2019 08:01:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iHoAv-0003oZ-Mm for qemu-devel@nongnu.org; Tue, 08 Oct 2019 08:01:10 -0400 Received: from mx1.redhat.com ([209.132.183.28]:45366) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iHoAo-0003iT-0v; Tue, 08 Oct 2019 08:01:02 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 27A4B307CDE7; Tue, 8 Oct 2019 12:00:54 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.36.118.123]) by smtp.corp.redhat.com (Postfix) with ESMTPS id ACC4219C68; Tue, 8 Oct 2019 11:59:58 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 6A203113864A; Tue, 8 Oct 2019 13:59:51 +0200 (CEST) From: Markus Armbruster To: Vladimir Sementsov-Ogievskiy Subject: Re: [PATCH v4 00/31] error: auto propagated local_err References: <20191001155319.8066-1-vsementsov@virtuozzo.com> <87eeznn185.fsf@dusky.pond.sub.org> <20191008113932.18eb4c1d@bahia.lan> <7567d46b-f51c-d459-fd54-7841637d0666@virtuozzo.com> Date: Tue, 08 Oct 2019 13:59:51 +0200 In-Reply-To: <7567d46b-f51c-d459-fd54-7841637d0666@virtuozzo.com> (Vladimir Sementsov-Ogievskiy's message of "Tue, 8 Oct 2019 10:09:42 +0000") Message-ID: <871rvnla6g.fsf@dusky.pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.49]); Tue, 08 Oct 2019 12:00:54 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "fam@euphon.net" , "pburton@wavecomp.com" , "peter.maydell@linaro.org" , "codyprime@gmail.com" , "jasowang@redhat.com" , "mark.cave-ayland@ilande.co.uk" , "qemu-devel@nongnu.org" , Markus Armbruster , "kraxel@redhat.com" , "sundeep.lkml@gmail.com" , "qemu-block@nongnu.org" , "quintela@redhat.com" , "arikalo@wavecomp.com" , "mst@redhat.com" , "mdroth@linux.vnet.ibm.com" , "pasic@linux.ibm.com" , "borntraeger@de.ibm.com" , "joel@jms.id.au" , "marcandre.lureau@redhat.com" , "rth@twiddle.net" , "farman@linux.ibm.com" , "ehabkost@redhat.com" , "sw@weilnetz.de" , Greg Kurz , "yuval.shaia@oracle.com" , "dgilbert@redhat.com" , "alex.williamson@redhat.com" , "qemu-arm@nongnu.org" , "clg@kaod.org" , "stefanha@redhat.com" , "david@redhat.com" , "jsnow@redhat.com" , "david@gibson.dropbear.id.au" , "kwolf@redhat.com" , "integration@gluster.org" , "berrange@redhat.com" , "andrew@aj.id.au" , "cohuck@redhat.com" , "qemu-s390x@nongnu.org" , "mreitz@redhat.com" , "qemu-ppc@nongnu.org" , "pbonzini@redhat.com" Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Vladimir Sementsov-Ogievskiy writes: > 08.10.2019 12:39, Greg Kurz wrote: >> On Tue, 8 Oct 2019 08:41:08 +0000 >> Vladimir Sementsov-Ogievskiy wrote: >> >>> 08.10.2019 10:30, Markus Armbruster wrote: >>>> Vladimir Sementsov-Ogievskiy writes: >>>> >>>>> Hi all! >>>>> >>>>> Here is a proposal of auto propagation for local_err, to not call >>>>> error_propagate on every exit point, when we deal with local_err. >>>>> >>>>> There are also two issues with errp: >>>>> >>>>> 1. error_fatal & error_append_hint/error_prepend: user can't see this >>>>> additional info, because exit() happens in error_setg earlier than info >>>>> is added. [Reported by Greg Kurz] >>>> >>>> How is this series related to Greg's "[PATCH 00/17] Fix usage of >>>> error_append_hint()"? Do we need both? >>> >>> These series is a substitution for Greg's. Still, there are problems with >>> automation, which Greg pointed in 21/31, and I don't know what to do next. >>> >>> May be, just continue to review patches and fix them by hand. May be try to >>> improve automation... >>> >> >> The feeling I have after working on my series is that the lines that deal >> with errors are mixed up with the functional code in a variety of ways. >> That makes it very difficult if not impossible to come with code patterns >> suitable for a 100% automated solution IMHO. >> >> My questioning is more around the semantics of error_fatal actually. What >> does passing &error_fatal gives us over passing &local_err and calling >> error_report_err()+exit(), apart from breaking error_append_hint() and >> error_prepend() ? > > As I understand, the only benefit is one line instead of four: Brevity matters when it comes to error handling. > func(..., &error_fatal); > > instead of > > func(..., &local_err); > if (local_err) { error_report_err(local_err); > exit(1); > } [...]