From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57DF7C47082 for ; Thu, 3 Jun 2021 16:34:20 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0C65D613EE for ; Thu, 3 Jun 2021 16:34:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0C65D613EE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:52168 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1loqIV-0006bc-5t for qemu-devel@archiver.kernel.org; Thu, 03 Jun 2021 12:34:19 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42926) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1loqHe-0004Nx-Nd for qemu-devel@nongnu.org; Thu, 03 Jun 2021 12:33:26 -0400 Received: from mail-wr1-x432.google.com ([2a00:1450:4864:20::432]:44757) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1loqHc-0002wO-VI for qemu-devel@nongnu.org; Thu, 03 Jun 2021 12:33:26 -0400 Received: by mail-wr1-x432.google.com with SMTP id f2so6467404wri.11 for ; Thu, 03 Jun 2021 09:33:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=references:user-agent:from:to:cc:subject:date:in-reply-to :message-id:mime-version:content-transfer-encoding; bh=W6phH5oIaCHyi6EmJ6lWerhw4w+vsTMNumYj3h+9nxs=; b=IqgB0IvY6Go/b4p6mBZOzci0hhlJtvxCUwqNhdacCAUSi9ubERLeH1gY5AfH76JuQB UTgpH3jGSbkkppbC4uN8ssVCMsUT0nJwtQopDmOernD1KthJC4Kbi/qDzm5QnQQv+hSd UxRgcBsO/o0F23+h3RbXbz7gxsPQhJyTIYu7EfYNcOHen8IdD0T2sfrg2mVGAi7+sK+3 QhdLfm81lfw1T9g32wExueFhlwbBy5kFaSRUqaM5hOTcMC6Yr2TZ4ztt1e9lZBSgko1f nXpGBMBXR/FohyRzc0Uto6IyrQC6va3hgXSEeC+yQl+QZx1ftUX6i/ccZ1xDYuLjwDQA FBNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject:date :in-reply-to:message-id:mime-version:content-transfer-encoding; bh=W6phH5oIaCHyi6EmJ6lWerhw4w+vsTMNumYj3h+9nxs=; b=QflHLx8UBArqRoK5VJmjtIczjaDdQ8gGZEJjwo40BojpjztdtnrIjLaCRH/VRbBHgQ C9uwHhu6WkEF1n1ICH5lNXjnG5Ps7xuiwXhiFpcgAEJqZnFKYHYr2UQzMxsJ3Yf/GyhZ MO8SvMbnWNTLikaGNufC4zxkiSTWZ/cCoUhk+IibehO+z+Hfcv5gecX3dmMX4POJfl+R p6rbNk426ZvJ+f9qXWqLvFlT4ENTaIcFzbILbHw+HmNe141hbyEoco+xfMliB4xjn8Ip gESRIbpZT9b9lSXXrKuBJirVr2b5DtDba1iZqHxAcBCOVVHnkWo0RCGGIjwwSs6IQ7vW HwUQ== X-Gm-Message-State: AOAM532ygu4ccqrrO5DJuw0hnl8xrQXLVta8zEv8GCDqfJ2rc7t4dE9o yJ2xwCP4bc2s1LpcHG2m5nCkQQ== X-Google-Smtp-Source: ABdhPJzpK9bBLcglF0Q49/5xjBySCrkeIbR06TOThVUz0tG9VBlPDZ6MaW+3rvyLIwI77Vup3w50sQ== X-Received: by 2002:adf:f708:: with SMTP id r8mr811721wrp.159.1622738003226; Thu, 03 Jun 2021 09:33:23 -0700 (PDT) Received: from zen.linaroharston ([51.148.130.216]) by smtp.gmail.com with ESMTPSA id x11sm3965813wru.87.2021.06.03.09.33.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Jun 2021 09:33:22 -0700 (PDT) Received: from zen (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 73BCD1FF7E; Thu, 3 Jun 2021 17:33:21 +0100 (BST) References: <20210525164541.17985-1-alex.bennee@linaro.org> User-agent: mu4e 1.5.13; emacs 28.0.50 From: Alex =?utf-8?Q?Benn=C3=A9e?= To: qemu-devel@nongnu.org Subject: Re: [RFC PATCH] accel/tcg: change default codegen buffer size for i386-softmmu Date: Thu, 03 Jun 2021 17:33:03 +0100 In-reply-to: <20210525164541.17985-1-alex.bennee@linaro.org> Message-ID: <8735ty9acu.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2a00:1450:4864:20::432; envelope-from=alex.bennee@linaro.org; helo=mail-wr1-x432.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Richard Henderson , Thomas Huth , 1896298@bugs.launchpad.net, Alex =?utf-8?Q?Benn=C3=A9e?= , Paolo Bonzini Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Alex Benn=C3=A9e writes: > There are two justifications for making this change. The first is that > i386 emulation is typically for smaller machines where having a 1gb of > generated code is overkill for basic emulation. The second is the > propensity of self-modifying code (c.f. Doom/edit) utilised on i386 > systems can trigger a rapid growth in invalidated and re-translated > buffers. This is seen in bug #283. Execution is still inefficient but > at least the host memory isn't so aggressively used up. > > That said it's still really just a sticking plaster for user > convenience. ping? --=20 Alex Benn=C3=A9e From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6258C47098 for ; Thu, 3 Jun 2021 16:55:26 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 12794613F1 for ; Thu, 3 Jun 2021 16:55:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 12794613F1 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bugs.launchpad.net Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:49044 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1loqcv-0004jw-3J for qemu-devel@archiver.kernel.org; Thu, 03 Jun 2021 12:55:25 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47098) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1loqUV-0007w4-AU for qemu-devel@nongnu.org; Thu, 03 Jun 2021 12:46:44 -0400 Received: from indium.canonical.com ([91.189.90.7]:57994) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1loqUK-00042D-4D for qemu-devel@nongnu.org; Thu, 03 Jun 2021 12:46:42 -0400 Received: from loganberry.canonical.com ([91.189.90.37]) by indium.canonical.com with esmtp (Exim 4.93 #5 (Debian)) id 1loqUG-0002NM-1Z for ; Thu, 03 Jun 2021 16:46:28 +0000 Received: from loganberry.canonical.com (localhost [127.0.0.1]) by loganberry.canonical.com (Postfix) with ESMTP id 2792E2E8197 for ; Thu, 3 Jun 2021 16:46:26 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Date: Thu, 03 Jun 2021 16:33:03 -0000 From: =?utf-8?q?Alex_Benn=C3=A9e?= <1896298@bugs.launchpad.net> To: qemu-devel@nongnu.org X-Launchpad-Notification-Type: bug X-Launchpad-Bug: product=qemu; status=Expired; importance=Undecided; assignee=None; X-Launchpad-Bug-Tags: tcg X-Launchpad-Bug-Information-Type: Public X-Launchpad-Bug-Private: no X-Launchpad-Bug-Security-Vulnerability: no X-Launchpad-Bug-Commenters: ajbennee mslade th-huth X-Launchpad-Bug-Reporter: Michael Slade (mslade) X-Launchpad-Bug-Modifier: =?utf-8?q?Alex_Benn=C3=A9e_=28ajbennee=29?= References: <160046874518.13612.4861858859499751315.malonedeb@gac.canonical.com> <20210525164541.17985-1-alex.bennee@linaro.org> Message-ID: <8735ty9acu.fsf@linaro.org> Subject: [Bug 1896298] Re: [RFC PATCH] accel/tcg: change default codegen buffer size for i386-softmmu X-Launchpad-Message-Rationale: Subscriber (QEMU) @qemu-devel-ml X-Launchpad-Message-For: qemu-devel-ml Precedence: bulk X-Generated-By: Launchpad (canonical.com); Revision="b45bdbe3a00b6b668fa7f2069bd545c35c41f7f4"; Instance="production" X-Launchpad-Hash: 29c6598fabffa7f2ded36fe30f1e0c57a974133a Received-SPF: none client-ip=91.189.90.7; envelope-from=bounces@canonical.com; helo=indium.canonical.com X-Spam_score_int: -65 X-Spam_score: -6.6 X-Spam_bar: ------ X-Spam_report: (-6.6 / 5.0 requ) BAYES_00=-1.9, HEADER_FROM_DIFFERENT_DOMAINS=0.249, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Bug 1896298 <1896298@bugs.launchpad.net> Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Message-ID: <20210603163303.VtiY62817nYmlrekURQsSuQBx9PLGCppKCYX82h4884@z> Alex Benn=C3=A9e writes: > There are two justifications for making this change. The first is that > i386 emulation is typically for smaller machines where having a 1gb of > generated code is overkill for basic emulation. The second is the > propensity of self-modifying code (c.f. Doom/edit) utilised on i386 > systems can trigger a rapid growth in invalidated and re-translated > buffers. This is seen in bug #283. Execution is still inefficient but > at least the host memory isn't so aggressively used up. > > That said it's still really just a sticking plaster for user > convenience. ping? -- = Alex Benn=C3=A9e -- = You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1896298 Title: TCG memory leak with FreeDOS 'edit' Status in QEMU: Expired Bug description: qemu trunk as of today leaks memory FAST when freedos' edit is running. To reproduce, download: https://www.ibiblio.org/pub/micro/pc- stuff/freedos/files/repositories/1.3/cdrom.iso Then run: $ qemu-system-i386 -cdrom cdrom.iso select your language then select "return to DOS", then type > edit it will consume memory at ~10MB/s This does NOT happen when adding -enable-kvm To manage notifications about this bug go to: https://bugs.launchpad.net/qemu/+bug/1896298/+subscriptions