From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8122C433B4 for ; Thu, 8 Apr 2021 14:35:47 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E6F5860FF1 for ; Thu, 8 Apr 2021 14:35:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E6F5860FF1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:56766 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lUVl3-0008S0-Nl for qemu-devel@archiver.kernel.org; Thu, 08 Apr 2021 10:35:45 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46476) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lUVjh-0007tH-7Q for qemu-devel@nongnu.org; Thu, 08 Apr 2021 10:34:21 -0400 Received: from mail-wr1-x42d.google.com ([2a00:1450:4864:20::42d]:43606) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lUVjf-0005t0-Jd for qemu-devel@nongnu.org; Thu, 08 Apr 2021 10:34:20 -0400 Received: by mail-wr1-x42d.google.com with SMTP id x7so2376776wrw.10 for ; Thu, 08 Apr 2021 07:34:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=references:user-agent:from:to:cc:subject:date:in-reply-to :message-id:mime-version:content-transfer-encoding; bh=9QU6GyZBYbcEi4MqhTg4sm3sD+ozrc8+kC4uqvLLtMY=; b=d3cH1GmX3PcoXyZkxzObyNHViasRHFDMHEqRix/KDoqWKDRIEG6Noic/2LRU9XNlV7 0ChpHU3EyqtFUFcxgI6u7rChal3cz9uIR4/tUsGcBaGxyD5O91qvkvRxvf62KprkQvII 1/S9jVJ0FlrJK9laxdjnhvUDT9bgjNCm746d9ZDn3ZLJ9TuiFkbv1Mk6J6PxzUvX3FoH l9cK2iBdzm2RM7tRIGWye9rVXQJjuGJdNsUc4sG8pqv+LKazT+ONmpPr0IIECjWtTL/W HjGtgvr/0JTfE3jkffG00iR1MvveVBYORH+Iolz73TpT9f75b48XWVbSA9vOvI6sppBG dY/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject:date :in-reply-to:message-id:mime-version:content-transfer-encoding; bh=9QU6GyZBYbcEi4MqhTg4sm3sD+ozrc8+kC4uqvLLtMY=; b=UDlkJaHnZbumemqsSBirPJ+MbVWTy5Ew0YLLp6oudal3bNfRYFG1jlEiiKojSrhh3z apolbOM3sr6XTTkTviNgfGMuNldjnlA3JnBrkrcLUYzHA98HL+Pwu8H7AWxaEs2/19yo CXgPEbbchFqvbVRbWwwt9+ACHbSpbD4/cVpODz1LxV82h/v2qOwjtT/vplFXvlpMd5ml mQuvorWJV+jOSOShURRO2YAcuwfpohKniLfDN3RJ8opLrjdsIsrxGdpl7C6h+XJO3BQH IuZRjJrMLAkNySitB4NWwmlFzo6s48cnGtpJ36Nm+h86rswRWwsge7YqAl+wWvCkBV29 FBDQ== X-Gm-Message-State: AOAM532ietZ6llriuGm49zgbQLhkxSD0RZe4/tXOb9rX68pti+A1fUaM Q+DGcqP0Bfwp6GHpG6OCB119/w== X-Google-Smtp-Source: ABdhPJx6UW9qdrCx/FD4uvlFbGN79Uu+f7m05xhd01uLVXXFh7UQY2VNdFVBFY45VYC6yq7iTLzdjA== X-Received: by 2002:a5d:61c7:: with SMTP id q7mr11881852wrv.215.1617892457452; Thu, 08 Apr 2021 07:34:17 -0700 (PDT) Received: from zen.linaroharston ([51.148.130.216]) by smtp.gmail.com with ESMTPSA id d2sm9083795wrq.26.2021.04.08.07.34.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Apr 2021 07:34:16 -0700 (PDT) Received: from zen (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 191581FF7E; Thu, 8 Apr 2021 15:34:16 +0100 (BST) References: <20210326193701.5981-1-cfontana@suse.de> <20210326193701.5981-8-cfontana@suse.de> User-agent: mu4e 1.5.11; emacs 28.0.50 From: Alex =?utf-8?Q?Benn=C3=A9e?= To: Claudio Fontana Subject: Re: [RFC v12 07/65] target/arm: tcg: split tlb_helper user-only and sysemu-only parts Date: Thu, 08 Apr 2021 15:20:05 +0100 In-reply-to: <20210326193701.5981-8-cfontana@suse.de> Message-ID: <8735w0u9p3.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2a00:1450:4864:20::42d; envelope-from=alex.bennee@linaro.org; helo=mail-wr1-x42d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Eduardo Habkost , Richard Henderson , qemu-devel@nongnu.org, Roman Bolshakov , Paolo Bonzini , Philippe =?utf-8?Q?Mathieu-D?= =?utf-8?Q?aud=C3=A9?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Claudio Fontana writes: > Signed-off-by: Claudio Fontana > Reviewed-by: Richard Henderson > +#include "qemu/osdep.h" > +#include "cpu.h" > +#include "internals.h" > +#include "exec/exec-all.h" > +#include "tcg/tlb_helper.h" > + > +bool arm_cpu_tlb_fill(CPUState *cs, vaddr address, int size, > + MMUAccessType access_type, int mmu_idx, > + bool probe, uintptr_t retaddr) > +{ > + ARMCPU *cpu =3D ARM_CPU(cs); > + ARMMMUFaultInfo fi =3D {}; > + > + int flags =3D page_get_flags(useronly_clean_ptr(address)); > + if (flags & PAGE_VALID) { > + fi.type =3D ARMFault_Permission; > + } else { > + fi.type =3D ARMFault_Translation; > + } Minor merge conflict caused by dad90de78e (target/arm: Set ARMMMUFaultInfo.level in user-only arm_cpu_tlb_fill) Otherwise: Reviewed-by: Alex Benn=C3=A9e --=20 Alex Benn=C3=A9e