From: "Alex Bennée" <alex.bennee@linaro.org>
To: Pavel Dovgalyuk <dovgaluk@ispras.ru>
Cc: kwolf@redhat.com, peter.maydell@linaro.org,
pavel.dovgaluk@ispras.ru, crosthwaite.peter@gmail.com,
ciro.santilli@gmail.com, jasowang@redhat.com,
quintela@redhat.com, qemu-devel@nongnu.org, armbru@redhat.com,
maria.klimushenkova@ispras.ru, mst@redhat.com, kraxel@redhat.com,
boost.lists@gmail.com, thomas.dullien@googlemail.com,
pbonzini@redhat.com, mreitz@redhat.com,
artem.k.pisarenko@gmail.com, dgilbert@redhat.com,
rth@twiddle.net
Subject: Re: [Qemu-devel] [for-4.2 PATCH 0/6] Block-related record/replay fixes
Date: Wed, 18 Sep 2019 11:42:26 +0100 [thread overview]
Message-ID: <8736gt28dp.fsf@linaro.org> (raw)
In-Reply-To: <001101d56dfa$bef4e630$3cdeb290$@ru>
Pavel Dovgalyuk <dovgaluk@ispras.ru> writes:
>> -----Original Message-----
>> From: Alex Bennée [mailto:alex.bennee@linaro.org]
>> Sent: Tuesday, September 17, 2019 10:02 PM
>> To: Pavel Dovgalyuk
>> Cc: qemu-devel@nongnu.org; kwolf@redhat.com; peter.maydell@linaro.org;
>> crosthwaite.peter@gmail.com; boost.lists@gmail.com; artem.k.pisarenko@gmail.com;
>> quintela@redhat.com; ciro.santilli@gmail.com; jasowang@redhat.com; mst@redhat.com;
>> armbru@redhat.com; mreitz@redhat.com; maria.klimushenkova@ispras.ru; dovgaluk@ispras.ru;
>> kraxel@redhat.com; pavel.dovgaluk@ispras.ru; thomas.dullien@googlemail.com;
>> pbonzini@redhat.com; dgilbert@redhat.com; rth@twiddle.net
>> Subject: Re: [for-4.2 PATCH 0/6] Block-related record/replay fixes
>>
>>
>> Pavel Dovgalyuk <pavel.dovgaluk@gmail.com> writes:
>>
>> > The set of patches include the block-related updates
>> > of the record/replay icount feature:
>> > - application of 'snapshot' option on the file layer instead of
>> > the top one: command line and documentation fix
>> > - implementation of bdrv_snapshot_goto for blkreplay driver
>> > - start/stop fix in replay mode with attached block devices
>> > - record/replay of bh oneshot events, used in the block layer
>>
>> Can we come up with a reasonable smoke test to verify record/replay is
>> functional? AIUI we don't need a full OS but we do need a block device
>> to store the replay data. Could we use one of the simple system tests
>> like "memory" and run that through a record and replay cycle?
>
> That's would be great.
> I'm not familiar with testing framework and couldn't find "memory"
> test that you refer to.
The memory test code is in tests/tcg/multiarch/system and gets combined
with the boot code for whichever target can build it. For example on
aarch64 it is run like:
timeout 15 $BLD/aarch64-softmmu/qemu-system-aarch64 -monitor none -display none -chardev file,path=memory.out,id=output -M virt -cpu max -display none -semihosting-config enable=on,target=native,chardev=output -kernel memory
The test binaries will be in $BLD/tests/tcg/aarch64-softmmu and are
built when you run "make check-tcg" and have either the appropriate
cross compilers installed on your system or docker enabled and setup
(see docs/devel/testing.rst).
> Replay test must at least the following:
> 1. record some execution
> 2. replay that execution
>
> And there could be several endings:
> 1. record stalled
> 2. record crashed
> 3. replay stalled
> 4. replay crashed
> 5. all executions finished successfully
If you can provide an appropriate set of invocations I can plumb them
into the Makefiles for you.
>
> Pavel Dovgalyuk
>
>>
>> >
>> > ---
>> >
>> > Pavel Dovgaluk (6):
>> > block: implement bdrv_snapshot_goto for blkreplay
>> > replay: disable default snapshot for record/replay
>> > replay: update docs for record/replay with block devices
>> > replay: don't drain/flush bdrv queue while RR is working
>> > replay: finish record/replay before closing the disks
>> > replay: add BH oneshot event for block layer
>> >
>> >
>> > block/blkreplay.c | 8 ++++++++
>> > block/block-backend.c | 9 ++++++---
>> > block/io.c | 32 ++++++++++++++++++++++++++++++--
>> > block/iscsi.c | 5 +++--
>> > block/nfs.c | 6 ++++--
>> > block/null.c | 4 +++-
>> > block/nvme.c | 6 ++++--
>> > block/rbd.c | 5 +++--
>> > block/vxhs.c | 5 +++--
>> > cpus.c | 2 --
>> > docs/replay.txt | 12 +++++++++---
>> > include/sysemu/replay.h | 4 ++++
>> > replay/replay-events.c | 16 ++++++++++++++++
>> > replay/replay-internal.h | 1 +
>> > replay/replay.c | 2 ++
>> > stubs/Makefile.objs | 1 +
>> > stubs/replay-user.c | 9 +++++++++
>> > vl.c | 11 +++++++++--
>> > 18 files changed, 115 insertions(+), 23 deletions(-)
>> > create mode 100644 stubs/replay-user.c
>>
>>
>> --
>> Alex Bennée
--
Alex Bennée
next prev parent reply other threads:[~2019-09-18 10:43 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-17 11:57 [Qemu-devel] [for-4.2 PATCH 0/6] Block-related record/replay fixes Pavel Dovgalyuk
2019-09-17 11:57 ` [Qemu-devel] [for-4.2 PATCH 1/6] block: implement bdrv_snapshot_goto for blkreplay Pavel Dovgalyuk
2019-09-17 11:57 ` [Qemu-devel] [for-4.2 PATCH 2/6] replay: disable default snapshot for record/replay Pavel Dovgalyuk
2019-09-17 11:58 ` [Qemu-devel] [for-4.2 PATCH 3/6] replay: update docs for record/replay with block devices Pavel Dovgalyuk
2019-09-18 9:18 ` Kevin Wolf
2019-09-18 9:22 ` Pavel Dovgalyuk
2019-09-18 9:33 ` Kevin Wolf
2019-09-18 9:37 ` Pavel Dovgalyuk
2019-09-18 9:44 ` Kevin Wolf
2019-09-18 9:52 ` Pavel Dovgalyuk
2019-09-19 8:53 ` Kevin Wolf
2019-09-19 9:05 ` Pavel Dovgalyuk
2019-09-19 11:27 ` Kevin Wolf
2019-09-19 12:10 ` Pavel Dovgalyuk
2019-09-19 13:00 ` Kevin Wolf
2019-09-20 7:25 ` Pavel Dovgalyuk
2019-09-20 10:01 ` Kevin Wolf
2019-09-23 6:15 ` Pavel Dovgalyuk
2019-09-25 9:02 ` Pavel Dovgalyuk
2019-10-01 8:22 ` Pavel Dovgalyuk
2019-10-10 15:28 ` Kevin Wolf
2019-10-11 6:10 ` Pavel Dovgalyuk
2019-10-11 9:12 ` Kevin Wolf
2019-10-18 12:06 ` Pavel Dovgalyuk
2019-10-18 14:16 ` Kevin Wolf
2019-09-17 11:58 ` [Qemu-devel] [for-4.2 PATCH 4/6] replay: don't drain/flush bdrv queue while RR is working Pavel Dovgalyuk
2019-09-17 11:58 ` [Qemu-devel] [for-4.2 PATCH 5/6] replay: finish record/replay before closing the disks Pavel Dovgalyuk
2019-09-17 11:58 ` [Qemu-devel] [for-4.2 PATCH 6/6] replay: add BH oneshot event for block layer Pavel Dovgalyuk
2019-09-17 18:09 ` [Qemu-devel] [for-4.2 PATCH 0/6] Block-related record/replay fixes no-reply
2019-09-17 18:10 ` no-reply
2019-09-17 19:01 ` Alex Bennée
2019-09-18 8:26 ` Pavel Dovgalyuk
2019-09-18 10:42 ` Alex Bennée [this message]
2019-09-18 11:32 ` Pavel Dovgalyuk
2019-10-11 9:17 ` Kevin Wolf
-- strict thread matches above, loose matches on Subject: below --
2019-07-29 6:29 [Qemu-devel] " Pavel Dovgalyuk
2019-07-29 6:42 ` no-reply
2019-07-29 6:59 ` no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8736gt28dp.fsf@linaro.org \
--to=alex.bennee@linaro.org \
--cc=armbru@redhat.com \
--cc=artem.k.pisarenko@gmail.com \
--cc=boost.lists@gmail.com \
--cc=ciro.santilli@gmail.com \
--cc=crosthwaite.peter@gmail.com \
--cc=dgilbert@redhat.com \
--cc=dovgaluk@ispras.ru \
--cc=jasowang@redhat.com \
--cc=kraxel@redhat.com \
--cc=kwolf@redhat.com \
--cc=maria.klimushenkova@ispras.ru \
--cc=mreitz@redhat.com \
--cc=mst@redhat.com \
--cc=pavel.dovgaluk@ispras.ru \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=rth@twiddle.net \
--cc=thomas.dullien@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).