From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35306) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aTSrc-0002QX-TQ for qemu-devel@nongnu.org; Wed, 10 Feb 2016 06:23:18 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aTSrZ-0000vs-Mk for qemu-devel@nongnu.org; Wed, 10 Feb 2016 06:23:16 -0500 Received: from mail-wm0-x22d.google.com ([2a00:1450:400c:c09::22d]:33407) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aTSrZ-0000vk-A6 for qemu-devel@nongnu.org; Wed, 10 Feb 2016 06:23:13 -0500 Received: by mail-wm0-x22d.google.com with SMTP id g62so22562770wme.0 for ; Wed, 10 Feb 2016 03:23:13 -0800 (PST) References: <1454664263-25969-1-git-send-email-famz@redhat.com> From: Alex =?utf-8?Q?Benn=C3=A9e?= In-reply-to: <1454664263-25969-1-git-send-email-famz@redhat.com> Date: Wed, 10 Feb 2016 11:23:10 +0000 Message-ID: <8737t0x10h.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH 00/12] tests: Introducing docker tests List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng Cc: kwolf@redhat.com, peter.maydell@linaro.org, sw@weilnetz.de, qemu-devel@nongnu.org, stefanha@redhat.com, Paolo Bonzini , jsnow@redhat.com, david@gibson.dropbear.id.au Fam Zheng writes: > v1: Since RFC, addressed comments from reviewers, and improved a lot of things. > Thanks to Daniel, Eric, Paolo, Stefan, for the feedback. > > This series adds a new "docker" make target family to run tests in created > docker containers. > > To begin with, this can be a place to store standard env/command combinations to > build and test QEMU. > > Secondly, CI usually provides "docker" capability (such as travis [1]), where > we define standard/repeatable test environments, and run tests in them. > However, what tests to cover is better maintained in-tree, in order to keep in > sync with the code development. We've actually just switched to using Travis' containers for our builds which I think don't allow the use of docker. This is because Travis has more build capacity with the container infrastructure compared to the old VM based solution. That said that we could switch back. > > Lastly, this makes it very simple for developers to replicate such tests > themselves. However I think this is the most useful part. Making it easier for developers to run tests on something other than their desktop. I shall have a look through. Thanks! > > [1]: https://docs.travis-ci.com/user/docker/ > > Fam Zheng (12): > tests: Add utilities for docker testing > Makefile: Rules for docker testing > docker: Add images > docker: Add test runner > docker: Add common.rc > docker: Add basic test > docker: Add clang test > docker: Add mingw test > docker: Add travis tool > docs: Add text for tests/docker in build-system.txt > .gitignore: Ignore temporary dockerfile > MAINTAINERS: Add tests/docker > > .gitignore | 1 + > MAINTAINERS | 7 +++ > Makefile | 4 +- > docs/build-system.txt | 5 ++ > tests/docker/Makefile.include | 88 ++++++++++++++++++++++++++++++++++ > tests/docker/centos6.docker | 5 ++ > tests/docker/common.rc | 28 +++++++++++ > tests/docker/docker.py | 108 ++++++++++++++++++++++++++++++++++++++++++ > tests/docker/docker_build | 42 ++++++++++++++++ > tests/docker/docker_clean | 22 +++++++++ > tests/docker/docker_run | 28 +++++++++++ > tests/docker/fedora.docker | 7 +++ > tests/docker/run | 23 +++++++++ > tests/docker/test-basic.sh | 22 +++++++++ > tests/docker/test-clang.sh | 26 ++++++++++ > tests/docker/test-mingw.sh | 34 +++++++++++++ > tests/docker/travis.py | 53 +++++++++++++++++++++ > tests/docker/travis.sh | 20 ++++++++ > tests/docker/ubuntu.docker | 9 ++++ > 19 files changed, 531 insertions(+), 1 deletion(-) > create mode 100644 tests/docker/Makefile.include > create mode 100644 tests/docker/centos6.docker > create mode 100755 tests/docker/common.rc > create mode 100755 tests/docker/docker.py > create mode 100755 tests/docker/docker_build > create mode 100755 tests/docker/docker_clean > create mode 100755 tests/docker/docker_run > create mode 100644 tests/docker/fedora.docker > create mode 100755 tests/docker/run > create mode 100755 tests/docker/test-basic.sh > create mode 100755 tests/docker/test-clang.sh > create mode 100755 tests/docker/test-mingw.sh > create mode 100755 tests/docker/travis.py > create mode 100755 tests/docker/travis.sh > create mode 100644 tests/docker/ubuntu.docker -- Alex Bennée