From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51080) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aT5vr-0000KV-KH for qemu-devel@nongnu.org; Tue, 09 Feb 2016 05:54:08 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aT5vo-0000o9-EG for qemu-devel@nongnu.org; Tue, 09 Feb 2016 05:54:07 -0500 Received: from mx1.redhat.com ([209.132.183.28]:38213) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aT5vo-0000nq-8g for qemu-devel@nongnu.org; Tue, 09 Feb 2016 05:54:04 -0500 From: Markus Armbruster References: <1454957357-22094-1-git-send-email-peter.maydell@linaro.org> Date: Tue, 09 Feb 2016 11:54:00 +0100 In-Reply-To: <1454957357-22094-1-git-send-email-peter.maydell@linaro.org> (Peter Maydell's message of "Mon, 8 Feb 2016 18:49:15 +0000") Message-ID: <8737t2nohj.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH 0/2] tests: clean includes List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: qemu-devel@nongnu.org, patches@linaro.org Peter Maydell writes: > This patchset runs clean-includes on all the .c files in > tests/, except those in tests/tcg, which I think are all > intended as standalone test programs for the guest. > > The first patch handles i440fx-test.c manually since otherwise > compilation would fail due to the redefinition of ARRAY_SIZE. > The second patch is automated; I can split it up if people > prefer but it seems just about small enough to leave as one patch. > > With these patches applied Eric's "qapi: Clean up includes in > generated files" patch no longer breaks 'make check'. I applied this series, merged my qapi-next, topped off with Eric's patch, and got a working build. I'll send a pull request for qapi-next without Eric's patch, to avoid dependencies. If Eric's patch is not merged, but this series is, I'll include it in the next QAPI pull request. Feel free to apply it directly along with this series.