qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Markus Armbruster <armbru@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: QEMU Developers <qemu-devel@nongnu.org>,
	Michael Roth <mdroth@linux.vnet.ibm.com>
Subject: Re: [Qemu-devel] [PATCH] qapi: Clean up includes in generated files
Date: Mon, 08 Feb 2016 19:25:36 +0100	[thread overview]
Message-ID: <8737t3qctb.fsf@blackfin.pond.sub.org> (raw)
In-Reply-To: <CAFEAcA8QWDD_8KG_An-jDSg5q+pTBKG-eO=mSYmCRda05dhHBg@mail.gmail.com> (Peter Maydell's message of "Mon, 8 Feb 2016 17:45:32 +0000")

Peter Maydell <peter.maydell@linaro.org> writes:

> On 8 February 2016 at 17:39, Markus Armbruster <armbru@redhat.com> wrote:
>> Eric Blake <eblake@redhat.com> writes:
>>> As a followup to commit cbf2115, clean up the includes in files
>>> generated by QAPI so that osdep.h is included first in .c files,
>>> and headers which it implies are not included manually.  This
>>> patch is done manually, since Coccinelle (and therefore
>>> scripts/clean-includes) doesn't see into the generator scripts.
>>> Signed-off-by: Eric Blake <eblake@redhat.com>
>>   CC    tests/check-qfloat.o
>> In file included from /home/armbru/work/qemu/include/qapi/qmp/qobject.h:37:0,
>>                  from /home/armbru/work/qemu/include/qapi/qmp/qfloat.h:18,
>>                  from /home/armbru/work/qemu/tests/check-qfloat.c:15:
>> ./qapi-types.h:55:9: error: unknown type name ‘bool’
>>          bool value;
>>          ^
>> Chicken and egg problem?  check-qfloat.c doesn't include osdep.h, yet...
> Easy enough to add it; I have 'run clean-includes on tests/' on
> my todo list, but it requires a little care because I think at
> least some .c files in tests/ do not have QEMU headers in their
> include path at all. This might just be tests/tcg/.

With "make check" fixed:
Reviewed-by: Markus Armbruster <armbru@redhat.com>

I'm happy to take it through my tree when it's ready (tell me then), but
it might be easier to take it along whatever fixes "make check".

  reply	other threads:[~2016-02-08 18:25 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-08 15:36 Eric Blake
2016-02-08 17:39 ` Markus Armbruster
2016-02-08 17:45   ` Peter Maydell
2016-02-08 18:25     ` Markus Armbruster [this message]
2016-02-08 18:29       ` Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8737t3qctb.fsf@blackfin.pond.sub.org \
    --to=armbru@redhat.com \
    --cc=mdroth@linux.vnet.ibm.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --subject='Re: [Qemu-devel] [PATCH] qapi: Clean up includes in generated files' \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).