From: Markus Armbruster <armbru@redhat.com>
To: Claudio Imbrenda <imbrenda@linux.ibm.com>
Cc: pbonzini@redhat.com, qemu-devel@nongnu.org, david@redhat.com,
thuth@redhat.com, borntraeger@de.ibm.com,
frankja@linux.ibm.com, fiuczy@linux.ibm.com,
pasic@linux.ibm.com, nsg@linux.ibm.com, berrange@redhat.com,
alex.bennee@linaro.org
Subject: Re: [PATCH v4 1/1] util/async-teardown: wire up query-command-line-options
Date: Mon, 27 Mar 2023 14:59:14 +0200 [thread overview]
Message-ID: <874jq6bba5.fsf@pond.sub.org> (raw)
In-Reply-To: <20230327120357.34743-2-imbrenda@linux.ibm.com> (Claudio Imbrenda's message of "Mon, 27 Mar 2023 14:03:57 +0200")
Claudio Imbrenda <imbrenda@linux.ibm.com> writes:
> The recently introduced -async-teardown commandline option was not
> wired up properly and did not show up in the output of the QMP command
> query-command-line-options. This means that libvirt had no way to
> discover whether the feature was supported.
Excuse the pedantry... The option *was* wired up correctly, just in a
way that isn't visible in query-command-line-options. Suggest "The
recently introduced -async-teardown command line option -async-teardown
is not visible in query-command-line-options."
> This patch fixes the issue by replacing the -async-teardown option with
> a new -teardown option with a new async=on|off parameter.
Why we can drop -async-teardown right away, without a deprecating it
first? The commit message needs to make the argument.
If we can drop it right away, you need to update
about/removed-features.rst.
Else, you need to update docs/about/deprecated.rst, and emit a warning
when the option is used. Something like
warn_reportf("-async-teardown is deprecated, use -teardown async=on instead");
> The new option is correctly wired up so that it appears in the output
> of query-command-line-options.
Suggest
Add new -teardown option with an async=on|off parameter. It is
visible in query-command-line-options.
Then either
Option -async-teardown is now redundant. We'd normally deprecate it
and remove it after a grace period, but <argument goes here...>
Drop it.
or
Option -async-teardown is now redundant. Deprecate it.
> Reported-by: Boris Fiuczynski <fiuczy@linux.ibm.com>
> Fixes: c891c24b1a ("os-posix: asynchronous teardown for shutdown on Linux")
> Signed-off-by: Claudio Imbrenda <imbrenda@linux.ibm.com>
prev parent reply other threads:[~2023-03-27 12:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-27 12:03 [PATCH v4 0/1] util/async-teardown: wire up query-command-line-options Claudio Imbrenda
2023-03-27 12:03 ` [PATCH v4 1/1] " Claudio Imbrenda
2023-03-27 12:59 ` Markus Armbruster [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874jq6bba5.fsf@pond.sub.org \
--to=armbru@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=berrange@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=david@redhat.com \
--cc=fiuczy@linux.ibm.com \
--cc=frankja@linux.ibm.com \
--cc=imbrenda@linux.ibm.com \
--cc=nsg@linux.ibm.com \
--cc=pasic@linux.ibm.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).