From: "Alex Bennée" <alex.bennee@linaro.org>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: "Emilio G. Cota" <cota@braap.org>,
QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [PATCH] tcg plugins: expose an API version concept
Date: Fri, 08 Nov 2019 16:24:21 +0000 [thread overview]
Message-ID: <874kzegwui.fsf@linaro.org> (raw)
In-Reply-To: <CAFEAcA-42Fg-ihBm3JVET41SJ1Mot7m-i1ZGt+Y1afOY1wZ0Ow@mail.gmail.com>
Peter Maydell <peter.maydell@linaro.org> writes:
> On Mon, 4 Nov 2019 at 13:18, Alex Bennée <alex.bennee@linaro.org> wrote:
>>
>> This is a very simple versioning API which allows the plugin
>> infrastructure to check the API a plugin was built against. We also
>> expose a min/cur API version to the plugin via the info block in case
>> it wants to avoid using old deprecated APIs in the future.
>
> I think the general idea here is fine, and I want to see
> us get the version-check into 4.2, because I don't think
> we should release a QEMU which doesn't do a basic version
> sanity check. I have some minor comments below.
>
>
>> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
>> ---
>> include/qemu/qemu-plugin.h | 19 +++++++++++++++++++
>> plugins/loader.c | 15 +++++++++++++++
>> plugins/plugin.h | 2 ++
>> tests/plugin/bb.c | 2 ++
>> tests/plugin/empty.c | 2 ++
>> tests/plugin/hotpages.c | 2 ++
>> tests/plugin/howvec.c | 2 ++
>> tests/plugin/insn.c | 2 ++
>> tests/plugin/mem.c | 2 ++
>> 9 files changed, 48 insertions(+)
>>
>> diff --git a/include/qemu/qemu-plugin.h b/include/qemu/qemu-plugin.h
>> index a00a7deb461..5502e112c81 100644
>> --- a/include/qemu/qemu-plugin.h
>> +++ b/include/qemu/qemu-plugin.h
>
> As an aside, is this the header file used for building
> the plugins? It seems a bit odd to have put it
> in include/qemu, which is for headers used when building
> QEMU itself.
It's also included by the internal plugin header. We could put it
somewhere else. include/api/? Where do the QMP specs end up?
I'll make the other changes in v2.
--
Alex Bennée
prev parent reply other threads:[~2019-11-08 16:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-04 13:18 [PATCH] tcg plugins: expose an API version concept Alex Bennée
2019-11-04 16:23 ` Philippe Mathieu-Daudé
2019-11-08 14:43 ` Peter Maydell
2019-11-08 16:24 ` Alex Bennée [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874kzegwui.fsf@linaro.org \
--to=alex.bennee@linaro.org \
--cc=cota@braap.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).