From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 00F96C32755 for ; Mon, 23 Sep 2019 11:50:55 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CD3E3207FD for ; Mon, 23 Sep 2019 11:50:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CD3E3207FD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:55134 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iCMrl-0007AB-VA for qemu-devel@archiver.kernel.org; Mon, 23 Sep 2019 07:50:54 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43806) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iCMnh-0004fg-G7 for qemu-devel@nongnu.org; Mon, 23 Sep 2019 07:46:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iCMng-0005bE-L2 for qemu-devel@nongnu.org; Mon, 23 Sep 2019 07:46:41 -0400 Received: from mx1.redhat.com ([209.132.183.28]:26948) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iCMng-0005az-GJ for qemu-devel@nongnu.org; Mon, 23 Sep 2019 07:46:40 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id D1322300C035; Mon, 23 Sep 2019 11:46:39 +0000 (UTC) Received: from blackfin.pond.sub.org (ovpn-117-142.ams2.redhat.com [10.36.117.142]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 357A319C58; Mon, 23 Sep 2019 11:46:37 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 0194F113864E; Mon, 23 Sep 2019 13:46:35 +0200 (CEST) From: Markus Armbruster To: Eric Blake Subject: Re: [Qemu-devel] [PATCH v3 10/16] qapi: Permit omitting all flat union branches References: <20190913201349.24332-1-armbru@redhat.com> <20190913201349.24332-11-armbru@redhat.com> <454671e9-480d-006b-cfb3-f17b19faf024@redhat.com> Date: Mon, 23 Sep 2019 13:46:35 +0200 In-Reply-To: <454671e9-480d-006b-cfb3-f17b19faf024@redhat.com> (Eric Blake's message of "Tue, 17 Sep 2019 11:20:36 -0500") Message-ID: <874l13p750.fsf@dusky.pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.46]); Mon, 23 Sep 2019 11:46:39 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: marcandre.lureau@redhat.com, qemu-devel@nongnu.org, mdroth@linux.vnet.ibm.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Eric Blake writes: > On 9/13/19 3:13 PM, Markus Armbruster wrote: >> Absent flat union branches default to the empty struct (since commit >> 800877bb16 "qapi: allow empty branches in flat unions"). But am > > s/am/an/ Will fix, thanks! >> attempt to omit all of them is rejected with "Union 'FOO' has no >> branches". Harmless oddity, but it's easy to avoid, so do that. >> >> Signed-off-by: Markus Armbruster >> Reviewed-by: Eric Blake >> ---