From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B21CEC433E0 for ; Wed, 13 Jan 2021 13:50:21 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2BFF923339 for ; Wed, 13 Jan 2021 13:50:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2BFF923339 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:51814 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kzgXT-0005LN-VK for qemu-devel@archiver.kernel.org; Wed, 13 Jan 2021 08:50:19 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:44104) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kzgV9-00044U-BT for qemu-devel@nongnu.org; Wed, 13 Jan 2021 08:47:55 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:51893) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kzgV7-0003os-BP for qemu-devel@nongnu.org; Wed, 13 Jan 2021 08:47:55 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1610545672; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ymhsrLTpVqf+YV4UDp3pX1LEnr75n0cl4NCRaFGDRVs=; b=YKQAV7DWkhd2rwSn22HqISb+mRC+S30UUhOwf4y2VpEBdzBSDUYjCQktdTOasDqU9Aqit8 tbC2nh8rJOrER3HXGHN9+JLLf6lzVY2WyhUfof51GQ1bGdUURVri83wkJ628pAjfhlgCe9 7+/j2i/JKgr0Z4r8WBGsA/PMwA+sENE= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-399-3tb-Q7gBOT-PcQvX3_SlPQ-1; Wed, 13 Jan 2021 08:47:51 -0500 X-MC-Unique: 3tb-Q7gBOT-PcQvX3_SlPQ-1 Received: by mail-wr1-f71.google.com with SMTP id n11so993631wro.7 for ; Wed, 13 Jan 2021 05:47:50 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references :user-agent:reply-to:date:message-id:mime-version :content-transfer-encoding; bh=KcI38j+Zh3rURT7LR1cI4qN+NHTumYNN/a/93hEfFGI=; b=VL+Pp1uKYIbw2fngldYX160BqNgpk+fLYXbZSf7Hsfe2Y8V4x4Mv2xfWYjRJeu8gv0 FRueL2dWgzthG39JfgOc4MzAhSSH7Gg6VKliiWJ/8FVnyAHVByoNP3knaW2OIqG+8sNM 57lgW0m69pzOerM+f2WaD6n7hu9SkWSousq5lBgzV3qAHRe6Z8oH4OV4N5ghtZilOuwB wF8xc6asR1mMHF9s81jGJPnCC0QyilcAbVfij2X9IKG5XdG7JL/VKrWcQWGgH2B5sqJp jdS4npb+yfEl9l0A1KQcS8Z2bWULI56miEXGTTXIZZZCoTnUNd/l1SXwMTRD084n9tgu SplQ== X-Gm-Message-State: AOAM53239vLaq069HKn75TrDokxak37iIEztBw/6cMzh9IxX/2xs1Ssv qk6xto5sPM+Jwf4ababnBvBADeYO1Z5bFKcMk2VTGDXo9rI9N+15lYP8i3JSe6ZhdzsF9vjvvUL oSvMW6XCsIxGBTo4= X-Received: by 2002:a1c:3206:: with SMTP id y6mr2240410wmy.127.1610545669445; Wed, 13 Jan 2021 05:47:49 -0800 (PST) X-Google-Smtp-Source: ABdhPJzvqTnT8hcN8capifqTi9YCju/BfJs0gwNC+0Frx2go3YbQD8dgOOTWGXVbdy6s6qd4zOAG6A== X-Received: by 2002:a1c:3206:: with SMTP id y6mr2240394wmy.127.1610545669204; Wed, 13 Jan 2021 05:47:49 -0800 (PST) Received: from localhost (trasno.trasno.org. [83.165.45.250]) by smtp.gmail.com with ESMTPSA id l20sm3736801wrh.82.2021.01.13.05.47.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Jan 2021 05:47:48 -0800 (PST) From: Juan Quintela To: Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= Subject: Re: [RFC PATCH v6 04/11] hw/ssi: imx_spi: Reduce 'change_mask' variable scope In-Reply-To: <87im81gdig.fsf@secure.mitica> (Juan Quintela's message of "Wed, 13 Jan 2021 14:41:43 +0100") References: <20210112183529.2011863-1-f4bug@amsat.org> <20210112183529.2011863-5-f4bug@amsat.org> <87im81gdig.fsf@secure.mitica> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) Date: Wed, 13 Jan 2021 14:47:47 +0100 Message-ID: <875z41gd8c.fsf@secure.mitica> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=quintela@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=216.205.24.124; envelope-from=quintela@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -29 X-Spam_score: -3.0 X-Spam_bar: --- X-Spam_report: (-3.0 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.25, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: quintela@redhat.com Cc: Peter Maydell , Alistair Francis , Bin Meng , qemu-devel@nongnu.org, Jean-Christophe Dubois , qemu-arm@nongnu.org, Peter Chubb , Bin Meng Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Juan Quintela wrote: > Philippe Mathieu-Daud=C3=A9 wrote: >> Signed-off-by: Philippe Mathieu-Daud=C3=A9 > > I think this one is wrong. Wrong is a strong word. I mean that it changes behaviour and the commit message don't talk about changing behaviour. Later, Juan. > > >> --- >> hw/ssi/imx_spi.c | 3 +-- >> 1 file changed, 1 insertion(+), 2 deletions(-) >> >> diff --git a/hw/ssi/imx_spi.c b/hw/ssi/imx_spi.c >> index 35ab33c0511..bcc535f2893 100644 >> --- a/hw/ssi/imx_spi.c >> +++ b/hw/ssi/imx_spi.c >> @@ -303,7 +303,6 @@ static void imx_spi_write(void *opaque, hwaddr offse= t, uint64_t value, >> { >> IMXSPIState *s =3D opaque; >> uint32_t index =3D offset >> 2; >> - uint32_t change_mask; >> =20 >> if (index >=3D ECSPI_MAX) { >> qemu_log_mask(LOG_GUEST_ERROR, "[%s]%s: Bad register at offset = 0x%" >> @@ -313,7 +312,6 @@ static void imx_spi_write(void *opaque, hwaddr offse= t, uint64_t value, >> =20 >> trace_imx_spi_write(index, imx_spi_reg_name(index), value); >> =20 >> - change_mask =3D s->regs[index] ^ value; >> =20 >> switch (index) { >> case ECSPI_RXDATA: >> @@ -357,6 +355,7 @@ static void imx_spi_write(void *opaque, hwaddr offse= t, uint64_t value, >> } >> =20 >> if (imx_spi_channel_is_master(s)) { >> + uint32_t change_mask =3D s->regs[index] ^ value; >> int i; >> =20 >> /* We are in master mode */ > > The code does: > > change_mask =3D s->regs[index] ^ value; > > switch (index) { > > ... > > case ECSPI_CONREG: > s->regs[ECSPI_CONREG] =3D value; <<---- here > > if (!imx_spi_is_enabled(s)) { > /* device is disabled, so this is a reset */ > imx_spi_reset(DEVICE(s)); > return; > } > > if (imx_spi_channel_is_master(s)) { > int i; > >>>>> You are setting change_mask here. > > At this point, s->regs[index] has a new value in "here". > > Later, Juan.