From: "Alex Bennée" <alex.bennee@linaro.org>
To: Robert Henry <robhenry@microsoft.com>
Cc: qemu-devel@nongnu.org
Subject: Re: plugin interface function qemu_plugin_mem_size_shift
Date: Fri, 03 Apr 2020 19:55:46 +0100 [thread overview]
Message-ID: <875zege6vh.fsf@linaro.org> (raw)
In-Reply-To: <BL0PR2101MB1026AF0CA590021284C39D1BD60C0@BL0PR2101MB1026.namprd21.prod.outlook.com>
Robert Henry <robhenry@microsoft.com> writes:
> I don't understand what
> unsigned int qemu_plugin_mem_size_shift(qemu_plugin_meminfo_t info);
> does. The documentation in qemu-plugin.h is silent on this matter.
> It appears to expose more of the guts of qemu that I don't yet know.
It's the size as a power of 2, so:
0 = byte
1 = 16 bit
2 = 32 bit
3 = 64 bit
4 = 128 bit
and so on. Currently I think our largest memory accesses are around 256
bytes but we can go larger is required.
How about:
--8<---------------cut here---------------start------------->8---
plugins: document the meaning of size_shift
We describe memory accesses in powers of 2.
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
1 file changed, 3 insertions(+)
include/qemu/qemu-plugin.h | 3 +++
modified include/qemu/qemu-plugin.h
@@ -301,6 +301,9 @@ void *qemu_plugin_insn_haddr(const struct qemu_plugin_insn *insn);
* The anonymous qemu_plugin_meminfo_t and qemu_plugin_hwaddr types
* can be used in queries to QEMU to get more information about a
* given memory access.
+ *
+ * The size_shift is the scale of access, e.g. << 3 is a 64 bit wide
+ * access.
*/
typedef uint32_t qemu_plugin_meminfo_t;
struct qemu_plugin_hwaddr;
--8<---------------cut here---------------end--------------->8---
--
Alex Bennée
next prev parent reply other threads:[~2020-04-03 18:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-22 0:03 plugin interface function qemu_plugin_mem_size_shift Robert Henry
2020-04-03 18:55 ` Alex Bennée [this message]
2020-04-04 0:15 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875zege6vh.fsf@linaro.org \
--to=alex.bennee@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=robhenry@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).