From: Markus Armbruster <armbru@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [PULL 0/6] QAPI patches for 2019-12-17
Date: Wed, 18 Dec 2019 09:42:24 +0100 [thread overview]
Message-ID: <875zie81ov.fsf@dusky.pond.sub.org> (raw)
In-Reply-To: <CAFEAcA8r-wai+vMa8WiCjUFyRGwTQQs9fZo_ddRmAdr_6GAcTw@mail.gmail.com> (Peter Maydell's message of "Tue, 17 Dec 2019 15:54:58 +0000")
Peter Maydell <peter.maydell@linaro.org> writes:
> On Tue, 17 Dec 2019 at 08:16, Markus Armbruster <armbru@redhat.com> wrote:
>>
>> The following changes since commit cb88904a54903ef6ba21a68a61d9cd51e2166304:
>>
>> Merge remote-tracking branch 'remotes/amarkovic/tags/mips-queue-dec-16-2019' into staging (2019-12-16 14:07:56 +0000)
>>
>> are available in the Git repository at:
>>
>> git://repo.or.cz/qemu/armbru.git tags/pull-qapi-2019-12-17
>>
>> for you to fetch changes up to 328add3012e0b642134afedcd53660c30c758866:
>>
>> qapi: Simplify QAPISchemaModularCVisitor (2019-12-17 08:09:28 +0100)
>>
>> ----------------------------------------------------------------
>> QAPI patches for 2019-12-17
>>
>> ----------------------------------------------------------------
>> Markus Armbruster (6):
>> qapi: Tweak "command returns a nice type" check for clarity
>> tests/Makefile.include: Fix missing test-qapi-emit-events.[ch]
>> qapi: Generate command registration stuff into separate files
>> qapi: Proper intermediate representation for modules
>> qapi: Fix code generation for empty modules
>> qapi: Simplify QAPISchemaModularCVisitor
>
> Build failures:
>
> OSX:
> In file included from In file included from qapi/qapi-types-block.c:15:
> In file included from
> /Users/pm215/src/qemu-for-merges/build/all/qapi/qapi-types-block.h:17:
> In file included from
> /Users/pm215/src/qemu-for-merges/build/all/qapi/qapi-types-block-core.h:18:
> /Users/pm215/src/qemu-for-merges/build/all/qapi/qapi-types-crypto.h:176:33:
> error: field has incomplete type 'QCryptoBlockOptionsQCow' (aka
> 'struct QCryptoBlockOptionsQCow')
> qapi/qapi-types-block-core.c:15:
> In file included from
> /Users/pm215/src/qemu-for-merges/build/all/qapi/qapi-types-block-core.h:18:
> /Users/pm215/src/qemu-for-merges/build/all/qapi/qapi-types-crypto.h:176:33:
> error: field has incomplete type 'QCryptoBlockOptionsQCow' (aka
> 'struct QCryptoBlockOptionsQCow')
> QCryptoBlockOptionsQCow qcow;
> QCryptoBlockOptionsQCow qcow; ^
>
> ^
Perplexing. None of the files involved gets changed by this pull
request. My qapi-types-crypto.h has
typedef struct QCryptoBlockOptionsQCow QCryptoBlockOptionsQCow;
[...]
struct QCryptoBlockOptionsQCow {
bool has_key_secret;
char *key_secret;
};
[...]
struct QCryptoBlockOpenOptions {
/* Members inherited from QCryptoBlockOptionsBase: */
QCryptoBlockFormat format;
/* Own members: */
union { /* union tag is @format */
QCryptoBlockOptionsQCow qcow;
QCryptoBlockOptionsLUKS luks;
} u;
};
before and after. May I see yours?
[More errors snipped, they're similar]
next prev parent reply other threads:[~2019-12-18 8:43 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-17 8:14 [PULL 0/6] QAPI patches for 2019-12-17 Markus Armbruster
2019-12-17 8:14 ` [PULL 1/6] qapi: Tweak "command returns a nice type" check for clarity Markus Armbruster
2019-12-17 8:14 ` [PULL 2/6] tests/Makefile.include: Fix missing test-qapi-emit-events.[ch] Markus Armbruster
2019-12-17 8:14 ` [PULL 3/6] qapi: Generate command registration stuff into separate files Markus Armbruster
2019-12-17 8:14 ` [PULL 4/6] qapi: Proper intermediate representation for modules Markus Armbruster
2019-12-17 8:14 ` [PULL 5/6] qapi: Fix code generation for empty modules Markus Armbruster
2019-12-17 8:14 ` [PULL 6/6] qapi: Simplify QAPISchemaModularCVisitor Markus Armbruster
2019-12-17 15:54 ` [PULL 0/6] QAPI patches for 2019-12-17 Peter Maydell
2019-12-18 8:42 ` Markus Armbruster [this message]
2019-12-19 17:05 ` Peter Maydell
2019-12-20 12:36 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875zie81ov.fsf@dusky.pond.sub.org \
--to=armbru@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).