From: "Alex Bennée" <alex.bennee@linaro.org>
To: Denis Plotnikov <dplotnikov@virtuozzo.com>
Cc: philmd@redhat.com, qemu-devel@nongnu.org
Subject: Re: [PATCH] gdbstub: fix compiler complaining
Date: Fri, 27 Mar 2020 09:07:43 +0000 [thread overview]
Message-ID: <877dz6np28.fsf@linaro.org> (raw)
In-Reply-To: <20200326151407.25046-1-dplotnikov@virtuozzo.com>
Denis Plotnikov <dplotnikov@virtuozzo.com> writes:
> ./gdbstub.c: In function ‘handle_query_thread_extra’:
> /usr/include/glib-2.0/glib/glib-autocleanups.h:28:10:
> error: ‘cpu_name’ may be used uninitialized in this function
> [-Werror=maybe-uninitialized]
> g_free (*pp);
> ^
> ./gdbstub.c:2063:26: note: ‘cpu_name’ was declared here
> g_autofree char *cpu_name;
> ^
> cc1: all warnings being treated as errors
>
> Signed-off-by: Denis Plotnikov <dplotnikov@virtuozzo.com>
Queued to for-5.0/random-fixes, thanks.
> ---
> gdbstub.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/gdbstub.c b/gdbstub.c
> index 013fb1ac0f..171e150950 100644
> --- a/gdbstub.c
> +++ b/gdbstub.c
> @@ -2060,8 +2060,8 @@ static void handle_query_thread_extra(GdbCmdContext *gdb_ctx, void *user_ctx)
> /* Print the CPU model and name in multiprocess mode */
> ObjectClass *oc = object_get_class(OBJECT(cpu));
> const char *cpu_model = object_class_get_name(oc);
> - g_autofree char *cpu_name;
> - cpu_name = object_get_canonical_path_component(OBJECT(cpu));
> + g_autofree char *cpu_name =
> + object_get_canonical_path_component(OBJECT(cpu));
> g_string_printf(rs, "%s %s [%s]", cpu_model, cpu_name,
> cpu->halted ? "halted " : "running");
> } else {
--
Alex Bennée
prev parent reply other threads:[~2020-03-27 9:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-26 15:14 [PATCH] gdbstub: fix compiler complaining Denis Plotnikov
2020-03-26 19:50 ` Richard Henderson
2020-03-27 9:07 ` Alex Bennée [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877dz6np28.fsf@linaro.org \
--to=alex.bennee@linaro.org \
--cc=dplotnikov@virtuozzo.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).