From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8C30C282DD for ; Wed, 8 Jan 2020 13:06:14 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 847E9206F0 for ; Wed, 8 Jan 2020 13:06:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="IJ4WIHXX" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 847E9206F0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:43328 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ipB2L-0007m0-J2 for qemu-devel@archiver.kernel.org; Wed, 08 Jan 2020 08:06:13 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:36334) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ipAf6-0000cT-S4 for qemu-devel@nongnu.org; Wed, 08 Jan 2020 07:42:13 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ipAf5-0001dU-SR for qemu-devel@nongnu.org; Wed, 08 Jan 2020 07:42:12 -0500 Received: from us-smtp-2.mimecast.com ([207.211.31.81]:42157 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ipAf5-0001cF-PS for qemu-devel@nongnu.org; Wed, 08 Jan 2020 07:42:11 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1578487330; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WAa+NU+TVGTARtvdxInfQ1J7oakd2iiBzZPC9U7vFEU=; b=IJ4WIHXXNY7xbXOzQ8IhYLPE9Gzh0/txep6o6Jib4w3Ox7Tamhg+P7u1/nJF36oMEy3rXA jE2CytxmGNpK0kjXx050s8AjbGbeXUzJUvF1CNW9XKZTsKZ2Qv3kUKCJURFyew4WV61hdD M15Hmb13GdC2kjIYKN6356MGa0TjG9c= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-11-nGX2UtpINdGi9QRO0b9UfA-1; Wed, 08 Jan 2020 07:42:05 -0500 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B1DF2DB20; Wed, 8 Jan 2020 12:42:04 +0000 (UTC) Received: from redhat.com (unknown [10.36.118.112]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 01FF11001B08; Wed, 8 Jan 2020 12:42:03 +0000 (UTC) From: Juan Quintela To: Daniel Henrique Barboza Subject: Re: [PATCH v1 05/59] ram.c: remove unneeded labels In-Reply-To: <20200106182425.20312-6-danielhb413@gmail.com> (Daniel Henrique Barboza's message of "Mon, 6 Jan 2020 15:23:31 -0300") References: <20200106182425.20312-1-danielhb413@gmail.com> <20200106182425.20312-6-danielhb413@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) Date: Wed, 08 Jan 2020 13:41:59 +0100 Message-ID: <877e22i0h4.fsf@secure.laptop> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-MC-Unique: nGX2UtpINdGi9QRO0b9UfA-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 207.211.31.81 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: quintela@redhat.com Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org, "Dr . David Alan Gilbert" Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Daniel Henrique Barboza wrote: > ram_save_queue_pages() has an 'err' label that can be replaced by > 'return -1' instead. > > Same thing with ram_discard_range(), and in this case we can also > get rid of the 'ret' variable and return either '-1' on error > or the result of ram_block_discard_range(). > > CC: Juan Quintela > CC: Dr. David Alan Gilbert > Signed-off-by: Daniel Henrique Barboza Reviewed-by: Juan Quintela queued