From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61526C4338F for ; Mon, 2 Aug 2021 12:58:28 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E732560F4B for ; Mon, 2 Aug 2021 12:58:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org E732560F4B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:38946 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mAXWV-0002ZJ-2x for qemu-devel@archiver.kernel.org; Mon, 02 Aug 2021 08:58:27 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59984) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mAXVP-0001rA-Ka for qemu-devel@nongnu.org; Mon, 02 Aug 2021 08:57:19 -0400 Received: from mail-wm1-x32d.google.com ([2a00:1450:4864:20::32d]:56063) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mAXVO-0006hH-4E for qemu-devel@nongnu.org; Mon, 02 Aug 2021 08:57:19 -0400 Received: by mail-wm1-x32d.google.com with SMTP id x17so4103225wmc.5 for ; Mon, 02 Aug 2021 05:57:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=references:user-agent:from:to:cc:subject:date:in-reply-to :message-id:mime-version:content-transfer-encoding; bh=CnybaXaXRXuXzr+hZu8XpTrvMXCOABG1P6Qfhb+BmoE=; b=Sr5QH91mlmN1jqWWDkGfwyulWOmON7Mjk33PgfnSr9j5GMdqO1go88n1v1Yo0+Ki45 /j+7gx6tRp04HvzMPv6xmOyNEJAsaYEy7RxTt5tThoUPLs6ym/OhkR68Y5zFN12XQXSq Rc0DPP+YBWfnkNDf4VNudhMLIyNUQgmWTrRyqEb2rgTcJlP7pHr7hgosL9a2N1jvSQry od0Xq1q1dyqNM6uD/DuAiIEIL6ASB63JsOAL4Gr8vCklcOGMVnI12qi0rYIi7cUv6pNb 4UCvm2xIk72iXrWz5fokLooLE70fhPTGqvNiuIH5fQ/gv0caFN38wokN915mYPnNZdtc HyIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject:date :in-reply-to:message-id:mime-version:content-transfer-encoding; bh=CnybaXaXRXuXzr+hZu8XpTrvMXCOABG1P6Qfhb+BmoE=; b=eTVcHx+ZxkZf0Vz3qwuqvflOZgl/MMM2YzSxHuiWnxfl5BMzkP6NOluiMBj61PKJxc 8FdWVaDE17Td7XZMBg17OwZpI8Htm9ojSSTCTu2TXaBXytp8qR/T3NqxzkdPTE1sibOQ eypP8laFdIbhtj9qbAjSEDlBx43Z1zh4w5+ovYN1LbkNEZi9WKPbs4Yca8zKB3nqu9Dg /P1z0nBI/wDb/Gnxo4kzcOZ04VImr5n3UDYzrOXHLeqIHeeHFG9EOYSraLe2Rp5uPQ1T eXaMCGPXBBTUJhxa2rPhwW1RZz1Isi6YIFuYl/FRvGrbe1bbQtoHyQyBAPtslxJOMjQY L5gg== X-Gm-Message-State: AOAM530xYxYzqdo0JEO1svR7/1RompiOQJH+6bthF7Cznx4YlrHhnPqz XordrRn9hWqgl+sU2we0s+r5iA== X-Google-Smtp-Source: ABdhPJxKLcYrdwE9cZP5kCynBeinee0P9XgacBlW1UzNomRaMYho/3erD3drcCEYUlIOGSINpy5Wzw== X-Received: by 2002:a05:600c:4eca:: with SMTP id g10mr5713878wmq.60.1627909036275; Mon, 02 Aug 2021 05:57:16 -0700 (PDT) Received: from zen.linaroharston ([51.148.130.216]) by smtp.gmail.com with ESMTPSA id b20sm8341103wmj.48.2021.08.02.05.57.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Aug 2021 05:57:13 -0700 (PDT) Received: from zen (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 09AE61FF96; Mon, 2 Aug 2021 13:57:13 +0100 (BST) References: User-agent: mu4e 1.6.1; emacs 28.0.50 From: Alex =?utf-8?Q?Benn=C3=A9e?= To: =?utf-8?Q?Daniel_P=2E_Berrang=C3=A9?= Subject: Re: "make check-acceptance" takes way too long Date: Mon, 02 Aug 2021 13:55:44 +0100 In-reply-to: Message-ID: <878s1kgg2f.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2a00:1450:4864:20::32d; envelope-from=alex.bennee@linaro.org; helo=mail-wm1-x32d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , QEMU Developers , Cleber Rosa Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Daniel P. Berrang=C3=A9 writes: > On Fri, Jul 30, 2021 at 04:12:27PM +0100, Peter Maydell wrote: >> "make check-acceptance" takes way way too long. I just did a run >> on an arm-and-aarch64-targets-only debug build and it took over >> half an hour, and this despite it skipping or cancelling 26 out >> of 58 tests! >>=20 >> I think that ~10 minutes runtime is reasonable. 30 is not; >> ideally no individual test would take more than a minute or so. >>=20 >> Output saying where the time went. The first two tests take >> more than 10 minutes *each*. I think a good start would be to find >> a way of testing what they're testing that is less heavyweight. > > While there is certainly value in testing with a real world "full" guest > OS, I think it is overkill as the default setup. I reckon we would get > 80-90% of the value, by making our own test image repo, containing minimal > kernel builds for each machine/target combo we need, together with a tiny > initrd containing busybox. Also another minor wrinkle for this test is because we are booting via firmware we need a proper disk image with bootloader and the rest of it which involves more faff than a simple kernel+initrd (which is my goto format for the local zoo of testing images I have). --=20 Alex Benn=C3=A9e