From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19E79C433ED for ; Tue, 18 May 2021 11:00:22 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B5D4061209 for ; Tue, 18 May 2021 11:00:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B5D4061209 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:49548 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lixSW-0004LN-OT for qemu-devel@archiver.kernel.org; Tue, 18 May 2021 07:00:20 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55628) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lixQB-0002JK-Sa for qemu-devel@nongnu.org; Tue, 18 May 2021 06:57:57 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:34237) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lixQ8-0003NI-2l for qemu-devel@nongnu.org; Tue, 18 May 2021 06:57:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1621335470; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=l0B7c9NphGTTDcxD6Nte3rvJmLXnKUMefVOMCXg7N1g=; b=AAmeQ5N8JJ64Js+s2Pbolga8iS5maaYK8Rgn6aXgrUuywWL5cnkSPGovuTdlC1dWizGSMw fk1UKuC2Rs0RvdroBGaS1pBDTTduxJI2jHOAyOJ6uLb/DKJPcoL9cgTgsnbtwd28dinc2v iB72RcjD26Z22tKuohd+Meaa5rc0R08= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-75-vUoftNAgP8a4r-CSh4mHZA-1; Tue, 18 May 2021 06:57:49 -0400 X-MC-Unique: vUoftNAgP8a4r-CSh4mHZA-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 23AEB801B39 for ; Tue, 18 May 2021 10:57:48 +0000 (UTC) Received: from blackfin.pond.sub.org (ovpn-114-17.ams2.redhat.com [10.36.114.17]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E358250FA1; Tue, 18 May 2021 10:57:47 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 582CD113861E; Tue, 18 May 2021 12:57:46 +0200 (CEST) From: Markus Armbruster To: Paolo Bonzini Subject: Re: [PATCH] remove qemu-options* from root directory References: <20210517121908.2624991-1-pbonzini@redhat.com> <875yzg776s.fsf@dusky.pond.sub.org> Date: Tue, 18 May 2021 12:57:46 +0200 In-Reply-To: (Paolo Bonzini's message of "Tue, 18 May 2021 12:33:29 +0200") Message-ID: <878s4c5mxh.fsf@dusky.pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=armbru@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain Received-SPF: pass client-ip=216.205.24.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -31 X-Spam_score: -3.2 X-Spam_bar: --- X-Spam_report: (-3.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.374, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Paolo Bonzini writes: > On 18/05/21 10:54, Markus Armbruster wrote: >> Paolo Bonzini writes: >> >>> These headers are also included from softmmu/vl.c, so they should be >>> in include/. Removing qemu-options-wrapper.h, since elsewhere >>> we include "template" headers directly and #define the parameters in >>> the including file, and move qemu-options.h to include/. >>> >>> Signed-off-by: Paolo Bonzini >>> --- >>> qemu-options.h => include/qemu/qemu-options.h | 9 ++++- >>> os-posix.c | 2 +- >>> os-win32.c | 1 - >>> qemu-options-wrapper.h | 40 ------------------- >>> qemu-options.hx | 4 ++ >>> softmmu/vl.c | 24 ++++++++--- >>> 6 files changed, 31 insertions(+), 49 deletions(-) >>> rename qemu-options.h => include/qemu/qemu-options.h (88%) >>> delete mode 100644 qemu-options-wrapper.h >> >> Much nicer without qemu-options-wrapper.h. >> >> I'd be tempted to rename qemu-options.def while there (what's .def?), >> but that's up to you. >> >> Reviewed-by: Markus Armbruster > > I was tempted too, but qemu-options.h is already taken (well, > qemu/qemu-options.h) and I didn't have any good ideas about the name. qemu-options.inc?