From: Markus Armbruster <armbru@redhat.com>
To: Li Zhang <zhlcindy@gmail.com>
Cc: lukasstraub2@web.de, alexandr.iarygin@profitbricks.com,
qemu-devel@nongnu.org, Li Zhang <li.zhang@cloud.ionos.com>,
pankaj.gupta@cloud.ionos.com, marcandre.lureau@redhat.com
Subject: Re: [PATCH 2/2] Support monitor chardev hotswap with QMP
Date: Fri, 16 Apr 2021 11:33:33 +0200 [thread overview]
Message-ID: <87a6py7evm.fsf@dusky.pond.sub.org> (raw)
In-Reply-To: <CAD8of+oJM6+5Q05WRrbj=dd0fmcR2C80YvWK4F=T1A_HK4nKBQ@mail.gmail.com> (Li Zhang's message of "Tue, 13 Apr 2021 10:51:12 +0200")
Li Zhang <zhlcindy@gmail.com> writes:
> On Tue, Apr 13, 2021 at 8:41 AM Markus Armbruster <armbru@redhat.com> wrote:
>>
>> Li Zhang <zhlcindy@gmail.com> writes:
>>
>> > From: Li Zhang <li.zhang@cloud.ionos.com>
>> >
>> > For some scenarios, it needs to hot-add a monitor device.
>> > But QEMU doesn't support hotplug yet. It also works by adding
>> > a monitor with null backend by default and then change its
>> > backend to socket by QMP command "chardev-change".
>> >
>> > So this patch is to support monitor chardev hotswap with QMP.
>> >
>> > Signed-off-by: Li Zhang <li.zhang@cloud.ionos.com>
>>
>> I think what what you're trying to say is that chardev-change does not
>> work when the character device changes is used by a QMP monitor.
>> Correct?
>>
> I mean that when the character device is a monitor device, it doesn't
> work with a QMP monitor.
> For example, I add 2 QMP monitors and change one of the monitor's
> backends from socket to a null device.
> It doesn't work because it needs the monitor device to support chardev-change.
>
>> If yes, how exactly does it misbehave?
> This command chardev-change needs specific device's change callback function.
Yes, but what happens if you try anyway? I'm asking, because I'd like
the answer to be worked into the commit message.
>> Does it work with an HMP monitor?
> No, it doesn't work.
next prev parent reply other threads:[~2021-04-16 9:34 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-15 17:06 [PATCH 1/2] Fix the segment fault when calling yank_register_instance Li Zhang
2021-03-15 17:06 ` [PATCH 2/2] Support monitor chardev hotswap with QMP Li Zhang
2021-03-23 13:14 ` Li Zhang
2021-03-26 14:40 ` Markus Armbruster
2021-03-26 15:19 ` Li Zhang
2021-04-12 12:41 ` Li Zhang
2021-04-12 13:10 ` Markus Armbruster
2021-04-12 13:41 ` Li Zhang
2021-04-12 14:19 ` Pankaj Gupta
2021-04-13 6:40 ` Markus Armbruster
2021-04-13 8:51 ` Li Zhang
2021-04-16 9:33 ` Markus Armbruster [this message]
2021-04-16 9:52 ` Li Zhang
2021-04-13 8:57 ` Daniel P. Berrangé
2021-04-13 9:33 ` Li Zhang
2021-03-15 18:51 ` [PATCH 1/2] Fix the segment fault when calling yank_register_instance Marc-André Lureau
2021-03-16 9:45 ` Li Zhang
2021-03-16 14:46 ` Li Zhang
2021-03-16 15:24 ` Marc-André Lureau
2021-03-16 15:36 ` Li Zhang
2021-03-17 21:06 ` Lukas Straub
2021-03-26 14:41 ` Markus Armbruster
2021-03-26 16:02 ` Lukas Straub
2021-03-26 16:13 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a6py7evm.fsf@dusky.pond.sub.org \
--to=armbru@redhat.com \
--cc=alexandr.iarygin@profitbricks.com \
--cc=li.zhang@cloud.ionos.com \
--cc=lukasstraub2@web.de \
--cc=marcandre.lureau@redhat.com \
--cc=pankaj.gupta@cloud.ionos.com \
--cc=qemu-devel@nongnu.org \
--cc=zhlcindy@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).