From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28F39C5DF60 for ; Fri, 8 Nov 2019 15:37:51 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E799A21882 for ; Fri, 8 Nov 2019 15:37:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="aUxhLplX" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E799A21882 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:56374 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iT6Kb-0000Tx-W2 for qemu-devel@archiver.kernel.org; Fri, 08 Nov 2019 10:37:50 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:48757) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iT5zV-0002Hf-Ro for qemu-devel@nongnu.org; Fri, 08 Nov 2019 10:16:03 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iT5zT-0001hZ-A2 for qemu-devel@nongnu.org; Fri, 08 Nov 2019 10:16:01 -0500 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:28095 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iT5zT-0001fz-5k for qemu-devel@nongnu.org; Fri, 08 Nov 2019 10:15:59 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1573226157; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9uGkM2ScxKkd527ZctXcwbbvuzGfdXH3Rau2IM2RRUk=; b=aUxhLplXgb8ZYPWdrAduh3dhiwWYv4vWkR15fnpROZZ+rfaaIHnqgVK/EtIJ5UiFrRlooM wd58gxqJ1b3z0z2ZfiOKqDB5GHLmsNpJrLVy3VkiHOFFxAN8Jq4nm8k2fHQgMlW9iaiMWh ayj49PXh5PZ7B6sW7y3OjOtmXEziwZc= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-64-yKCHPV2QNDSCXZagHpSY1A-1; Fri, 08 Nov 2019 10:15:53 -0500 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 979B48017DD; Fri, 8 Nov 2019 15:15:52 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.36.118.123]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 65C405DA81; Fri, 8 Nov 2019 15:15:52 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id D940F11385C9; Fri, 8 Nov 2019 16:15:50 +0100 (CET) From: Markus Armbruster To: Jan Kiszka Subject: Re: [PATCH v2] ivshmem-server: Terminate also on SIGINT References: <99c1a7bd-1876-66a2-4b8e-d5bc86116fe7@web.de> Date: Fri, 08 Nov 2019 16:15:50 +0100 In-Reply-To: (Jan Kiszka's message of "Fri, 8 Nov 2019 10:08:31 +0100") Message-ID: <87a7968km1.fsf@dusky.pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-MC-Unique: yKCHPV2QNDSCXZagHpSY1A-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=WINDOWS-1252 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 205.139.110.120 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, qemu-devel , Claudio Fontana Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Jan Kiszka writes: > On 03.08.19 15:22, Jan Kiszka wrote: >> From: Jan Kiszka >> >> Allows to shutdown a foreground session via ctrl-c. >> >> Signed-off-by: Jan Kiszka >> --- >> >> Changes in v2: >> - adjust error message >> >> contrib/ivshmem-server/main.c | 5 +++-- >> 1 file changed, 3 insertions(+), 2 deletions(-) >> >> diff --git a/contrib/ivshmem-server/main.c b/contrib/ivshmem-server/main= .c >> index 197c79c57e..e4cd35f74c 100644 >> --- a/contrib/ivshmem-server/main.c >> +++ b/contrib/ivshmem-server/main.c >> @@ -223,8 +223,9 @@ main(int argc, char *argv[]) >> sa_quit.sa_handler =3D ivshmem_server_quit_cb; >> sa_quit.sa_flags =3D 0; >> if (sigemptyset(&sa_quit.sa_mask) =3D=3D -1 || >> - sigaction(SIGTERM, &sa_quit, 0) =3D=3D -1) { >> - perror("failed to add SIGTERM handler; sigaction"); >> + sigaction(SIGTERM, &sa_quit, 0) =3D=3D -1 || >> + sigaction(SIGINT, &sa_quit, 0) =3D=3D -1) { >> + perror("failed to add signal handler; sigaction"); >> goto err; >> } >> >> -- >> 2.16.4 >> >> > > ...and this one for you as well, Markus? Cc: qemu-trivial