From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9CB5CC2B9F7 for ; Fri, 28 May 2021 15:37:02 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2DA3961378 for ; Fri, 28 May 2021 15:37:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2DA3961378 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=users.sourceforge.jp Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:48850 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lmeXl-00039T-8H for qemu-devel@archiver.kernel.org; Fri, 28 May 2021 11:37:01 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59262) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lmeWR-0000y3-0z for qemu-devel@nongnu.org; Fri, 28 May 2021 11:35:39 -0400 Received: from mail03.asahi-net.or.jp ([202.224.55.15]:38281) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lmeWN-0007Ow-Lq for qemu-devel@nongnu.org; Fri, 28 May 2021 11:35:38 -0400 Received: from sakura.ysato.name (ik1-413-38519.vs.sakura.ne.jp [153.127.30.23]) (Authenticated sender: PQ4Y-STU) by mail03.asahi-net.or.jp (Postfix) with ESMTPA id 77C0D383B5; Sat, 29 May 2021 00:35:32 +0900 (JST) Received: from yo-satoh-debian.ysato.ml (ZM005235.ppp.dion.ne.jp [222.8.5.235]) by sakura.ysato.name (Postfix) with ESMTPSA id 14B2E1C050B; Sat, 29 May 2021 00:35:32 +0900 (JST) Date: Sat, 29 May 2021 00:35:21 +0900 Message-ID: <87bl8u7txi.wl-ysato@users.sourceforge.jp> From: Yoshinori Sato To: Richard Henderson Subject: Re: [PATCH 08/11] target/rx: Fix setting of FPSW.CE In-Reply-To: <20210527041405.391567-9-richard.henderson@linaro.org> References: <20210527041405.391567-1-richard.henderson@linaro.org> <20210527041405.391567-9-richard.henderson@linaro.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL/10.8 EasyPG/1.0.0 Emacs/27 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Received-SPF: softfail client-ip=202.224.55.15; envelope-from=ysato@users.sourceforge.jp; helo=mail03.asahi-net.or.jp X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_SOFTFAIL=0.665 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mmorrell@tachyum.com, alex.bennee@linaro.org, qemu-devel@nongnu.org, Philippe =?ISO-8859-1?Q?Mathieu-Daud=E9?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Thu, 27 May 2021 13:14:02 +0900, Richard Henderson wrote: >=20 > The existing check was completely wrong, confused about the > definition of the (previous) float_flag_{input,output}_denormal > flags, then making sure that DN, the flush-to-zero bit, was off. >=20 > Update for the introduction of float_flag_inorm_denormal and > float_flag_result_denormal, taking into account that DN now sets > the softfloat flush-to-zero bits. >=20 > Cc: Philippe Mathieu-Daud=E9 > Cc: Yoshinori Sato > Signed-off-by: Richard Henderson Reviewd-by: Yoshinori Sato > --- > target/rx/op_helper.c | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) >=20 > diff --git a/target/rx/op_helper.c b/target/rx/op_helper.c > index b1772e9538..c2e4f9a5e3 100644 > --- a/target/rx/op_helper.c > +++ b/target/rx/op_helper.c > @@ -97,9 +97,11 @@ static void update_fpsw(CPURXState *env, float32 ret, = uintptr_t retaddr) > if (xcpt & float_flag_inexact) { > SET_FPSW(X); > } > - if ((xcpt & (float_flag_iflush_denormal > - | float_flag_oflush_denormal)) > - && !FIELD_EX32(env->fpsw, FPSW, DN)) { > + /* > + * If any input or output denormals, not flushed to zero, raise = CE: > + * unimplemented processing has been encountered. > + */ > + if (xcpt & (float_flag_inorm_denormal | float_flag_result_denorm= al)) { > env->fpsw =3D FIELD_DP32(env->fpsw, FPSW, CE, 1); > } > =20 > --=20 > 2.25.1 >=20 >=20